Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Render other tab icons in the start slot (#14683)

Browse source 
This PR reworks the rendering for tab icons to allow us to render all of
the tab icons—not just file icons—in the tab's start slot.

The `Item` trait now has a separate `tab_icon` method that can be used
to indicate what icon should be shown for the tab.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-07-17 16:59:41 -04:00 • committed by GitHub
parent 2edf224599
commit 00c3c02f7d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 80 additions and 80 deletions
Download patch file Download diff file Expand all files Collapse all files

14
crates/terminal_view/src/terminal_view.rs
View file

@ -943,13 +943,13 @@ impl Item for TerminalView {
let terminal = self.terminal().read(cx);
let title = terminal.title(true);
let (icon, icon_color, rerun_btn) = match terminal.task() {
let (icon, icon_color, rerun_button) = match terminal.task() {
Some(terminal_task) => match &terminal_task.status {
TaskStatus::Unknown => (IconName::ExclamationTriangle, Color::Warning, None),
TaskStatus::Running => (IconName::Play, Color::Disabled, None),
TaskStatus::Completed { success } => {
let task_id = terminal_task.id.clone();
let rerun_btn = IconButton::new("rerun-icon", IconName::Rerun)
let rerun_button = IconButton::new("rerun-icon", IconName::Rerun)
.icon_size(IconSize::Small)
.size(ButtonSize::Compact)
.icon_color(Color::Default)
@ -963,9 +963,9 @@ impl Item for TerminalView {
});
if *success {
(IconName::Check, Color::Success, Some(rerun_btn))
(IconName::Check, Color::Success, Some(rerun_button))
} else {
(IconName::XCircle, Color::Error, Some(rerun_btn))
(IconName::XCircle, Color::Error, Some(rerun_button))
}
}
},
@ -980,17 +980,17 @@ impl Item for TerminalView {
.group("term-tab-icon")
.child(
div()
.when(rerun_btn.is_some(), |this| {
.when(rerun_button.is_some(), |this| {
this.hover(|style| style.invisible().w_0())
})
.child(Icon::new(icon).color(icon_color)),
)
.when_some(rerun_btn, |this, rerun_btn| {
.when_some(rerun_button, |this, rerun_button| {
this.child(
div()
.absolute()
.visible_on_hover("term-tab-icon")
.child(rerun_btn),
.child(rerun_button),
)
}),
)