debugger: Fix the JavaScript debug terminal scenario (#33924)
There were a couple of things preventing this from working: - our hack to stop the node REPL from appearing broke in recent versions of the JS DAP that started passing `--experimental-network-inspection` by default - we had lost the ability to create a debug terminal without specifying a program This PR fixes those issues. We also fixed environment variables from the **runInTerminal** request not getting passed to the spawned program. Release Notes: - Debugger: Fix RunInTerminal not working for JavaScript debugger. --------- Co-authored-by: Cole Miller <cole@zed.dev>
This commit is contained in:
parent
66e45818af
commit
01295aa687
14 changed files with 108 additions and 73 deletions
|
@ -255,7 +255,7 @@ impl TaskTemplate {
|
|||
command_label
|
||||
},
|
||||
),
|
||||
command,
|
||||
command: Some(command),
|
||||
args: self.args.clone(),
|
||||
env,
|
||||
use_new_terminal: self.use_new_terminal,
|
||||
|
@ -635,7 +635,7 @@ mod tests {
|
|||
"Human-readable label should have long substitutions trimmed"
|
||||
);
|
||||
assert_eq!(
|
||||
spawn_in_terminal.command,
|
||||
spawn_in_terminal.command.clone().unwrap(),
|
||||
format!("echo test_file {long_value}"),
|
||||
"Command should be substituted with variables and those should not be shortened"
|
||||
);
|
||||
|
@ -652,7 +652,7 @@ mod tests {
|
|||
spawn_in_terminal.command_label,
|
||||
format!(
|
||||
"{} arg1 test_selected_text arg2 5678 arg3 {long_value}",
|
||||
spawn_in_terminal.command
|
||||
spawn_in_terminal.command.clone().unwrap()
|
||||
),
|
||||
"Command label args should be substituted with variables and those should not be shortened"
|
||||
);
|
||||
|
@ -711,7 +711,7 @@ mod tests {
|
|||
assert_substituted_variables(&resolved_task, Vec::new());
|
||||
let resolved = resolved_task.resolved;
|
||||
assert_eq!(resolved.label, task.label);
|
||||
assert_eq!(resolved.command, task.command);
|
||||
assert_eq!(resolved.command, Some(task.command));
|
||||
assert_eq!(resolved.args, task.args);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue