Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove uneeded Workspace::project_remote_id_changed method

Browse source
This commit is contained in:
Max Brunsfeld 2023-09-29 08:54:23 -07:00
parent ca0a4bdf8e
commit 026b3a1d0f
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/workspace/src/workspace.rs
View file

@ -622,9 +622,8 @@ impl Workspace {
cx.observe(&project, |_, _, cx| cx.notify()).detach(); cx.observe(&project, |_, _, cx| cx.notify()).detach();
cx.subscribe(&project, move |this, _, event, cx| { cx.subscribe(&project, move |this, _, event, cx| {
match event { match event {
project::Event::RemoteIdChanged(remote_id) => { project::Event::RemoteIdChanged(_) => {
this.update_window_title(cx); this.update_window_title(cx);
this.project_remote_id_changed(*remote_id, cx);
} }
project::Event::CollaboratorLeft(peer_id) => { project::Event::CollaboratorLeft(peer_id) => {
@ -776,7 +775,8 @@ impl Workspace {
}), }),
]; ];
let mut this = Workspace { cx.defer(|this, cx| this.update_window_title(cx));
Workspace {
weak_self: weak_handle.clone(), weak_self: weak_handle.clone(),
modal: None, modal: None,
zoomed: None, zoomed: None,
@ -805,10 +805,7 @@ impl Workspace {
leader_updates_tx, leader_updates_tx,
subscriptions, subscriptions,
pane_history_timestamp, pane_history_timestamp,
}; }
this.project_remote_id_changed(project.read(cx).remote_id(), cx);
cx.defer(|this, cx| this.update_window_title(cx));
this
} }
fn new_local( fn new_local(
@ -2512,10 +2509,6 @@ impl Workspace {
&self.active_pane &self.active_pane
} }
fn project_remote_id_changed(&mut self, _project_id: Option<u64>, _cx: &mut ViewContext<Self>) {
// TODO
}
fn collaborator_left(&mut self, peer_id: PeerId, cx: &mut ViewContext<Self>) { fn collaborator_left(&mut self, peer_id: PeerId, cx: &mut ViewContext<Self>) {
if let Some(states_by_pane) = self.follower_states_by_leader.remove(&peer_id) { if let Some(states_by_pane) = self.follower_states_by_leader.remove(&peer_id) {
for state in states_by_pane.into_values() { for state in states_by_pane.into_values() {