Add default method for CompletionProvider::resolve_completions (#32045)

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-06-05 13:15:06 -06:00 committed by GitHub
parent 894f3b9d15
commit 03a030fd00
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 11 additions and 65 deletions

View file

@ -1,7 +1,5 @@
use std::cell::RefCell;
use std::ops::Range;
use std::path::{Path, PathBuf};
use std::rc::Rc;
use std::sync::Arc;
use std::sync::atomic::AtomicBool;
@ -912,16 +910,6 @@ impl CompletionProvider for ContextPickerCompletionProvider {
})
}
fn resolve_completions(
&self,
_buffer: Entity<Buffer>,
_completion_indices: Vec<usize>,
_completions: Rc<RefCell<Box<[Completion]>>>,
_cx: &mut Context<Editor>,
) -> Task<Result<bool>> {
Task::ready(Ok(true))
}
fn is_completion_trigger(
&self,
buffer: &Entity<language::Buffer>,
@ -1077,7 +1065,7 @@ mod tests {
use project::{Project, ProjectPath};
use serde_json::json;
use settings::SettingsStore;
use std::ops::Deref;
use std::{ops::Deref, rc::Rc};
use util::{path, separator};
use workspace::{AppState, Item};