Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add default method for CompletionProvider::resolve_completions (#32045)

Browse source 
Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-06-05 13:15:06 -06:00 • committed by GitHub
parent 894f3b9d15
commit 03a030fd00
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 11 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/collab_ui/src/chat_panel/message_editor.rs
View file

@ -15,7 +15,6 @@ use language::{
use project::{Completion, CompletionResponse, CompletionSource, search::SearchQuery};
use settings::Settings;
use std::{
cell::RefCell,
ops::Range,
rc::Rc,
sync::{Arc, LazyLock},
@ -73,16 +72,6 @@ impl CompletionProvider for MessageEditorCompletionProvider {
})
}
fn resolve_completions(
&self,
_buffer: Entity<Buffer>,
_completion_indices: Vec<usize>,
_completions: Rc<RefCell<Box<[Completion]>>>,
_cx: &mut Context<Editor>,
) -> Task<anyhow::Result<bool>> {
Task::ready(Ok(false))
}
fn is_completion_trigger(
&self,
_buffer: &Entity<Buffer>,
@ -255,7 +244,7 @@ impl MessageEditor {
{
if !candidates.is_empty() {
return cx.spawn(async move |_, cx| {
let completion_response = Self::resolve_completions_for_candidates(
let completion_response = Self::completions_for_candidates(
&cx,
query.as_str(),
&candidates,
@ -273,7 +262,7 @@ impl MessageEditor {
{
if !candidates.is_empty() {
return cx.spawn(async move |_, cx| {
let completion_response = Self::resolve_completions_for_candidates(
let completion_response = Self::completions_for_candidates(
&cx,
query.as_str(),
candidates,
@ -292,7 +281,7 @@ impl MessageEditor {
}]))
}
async fn resolve_completions_for_candidates(
async fn completions_for_candidates(
cx: &AsyncApp,
query: &str,
candidates: &[StringMatchCandidate],