Add default method for CompletionProvider::resolve_completions (#32045)

Release Notes:

- N/A
This commit is contained in:
Michael Sloan 2025-06-05 13:15:06 -06:00 committed by GitHub
parent 894f3b9d15
commit 03a030fd00
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 11 additions and 65 deletions

View file

@ -12,7 +12,6 @@ use language::{
};
use project::lsp_store::CompletionDocumentation;
use project::{Completion, CompletionResponse, CompletionSource, Project, ProjectPath};
use std::cell::RefCell;
use std::fmt::Write as _;
use std::ops::Range;
use std::path::Path;
@ -671,16 +670,6 @@ impl CompletionProvider for RustStyleCompletionProvider {
}]))
}
fn resolve_completions(
&self,
_buffer: Entity<Buffer>,
_completion_indices: Vec<usize>,
_completions: Rc<RefCell<Box<[Completion]>>>,
_cx: &mut Context<Editor>,
) -> Task<Result<bool>> {
Task::ready(Ok(true))
}
fn is_completion_trigger(
&self,
buffer: &Entity<language::Buffer>,