From 03d0b68f0cd45df0a63fecd565a1db3482f9e0ef Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Thu, 25 Apr 2024 21:29:56 -0600 Subject: [PATCH] Fix panic in rename selections (#11033) cc @someonetoignore Release Notes: - Fixed a panic when renaming with a selection (preview only) --- crates/editor/src/editor.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index f51c3237ac..b2b299e780 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -8206,9 +8206,13 @@ impl Editor { cursor_offset_in_rename_range_end..cursor_offset_in_rename_range } }; - editor.change_selections(Some(Autoscroll::fit()), cx, |s| { - s.select_ranges([rename_selection_range]); - }); + if rename_selection_range.end > old_name.len() { + editor.select_all(&SelectAll, cx); + } else { + editor.change_selections(Some(Autoscroll::fit()), cx, |s| { + s.select_ranges([rename_selection_range]); + }); + } editor });