Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

markdown: Move open_url to the MarkdownElement as on_url_click (#28269)

Browse source 
Release Notes:

- N/A

---------

Co-authored-by: Antonio Scandurra <me@as-cii.com>
This commit is contained in:
Marshall Bowers 2025-04-07 16:43:00 -04:00 • committed by GitHub
parent d3abc61728
commit 0414908c4a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 201 additions and 194 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/editor/src/code_context_menus.rs
View file

@ -624,16 +624,15 @@ impl CompletionsMenu {
.map(|l| l.name().to_proto());
Markdown::new(SharedString::default(), languages, language, cx)
.copy_code_block_buttons(false)
.open_url(open_markdown_url)
})
});
markdown.update(cx, |markdown, cx| {
markdown.reset(parsed.clone(), cx);
});
div().child(MarkdownElement::new(
markdown.clone(),
hover_markdown_style(window, cx),
))
div().child(
MarkdownElement::new(markdown.clone(), hover_markdown_style(window, cx))
.on_url_click(open_markdown_url),
)
}
CompletionDocumentation::MultiLineMarkdown(_) => return None,
CompletionDocumentation::SingleLine(_) => return None,

20
crates/editor/src/hover_popover.rs
View file

@ -336,7 +336,7 @@ fn show_hover(
}
};
Markdown::new_text(SharedString::new(text), cx).open_url(open_markdown_url)
Markdown::new_text(SharedString::new(text), cx)
})
.ok();
@ -547,7 +547,6 @@ async fn parse_blocks(
cx,
)
.copy_code_block_buttons(false)
.open_url(open_markdown_url)
})
.ok();
@ -783,10 +782,13 @@ impl InfoPopover {
.max_h(max_size.height)
.p_2()
.track_scroll(&self.scroll_handle)
.child(MarkdownElement::new(
markdown.clone(),
hover_markdown_style(window, cx),
)),
.child(
MarkdownElement::new(
markdown.clone(),
hover_markdown_style(window, cx),
)
.on_url_click(open_markdown_url),
),
)
.child(self.render_vertical_scrollbar(cx));
}
@ -881,8 +883,10 @@ impl DiagnosticPopover {
..Default::default()
};
markdown_div =
markdown_div.child(MarkdownElement::new(markdown.clone(), markdown_style));
markdown_div = markdown_div.child(
MarkdownElement::new(markdown.clone(), markdown_style)
.on_url_click(open_markdown_url),
);
}
if let Some(background_color) = &self.background_color {