Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Resolve completions properly (#18212)

Browse source 
Related to https://github.com/rust-lang/rust-analyzer/pull/18167

* Declare more completion item fields in the client completion resolve
capabilities
* Do resolve completions even if their docs are present
* Instead, do not resolve completions that could not be resolved when
handling the remote client resolve requests
* Do replace the old lsp completion data with the resolved one

Release Notes:

- Improved completion resolve mechanism
This commit is contained in:
Kirill Bulatov 2024-09-23 12:53:57 +03:00 • committed by GitHub
parent bb7d9d3525
commit 05d18321db
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 35 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

1
crates/proto/proto/zed.proto
View file

@ -1219,6 +1219,7 @@ message ResolveCompletionDocumentationResponse {
Anchor old_start = 3;
Anchor old_end = 4;
string new_text = 5;
bytes lsp_completion = 6;
}
message ResolveInlayHint {