Fix a bunch of other low-hanging style lints (#36498)

- **Fix a bunch of low hanging style lints like unnecessary-return**
- **Fix single worktree violation**
- **And the rest**

Release Notes:

- N/A
This commit is contained in:
Piotr Osiewicz 2025-08-19 21:26:17 +02:00 committed by GitHub
parent df9c2aefb1
commit 05fc0c432c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
239 changed files with 854 additions and 1015 deletions

View file

@ -122,7 +122,7 @@ impl PtyProcessInfo {
}
pub(crate) fn kill_current_process(&mut self) -> bool {
self.refresh().map_or(false, |process| process.kill())
self.refresh().is_some_and(|process| process.kill())
}
fn load(&mut self) -> Option<ProcessInfo> {

View file

@ -1299,23 +1299,19 @@ impl Terminal {
let selection = Selection::new(selection_type, point, side);
self.events
.push_back(InternalEvent::SetSelection(Some((selection, point))));
return;
}
"escape" => {
self.events.push_back(InternalEvent::SetSelection(None));
return;
}
"y" => {
self.copy(Some(false));
return;
}
"i" => {
self.scroll_to_bottom();
self.toggle_vi_mode();
return;
}
_ => {}
}
@ -1891,11 +1887,11 @@ impl Terminal {
let e: Option<ExitStatus> = error_code.map(|code| {
#[cfg(unix)]
{
return std::os::unix::process::ExitStatusExt::from_raw(code);
std::os::unix::process::ExitStatusExt::from_raw(code)
}
#[cfg(windows)]
{
return std::os::windows::process::ExitStatusExt::from_raw(code as u32);
std::os::windows::process::ExitStatusExt::from_raw(code as u32)
}
});

View file

@ -124,12 +124,12 @@ pub(super) fn find_from_grid_point<T: EventListener>(
&& file_path
.chars()
.nth(last_index - 1)
.map_or(false, |c| c.is_ascii_digit());
.is_some_and(|c| c.is_ascii_digit());
let next_is_digit = last_index < file_path.len() - 1
&& file_path
.chars()
.nth(last_index + 1)
.map_or(true, |c| c.is_ascii_digit());
.is_none_or(|c| c.is_ascii_digit());
if prev_is_digit && !next_is_digit {
let stripped_len = file_path.len() - last_index;
word_match = Match::new(