From 08b1545c85d723645a3b143f3e2e3622e755f19a Mon Sep 17 00:00:00 2001 From: Conrad Irwin Date: Wed, 16 Oct 2024 15:17:38 -0600 Subject: [PATCH] Show a user-visible error message if saving fails (#19311) Release Notes: - Added a user-visible error message when a manual save fails. --- crates/workspace/src/workspace.rs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/crates/workspace/src/workspace.rs b/crates/workspace/src/workspace.rs index ec4079ba9f..e07e25063c 100644 --- a/crates/workspace/src/workspace.rs +++ b/crates/workspace/src/workspace.rs @@ -46,7 +46,9 @@ use itertools::Itertools; use language::{LanguageRegistry, Rope}; pub use modal_layer::*; use node_runtime::NodeRuntime; -use notifications::{simple_message_notification::MessageNotification, NotificationHandle}; +use notifications::{ + simple_message_notification::MessageNotification, DetachAndPromptErr, NotificationHandle, +}; pub use pane::*; pub use pane_group::*; pub use persistence::{ @@ -4359,17 +4361,17 @@ impl Workspace { .on_action(cx.listener(|workspace, action: &Save, cx| { workspace .save_active_item(action.save_intent.unwrap_or(SaveIntent::Save), cx) - .detach_and_log_err(cx); + .detach_and_prompt_err("Failed to save", cx, |_, _| None); })) .on_action(cx.listener(|workspace, _: &SaveWithoutFormat, cx| { workspace .save_active_item(SaveIntent::SaveWithoutFormat, cx) - .detach_and_log_err(cx); + .detach_and_prompt_err("Failed to save", cx, |_, _| None); })) .on_action(cx.listener(|workspace, _: &SaveAs, cx| { workspace .save_active_item(SaveIntent::SaveAs, cx) - .detach_and_log_err(cx); + .detach_and_prompt_err("Failed to save", cx, |_, _| None); })) .on_action(cx.listener(|workspace, _: &ActivatePreviousPane, cx| { workspace.activate_previous_pane(cx)