edit predictions: Enable blog post link behind a feature flag (#24720)

This PR updates the blog post link in the onboarding modal to be behind
the `predict-edits-launch` feature flag instead of a staff flag.

This will allow us to enable the blog post link once we're live.

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
This commit is contained in:
Danilo Leal 2025-02-12 20:59:06 -03:00 committed by GitHub
parent 277fb54632
commit 0a681225b6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 9 deletions

View file

@ -64,6 +64,12 @@ impl FeatureFlag for PredictEditsFeatureFlag {
const NAME: &'static str = "predict-edits";
}
/// A feature flag that controls things that shouldn't go live until the predictive edits launch.
pub struct PredictEditsLaunchFeatureFlag;
impl FeatureFlag for PredictEditsLaunchFeatureFlag {
const NAME: &'static str = "predict-edits-launch";
}
pub struct PredictEditsRateCompletionsFeatureFlag;
impl FeatureFlag for PredictEditsRateCompletionsFeatureFlag {
const NAME: &'static str = "predict-edits-rate-completions";

View file

@ -66,7 +66,7 @@ impl ZedPredictModal {
}
fn view_blog(&mut self, _: &ClickEvent, _: &mut Window, cx: &mut Context<Self>) {
cx.open_url("https://zed.dev/blog/"); // TODO Add the link when live
cx.open_url("https://zed.dev/blog/edit-predictions");
cx.notify();
onboarding_event!("Blog Link clicked");
@ -272,19 +272,16 @@ impl Render for ZedPredictModal {
)),
));
let blog_post_button = if cx.is_staff() {
Some(
let blog_post_button = cx
.has_flag::<feature_flags::PredictEditsLaunchFeatureFlag>()
.then(|| {
Button::new("view-blog", "Read the Blog Post")
.full_width()
.icon(IconName::ArrowUpRight)
.icon_size(IconSize::Indicator)
.icon_color(Color::Muted)
.on_click(cx.listener(Self::view_blog)),
)
} else {
// TODO: put back when blog post is published
None
};
.on_click(cx.listener(Self::view_blog))
});
if self.user_store.read(cx).current_user().is_some() {
let copy = match self.sign_in_status {