From 0c0201c79fbd7fb1ae137fb0dfc692b28cdcb28d Mon Sep 17 00:00:00 2001 From: Mikayla Maki Date: Wed, 19 Feb 2025 20:55:11 -0800 Subject: [PATCH] Upgrade Alacritty to respect `~/.hushlogin` (#25224) Closes #4827 Release Notes: - Fixed a bug where shells spawned by the Zed terminal would not hide the login message when `~/.hushlogin` exists --- Cargo.lock | 23 ++++++----------------- Cargo.toml | 2 +- crates/repl/src/outputs/plain.rs | 6 +++--- 3 files changed, 10 insertions(+), 21 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 412008d161..aa57d369e6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -83,9 +83,8 @@ dependencies = [ [[package]] name = "alacritty_terminal" -version = "0.25.0" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "5bccc2e60c2112dc8e8a722d6d30f2bb1a6a7b5d0e65fa695e09e57415dca7f7" +version = "0.25.1-dev" +source = "git+https://github.com/zed-industries/alacritty.git?rev=03c2907b44b4189aac5fdeaea331f5aab5c7072e#03c2907b44b4189aac5fdeaea331f5aab5c7072e" dependencies = [ "base64 0.22.1", "bitflags 2.8.0", @@ -14861,26 +14860,16 @@ dependencies = [ [[package]] name = "vte" -version = "0.13.1" +version = "0.15.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "9a0b683b20ef64071ff03745b14391751f6beab06a54347885459b77a3f2caa5" +checksum = "a5924018406ce0063cd67f8e008104968b74b563ee1b85dde3ed1f7cb87d3dbd" dependencies = [ + "arrayvec", "bitflags 2.8.0", "cursor-icon", "log", + "memchr", "serde", - "utf8parse", - "vte_generate_state_changes", -] - -[[package]] -name = "vte_generate_state_changes" -version = "0.1.2" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "2e369bee1b05d510a7b4ed645f5faa90619e05437111783ea5848f28d97d3c2e" -dependencies = [ - "proc-macro2", - "quote", ] [[package]] diff --git a/Cargo.toml b/Cargo.toml index c93c56486d..15edf729ca 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -364,7 +364,7 @@ zeta = { path = "crates/zeta" } # aho-corasick = "1.1" -alacritty_terminal = "0.25" +alacritty_terminal = { git = "https://github.com/zed-industries/alacritty.git", rev = "03c2907b44b4189aac5fdeaea331f5aab5c7072e"} any_vec = "0.14" anyhow = "1.0.86" arrayvec = { version = "0.7.4", features = ["serde"] } diff --git a/crates/repl/src/outputs/plain.rs b/crates/repl/src/outputs/plain.rs index f78b0f2d4c..3bae2bc190 100644 --- a/crates/repl/src/outputs/plain.rs +++ b/crates/repl/src/outputs/plain.rs @@ -184,10 +184,10 @@ impl TerminalOutput { for byte in text.as_bytes() { if *byte == b'\n' { // Dirty (?) hack to move the cursor down - self.parser.advance(&mut self.handler, b'\r'); - self.parser.advance(&mut self.handler, b'\n'); + self.parser.advance(&mut self.handler, &[b'\r']); + self.parser.advance(&mut self.handler, &[b'\n']); } else { - self.parser.advance(&mut self.handler, *byte); + self.parser.advance(&mut self.handler, &[*byte]); } }