Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

In add_option_view, avoid bumping view's ref counts if view is None

Browse source 
Co-Authored-By: Nathan Sobo <nathan@zed.dev>
This commit is contained in:
Antonio Scandurra 2021-12-03 17:52:39 +01:00
parent bd573e0651
commit 0e93bc41dd
1 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
crates/gpui/src/app.rs
View file

@ -1344,7 +1344,6 @@ impl MutableAppContext {
{ {
self.update(|this| { self.update(|this| {
let view_id = post_inc(&mut this.next_entity_id); let view_id = post_inc(&mut this.next_entity_id);
let handle = ViewHandle::new(window_id, view_id, &this.cx.ref_counts);
let mut cx = ViewContext::new(this, window_id, view_id); let mut cx = ViewContext::new(this, window_id, view_id);
let handle = if let Some(view) = build_view(&mut cx) { let handle = if let Some(view) = build_view(&mut cx) {
this.cx.views.insert((window_id, view_id), Box::new(view)); this.cx.views.insert((window_id, view_id), Box::new(view));
@ -1355,7 +1354,7 @@ impl MutableAppContext {
.updated .updated
.insert(view_id); .insert(view_id);
} }
Some(handle) Some(ViewHandle::new(window_id, view_id, &this.cx.ref_counts))
} else { } else {
None None
}; };