Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix error when requesting completion to Copilot Chat without tools (#30007)

Browse source 
The API will return a Bad Request (with no error message) when tools
were used previously in the conversation but no tools are provided as
part of a new request.

Inserting a dummy tool seems to circumvent this error.

Release Notes:

- Fixed an error that could sometimes occur when editing using Copilot
Chat.

Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
This commit is contained in:
Antonio Scandurra 2025-05-06 16:19:59 +02:00 • committed by GitHub
parent fed5f89f8d
commit 0f50e6b1d1
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/language_models/src/provider/copilot_chat.rs
View file

@ -436,6 +436,7 @@ impl CopilotChatLanguageModel {
}
}
let mut tool_called = false;
let mut messages: Vec<ChatMessage> = Vec::new();
for message in request_messages {
let text_content = {
@ -476,6 +477,7 @@ impl CopilotChatLanguageModel {
let mut tool_calls = Vec::new();
for content in &message.content {
if let MessageContent::ToolUse(tool_use) = content {
tool_called = true;
tool_calls.push(ToolCall {
id: tool_use.id.to_string(),
content: copilot::copilot_chat::ToolCallContent::Function {
@ -503,7 +505,7 @@ impl CopilotChatLanguageModel {
}
}
let tools = request
let mut tools = request
.tools
.iter()
.map(|tool| Tool::Function {
@ -513,7 +515,21 @@ impl CopilotChatLanguageModel {
parameters: tool.input_schema.clone(),
},
})
.collect();
.collect::<Vec<_>>();
// The API will return a Bad Request (with no error message) when tools
// were used previously in the conversation but no tools are provided as
// part of this request. Inserting a dummy tool seems to circumvent this
// error.
if tool_called && tools.is_empty() {
tools.push(Tool::Function {
function: copilot::copilot_chat::Function {
name: "noop".to_string(),
description: "No operation".to_string(),
parameters: serde_json::json!({}),
},
});
}
Ok(CopilotChatRequest {
intent: true,