Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use an envelope as the feedback icon

Browse source 
This makes room to use the speech bubble for discussion threads.
This commit is contained in:
Nathan Sobo 2023-03-20 09:04:30 -06:00
parent 3464961aa4
commit 10e6c5b651
4 changed files with 19 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/collab_ui/src/collab_titlebar_item.rs
View file

@ -305,7 +305,7 @@ impl CollabTitlebarItem {
action: Box::new(SignOut),
},
ContextMenuItem::Item {
label: "Give Feedback".into(),
label: "Send Feedback".into(),
action: Box::new(feedback::feedback_editor::GiveFeedback),
},
]
@ -316,7 +316,7 @@ impl CollabTitlebarItem {
action: Box::new(SignIn),
},
ContextMenuItem::Item {
label: "Give Feedback".into(),
label: "Send Feedback".into(),
action: Box::new(feedback::feedback_editor::GiveFeedback),
},
]

4
crates/feedback/src/deploy_feedback_button.rs
View file

@ -36,7 +36,7 @@ impl View for DeployFeedbackButton {
.item
.style_for(state, active);
Svg::new("icons/speech_bubble_12.svg")
Svg::new("icons/feedback_16.svg")
.with_color(style.icon_color)
.constrained()
.with_width(style.icon_size)
@ -56,7 +56,7 @@ impl View for DeployFeedbackButton {
})
.with_tooltip::<Self, _>(
0,
"Give Feedback".into(),
"Send Feedback".into(),
Some(Box::new(GiveFeedback)),
theme.tooltip.clone(),
cx,

14
crates/feedback/src/feedback_editor.rs
View file

@ -10,7 +10,7 @@ use editor::{Anchor, Editor};
use futures::AsyncReadExt;
use gpui::{
actions,
elements::{ChildView, Flex, Label, ParentElement},
elements::{ChildView, Flex, Label, ParentElement, Svg},
serde_json, AnyViewHandle, AppContext, Element, ElementBox, Entity, ModelHandle,
MutableAppContext, PromptLevel, RenderContext, Task, View, ViewContext, ViewHandle,
};
@ -250,7 +250,17 @@ impl Item for FeedbackEditor {
fn tab_content(&self, _: Option<usize>, style: &theme::Tab, _: &AppContext) -> ElementBox {
Flex::row()
.with_child(
Label::new("Feedback", style.label.clone())
Svg::new("icons/feedback_16.svg")
.with_color(style.label.text.color)
.constrained()
.with_width(style.type_icon_width)
.aligned()
.contained()
.with_margin_right(style.spacing)
.boxed(),
)
.with_child(
Label::new("Send Feedback", style.label.clone())
.aligned()
.contained()
.boxed(),