Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use const over static for string literals (#18635)

Browse source 
I noticed a few places where we were storing `&'static str`s in
`static`s instead of `const`s.

This PR updates them to use `const`.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-10-02 12:33:13 -04:00 • committed by GitHub
parent 2cd12f84de
commit 167af4bc1d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/task/src/vscode_format.rs
View file

@ -200,7 +200,7 @@ mod tests {
#[test]
fn can_deserialize_ts_tasks() {
static TYPESCRIPT_TASKS: &str = include_str!("../test_data/typescript.json");
const TYPESCRIPT_TASKS: &str = include_str!("../test_data/typescript.json");
let vscode_definitions: VsCodeTaskFile =
serde_json_lenient::from_str(TYPESCRIPT_TASKS).unwrap();
@ -290,7 +290,7 @@ mod tests {
#[test]
fn can_deserialize_rust_analyzer_tasks() {
static RUST_ANALYZER_TASKS: &str = include_str!("../test_data/rust-analyzer.json");
const RUST_ANALYZER_TASKS: &str = include_str!("../test_data/rust-analyzer.json");
let vscode_definitions: VsCodeTaskFile =
serde_json_lenient::from_str(RUST_ANALYZER_TASKS).unwrap();
let expected = vec![