Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Toggle & Switch (#21979)

Browse source 
![CleanShot 2024-12-13 at 11 27
39@2x](https://github.com/user-attachments/assets/7c7828c0-c5c7-4dc6-931e-722366d4f15a)

- Adds the Switch component
- Updates `Selected`, `Selectable` -> `ToggleState`, `Toggleable`
- Adds `checkbox` and `switch` functions to align better with other
elements in our layout system.

We decided not to merge Switch and Checkbox. However, in a followup I'll
introduce a Toggle or AnyToggle enum so we can update
`CheckboxWithLabel` -> `ToggleWithLabel` as this component will work
exactly the same with either a Checkbox or a Switch.

Release Notes:

- N/A
This commit is contained in:
Nate Butler 2024-12-13 14:23:02 -05:00 • committed by GitHub
parent 2f2e7f0317
commit 19d6e067af
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
77 changed files with 626 additions and 453 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/language_tools/src/lsp_log.rs
View file

@ -14,7 +14,7 @@ use lsp::{
};
use project::{search::SearchQuery, Project, WorktreeId};
use std::{borrow::Cow, sync::Arc};
use ui::{prelude::*, Button, Checkbox, ContextMenu, Label, PopoverMenu, Selection};
use ui::{prelude::*, Button, Checkbox, ContextMenu, Label, PopoverMenu, ToggleState};
use workspace::{
item::{Item, ItemHandle},
searchable::{SearchEvent, SearchableItem, SearchableItemHandle},
@ -1251,9 +1251,9 @@ impl Render for LspLogToolbarItemView {
Checkbox::new(
"LspLogEnableRpcTrace",
if rpc_trace_enabled {
Selection::Selected
ToggleState::Selected
} else {
Selection::Unselected
ToggleState::Unselected
},
)
.on_click(cx.listener_for(
@ -1261,7 +1261,7 @@ impl Render for LspLogToolbarItemView {
move |view, selection, cx| {
let enabled = matches!(
selection,
Selection::Selected
ToggleState::Selected
);
view.toggle_rpc_logging_for_server(
server_id, enabled, cx,