Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

stories: Get OverflowScrollStory to scroll again (#15982)

Browse source 
This makes it at least scroll again, but it doesn't scroll down to the
last element yet. We haven't figured out why yet.


Release Notes:

- N/A

Co-authored-by: Bennet <bennet@zed.dev>
Co-authored-by: Antonio <antonio@zed.dev>
This commit is contained in:
Thorsten Ball 2024-08-09 12:32:26 +02:00 • committed by GitHub
parent 173f6e7c8f
commit 19d8422933
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

20
crates/story/src/story.rs
View file

@ -117,17 +117,15 @@ impl RenderOnce for StoryContainer {
pub struct Story {} pub struct Story {}
impl Story { impl Story {
pub fn container() -> Div { pub fn container() -> gpui::Stateful<Div> {
div().size_full().overflow_hidden().child( div()
div() .id("story_container")
.id("story_container") .overflow_y_scroll()
.overflow_y_scroll() .w_full()
.w_full() .min_h_full()
.min_h_full() .flex()
.flex() .flex_col()
.flex_col() .bg(story_color().background)
.bg(story_color().background),
)
} }
// TODO: Move all stories to container2, then rename // TODO: Move all stories to container2, then rename

2
crates/storybook/src/stories/overflow_scroll.rs
View file

@ -25,6 +25,8 @@ impl Render for OverflowScrollStory {
.child(Story::label("`overflow_y_scroll`")) .child(Story::label("`overflow_y_scroll`"))
.child( .child(
v_flex() v_flex()
.w_full()
.flex_1()
.id("overflow_y_scroll") .id("overflow_y_scroll")
.gap_2() .gap_2()
.overflow_y_scroll() .overflow_y_scroll()