diff --git a/script/danger/dangerfile.ts b/script/danger/dangerfile.ts index 4ffe1459df..a238166203 100644 --- a/script/danger/dangerfile.ts +++ b/script/danger/dangerfile.ts @@ -8,7 +8,7 @@ prHygiene({ }, }); -const RELEASE_NOTES_PATTERN = new RegExp("Release Notes:\\r?\\n\\s+-", "gm"); +const RELEASE_NOTES_PATTERN = /Release Notes:\r?\n\s+-/gm; const body = danger.github.pr.body; const hasReleaseNotes = RELEASE_NOTES_PATTERN.test(body); @@ -36,28 +36,22 @@ if (!hasReleaseNotes) { ); } -const ISSUE_LINK_PATTERN = new RegExp( - "(? - match - .replace(/^#/, "") - .replace(/https:\/\/github\.com\/zed-industries\/zed\/issues\//, ""), - ) + .map((match) => match.replace(/^#/, "").replace(/https:\/\/github\.com\/zed-industries\/zed\/issues\//, "")) .filter((issue, index, self) => self.indexOf(issue) === index); + const issuesToReport = issues.map((issue) => `#${issue}`).join(", "); message( [ - "This PR includes links to the following GitHub Issues: " + - issues.map((issue) => `#${issue}`).join(", "), + `This PR includes links to the following GitHub Issues: ${issuesToReport}`, "If this PR aims to close an issue, please include a `Closes #ISSUE` line at the top of the PR body.", ].join("\n"), );