From 1b12437f7eb71e61d201dcafbb74faa85aea9cc1 Mon Sep 17 00:00:00 2001 From: Max Brunsfeld Date: Tue, 23 Jan 2024 15:02:26 -0800 Subject: [PATCH] Render file finder separator in a way that doesn't affect layout Previously, while typing, the separator appearing and disappeaering would cause the layout of the items below to jump up and down. --- crates/picker/src/picker.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/crates/picker/src/picker.rs b/crates/picker/src/picker.rs index 78d1c09e03..3b8788246f 100644 --- a/crates/picker/src/picker.rs +++ b/crates/picker/src/picker.rs @@ -5,7 +5,7 @@ use gpui::{ View, ViewContext, WindowContext, }; use std::sync::Arc; -use ui::{prelude::*, v_flex, Color, Divider, Label, ListItem, ListItemSpacing, ListSeparator}; +use ui::{prelude::*, v_flex, Color, Divider, Label, ListItem, ListItemSpacing}; use workspace::ModalView; pub struct Picker { @@ -296,7 +296,12 @@ impl Render for Picker { ix, ix == selected_index, cx, - )).when(separators_after_indices.contains(&ix), |picker| picker.child(ListSeparator)) + )).when(separators_after_indices.contains(&ix), |picker| { + picker + .border_color(cx.theme().colors().border_variant) + .border_b_1() + .pb(px(-1.0)) + }) }) .collect() }