Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Improve operation name consistency for welcome page

Browse source
This commit is contained in:
Joseph T. Lyons 2024-01-06 23:30:53 -05:00
parent f4c78d3f40
commit 1bcee19ed5
1 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

15
crates/welcome/src/welcome.rs
View file

@ -86,7 +86,7 @@ impl Render for WelcomePage {
.full_width() .full_width()
.on_click(cx.listener(|this, _, cx| { .on_click(cx.listener(|this, _, cx| {
this.telemetry this.telemetry
.report_app_event("welcome page button: theme"); .report_app_event("welcome page: change theme");
this.workspace this.workspace
.update(cx, |workspace, cx| { .update(cx, |workspace, cx| {
theme_selector::toggle( theme_selector::toggle(
@ -103,7 +103,7 @@ impl Render for WelcomePage {
.full_width() .full_width()
.on_click(cx.listener(|this, _, cx| { .on_click(cx.listener(|this, _, cx| {
this.telemetry this.telemetry
.report_app_event("welcome page button: keymap"); .report_app_event("welcome page: change keymap");
this.workspace this.workspace
.update(cx, |workspace, cx| { .update(cx, |workspace, cx| {
base_keymap_picker::toggle( base_keymap_picker::toggle(
@ -119,8 +119,7 @@ impl Render for WelcomePage {
Button::new("install-cli", "Install the CLI") Button::new("install-cli", "Install the CLI")
.full_width() .full_width()
.on_click(cx.listener(|this, _, cx| { .on_click(cx.listener(|this, _, cx| {
this.telemetry this.telemetry.report_app_event("welcome page: install cli");
.report_app_event("welcome page button: install cli");
cx.app_mut() cx.app_mut()
.spawn( .spawn(
|cx| async move { install_cli::install_cli(&cx).await }, |cx| async move { install_cli::install_cli(&cx).await },
@ -152,7 +151,7 @@ impl Render for WelcomePage {
.on_click(cx.listener( .on_click(cx.listener(
move |this, selection, cx| { move |this, selection, cx| {
this.telemetry this.telemetry
.report_app_event("welcome page button: vim"); .report_app_event("welcome page: toggle vim");
this.update_settings::<VimModeSetting>( this.update_settings::<VimModeSetting>(
selection, selection,
cx, cx,
@ -178,7 +177,7 @@ impl Render for WelcomePage {
.on_click(cx.listener( .on_click(cx.listener(
move |this, selection, cx| { move |this, selection, cx| {
this.telemetry.report_app_event( this.telemetry.report_app_event(
"welcome page button: user telemetry", "welcome page: toggle metric telemetry",
); );
this.update_settings::<TelemetrySettings>( this.update_settings::<TelemetrySettings>(
selection, selection,
@ -216,7 +215,7 @@ impl Render for WelcomePage {
.on_click(cx.listener( .on_click(cx.listener(
move |this, selection, cx| { move |this, selection, cx| {
this.telemetry.report_app_event( this.telemetry.report_app_event(
"welcome page button: crash diagnostics", "welcome page: toggle diagnostic telemetry",
); );
this.update_settings::<TelemetrySettings>( this.update_settings::<TelemetrySettings>(
selection, selection,
@ -248,7 +247,7 @@ impl WelcomePage {
pub fn new(workspace: &Workspace, cx: &mut ViewContext<Workspace>) -> View<Self> { pub fn new(workspace: &Workspace, cx: &mut ViewContext<Workspace>) -> View<Self> {
let this = cx.new_view(|cx| { let this = cx.new_view(|cx| {
cx.on_release(|this: &mut Self, _, _| { cx.on_release(|this: &mut Self, _, _| {
this.telemetry.report_app_event("close welcome page"); this.telemetry.report_app_event("welcome page: close");
}) })
.detach(); .detach();