From 1dba50f42fbd6fe1e051150e168e36e0c7716443 Mon Sep 17 00:00:00 2001 From: Thorsten Ball Date: Thu, 24 Oct 2024 11:37:32 +0200 Subject: [PATCH] ssh remoting: Fix version check (#19668) This snuck in when Bennet and I were debugging why our connection to the SSH host would break. We suspected that somewhere something was logging to STDOUT and, I guess, we changed all `println!` to `eprintln!`. Now, two weeks later, I'm sitting here, wondering why the version check doesn't work anymore. The server always reports a version of `""`. Turns out we take the command's STDOUT and not STDERR, which is correct. But it also turns out we started to print the version to STDERR, which breaks the version check. One-character bug & one-character fix. Release Notes: - N/A --- crates/remote_server/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/remote_server/src/main.rs b/crates/remote_server/src/main.rs index 10b656cbdb..72ac438e60 100644 --- a/crates/remote_server/src/main.rs +++ b/crates/remote_server/src/main.rs @@ -72,7 +72,7 @@ fn main() { } }, Some(Commands::Version) => { - eprintln!("{}", env!("ZED_PKG_VERSION")); + println!("{}", env!("ZED_PKG_VERSION")); std::process::exit(0); } None => {