Fix detach (#32506)

Release Notes:

- debugger: Fix detach to not terminate debuggee (and only be available
when detaching makes sense)
This commit is contained in:
Conrad Irwin 2025-06-10 20:20:28 -06:00 committed by GitHub
parent 84eca53319
commit 1e1bc7c373
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 53 additions and 22 deletions

View file

@ -113,6 +113,7 @@ pub fn init(cx: &mut App) {
let caps = running_state.capabilities(cx);
let supports_restart = caps.supports_restart_request.unwrap_or_default();
let supports_step_back = caps.supports_step_back.unwrap_or_default();
let supports_detach = running_state.session().read(cx).is_attached();
let status = running_state.thread_status(cx);
let active_item = active_item.downgrade();
@ -195,6 +196,14 @@ pub fn init(cx: &mut App) {
},
))
})
.when(supports_detach, |div| {
let active_item = active_item.clone();
div.on_action(move |_: &Detach, _, cx| {
active_item
.update(cx, |item, cx| item.detach_client(cx))
.ok();
})
})
.when(supports_restart, |div| {
let active_item = active_item.clone();
div.on_action(move |_: &Restart, _, cx| {