Query certain editor ranges for inlays with a delay (#2891)

Browse source

Part of
https://linear.app/zed-industries/issue/Z-2750/investigate-performance-of-collaborating-on-large-files-with-inlay
Fixes
https://linear.app/zed-industries/issue/Z-2824/inlay-hints-affect-code-layout-in-multibuffer

We query hints for visible part of the screen, and two parts above and
below the visible range, of the same range (if applicable, we can be on
the edge of the document).

When rapidly typing, we do not care about the invisible range updates,
yet still query a lot of them + rust-analyzer sends /refresh hint
requests shortly after every modification too, forcing us to re-query.

Instead querying both visible and invisible ranges altogether, wait for
visible range query first and wait add a `400ms` delay afterwards before
querying the invisible ranges.
This allows any /refresh requests or rapid typing to avoid 2 extra
requests, cancelling them before they start.
Visible part of the screen is still queried after every change, without
any debouncing.

Release Notes:

- Delay certain inlay hint requests to reduce general LSP server load

...

This commit is contained in:

Kirill Bulatov 2023-08-25 16:33:21 +03:00 • committed by GitHub

parent b50762c821 2b95f0580e

commit 205e101dd0

No known key found for this signature in database

GPG key ID: 4AEE18F83AFDEB23

1 changed files with 360 additions and 215 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

575

crates/editor/src/inlay_hint_cache.rs

View file

File diff suppressed because it is too large Load diff