Stop sending redundant LSP proto requests (#35581)

Browse source

Before, each time any LSP feature was used on client remote, it always
produced a `proto::` request that always had been sent to the host, from
where returned as an empty response.

Instead, propagate more language server-related data to the client,
`lsp::ServerCapability`, so Zed client can omit certain requests if
those are not supported.

On top of that, rework the approach Zed uses to query for the data
refreshes: before, editors tried to fetch the data when the server start
was reported (locally and remotely).
Now, a later event is selected: on each `textDocument/didOpen` for the
buffer contained in this editor, we will query for new LSP data, reusing
the cache if needed.

Before, servers could reject unregistered files' LSP queries, or process
them slowly when starting up.
Now, such refreshes are happening later and should be cached.

This requires a collab DB change, to restore server data on rejoin.

Release Notes:

- Fixed excessive LSP requests sent during remote sessions

...

This commit is contained in:

Kirill Bulatov 2025-08-05 16:36:05 +03:00 • committed by GitHub

parent 5b40b3618f

commit 22473fc611

No known key found for this signature in database

GPG key ID: B5690EEEBB952194

19 changed files with 793 additions and 351 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

507

crates/project/src/lsp_store.rs

View file

File diff suppressed because it is too large Load diff