From 22fe03913ca11259b12eb250119dfb091bd70800 Mon Sep 17 00:00:00 2001 From: Marshall Bowers Date: Tue, 5 Mar 2024 12:01:17 -0500 Subject: [PATCH] Move Clippy configuration to the workspace level (#8891) This PR moves the Clippy configuration up to the workspace level. We're using the [`lints` table](https://doc.rust-lang.org/cargo/reference/workspaces.html#the-lints-table) to configure the Clippy ruleset in the workspace's `Cargo.toml`. Each crate in the workspace now has the following in their own `Cargo.toml` to inherit the lints from the workspace: ```toml [lints] workspace = true ``` This allows for configuring rust-analyzer to show Clippy lints in the editor by using the following configuration in your Zed `settings.json`: ```json { "lsp": { "rust-analyzer": { "initialization_options": { "check": { "command": "clippy" } } } } ``` Release Notes: - N/A --- Cargo.lock | 2 +- Cargo.toml | 43 +++++++++++++++- crates/activity_indicator/Cargo.toml | 3 ++ crates/ai/Cargo.toml | 3 ++ crates/assets/Cargo.toml | 3 ++ crates/assistant/Cargo.toml | 3 ++ crates/audio/Cargo.toml | 3 ++ crates/auto_update/Cargo.toml | 3 ++ crates/breadcrumbs/Cargo.toml | 3 ++ crates/call/Cargo.toml | 3 ++ crates/channel/Cargo.toml | 3 ++ crates/cli/Cargo.toml | 3 ++ crates/client/Cargo.toml | 3 ++ crates/clock/Cargo.toml | 3 ++ crates/collab/Cargo.toml | 3 ++ crates/collab_ui/Cargo.toml | 3 ++ crates/collections/Cargo.toml | 3 ++ crates/color/Cargo.toml | 3 ++ crates/command_palette/Cargo.toml | 3 ++ crates/command_palette_hooks/Cargo.toml | 3 ++ crates/copilot/Cargo.toml | 3 ++ crates/copilot_ui/Cargo.toml | 3 ++ crates/db/Cargo.toml | 3 ++ crates/diagnostics/Cargo.toml | 3 ++ crates/editor/Cargo.toml | 3 ++ crates/extension/Cargo.toml | 3 ++ crates/extension_api/Cargo.toml | 3 ++ crates/extensions_ui/Cargo.toml | 3 ++ crates/feature_flags/Cargo.toml | 3 ++ crates/feedback/Cargo.toml | 3 ++ crates/file_finder/Cargo.toml | 3 ++ crates/fs/Cargo.toml | 3 ++ crates/fsevent/Cargo.toml | 6 ++- crates/fuzzy/Cargo.toml | 3 ++ crates/git/Cargo.toml | 3 ++ crates/go_to_line/Cargo.toml | 3 ++ crates/gpui/Cargo.toml | 3 ++ crates/gpui_macros/Cargo.toml | 3 ++ crates/install_cli/Cargo.toml | 3 ++ crates/journal/Cargo.toml | 3 ++ crates/language/Cargo.toml | 3 ++ crates/language_selector/Cargo.toml | 3 ++ crates/language_tools/Cargo.toml | 3 ++ crates/languages/Cargo.toml | 3 ++ crates/live_kit_client/Cargo.toml | 3 ++ crates/live_kit_server/Cargo.toml | 3 ++ crates/lsp/Cargo.toml | 3 ++ crates/markdown_preview/Cargo.toml | 3 ++ crates/media/Cargo.toml | 3 ++ crates/menu/Cargo.toml | 3 ++ crates/multi_buffer/Cargo.toml | 3 ++ crates/node_runtime/Cargo.toml | 3 ++ crates/notifications/Cargo.toml | 3 ++ crates/outline/Cargo.toml | 3 ++ crates/picker/Cargo.toml | 3 ++ crates/prettier/Cargo.toml | 3 ++ crates/project/Cargo.toml | 3 ++ crates/project_core/Cargo.toml | 3 ++ crates/project_panel/Cargo.toml | 3 ++ crates/project_symbols/Cargo.toml | 3 ++ crates/quick_action_bar/Cargo.toml | 3 ++ crates/recent_projects/Cargo.toml | 3 ++ crates/refineable/Cargo.toml | 3 ++ .../refineable/derive_refineable/Cargo.toml | 3 ++ crates/release_channel/Cargo.toml | 3 ++ crates/rich_text/Cargo.toml | 3 ++ crates/rope/Cargo.toml | 3 ++ crates/rpc/Cargo.toml | 3 ++ crates/search/Cargo.toml | 3 ++ crates/semantic_index/Cargo.toml | 3 ++ crates/settings/Cargo.toml | 3 ++ crates/snippet/Cargo.toml | 3 ++ crates/sqlez/Cargo.toml | 3 ++ crates/sqlez_macros/Cargo.toml | 3 ++ crates/story/Cargo.toml | 3 ++ crates/storybook/Cargo.toml | 3 ++ crates/sum_tree/Cargo.toml | 3 ++ crates/task/Cargo.toml | 3 ++ crates/tasks_ui/Cargo.toml | 3 ++ crates/telemetry_events/Cargo.toml | 3 ++ crates/terminal/Cargo.toml | 3 ++ crates/terminal_view/Cargo.toml | 3 ++ crates/text/Cargo.toml | 3 ++ crates/theme/Cargo.toml | 3 ++ crates/theme_importer/Cargo.toml | 3 ++ crates/theme_selector/Cargo.toml | 3 ++ crates/time_format/Cargo.toml | 3 ++ crates/ui/Cargo.toml | 3 ++ crates/util/Cargo.toml | 3 ++ crates/vcs_menu/Cargo.toml | 3 ++ crates/vim/Cargo.toml | 3 ++ crates/welcome/Cargo.toml | 3 ++ crates/workspace/Cargo.toml | 3 ++ crates/zed/Cargo.toml | 3 ++ crates/zed_actions/Cargo.toml | 3 ++ extensions/gleam/Cargo.toml | 3 ++ tooling/xtask/Cargo.toml | 3 ++ tooling/xtask/src/main.rs | 51 ------------------- 98 files changed, 328 insertions(+), 56 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 3bbc622c37..9e19a6c5a0 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3927,7 +3927,7 @@ dependencies = [ [[package]] name = "fsevent" -version = "2.0.2" +version = "0.1.0" dependencies = [ "bitflags 2.4.2", "fsevent-sys 3.1.0", diff --git a/Cargo.toml b/Cargo.toml index 40364b9528..ae3df6cf95 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -322,8 +322,6 @@ features = [ "Win32_System_Ole", ] - - [patch.crates-io] tree-sitter = { git = "https://github.com/tree-sitter/tree-sitter", rev = "e4a23971ec3071a09c1e84816954c98f96e98e52" } # Workaround for a broken nightly build of gpui: See #7644 and revisit once 0.5.3 is released. @@ -350,5 +348,46 @@ debug = "limited" lto = "thin" codegen-units = 1 +[workspace.lints.clippy] +dbg_macro = "deny" +todo = "deny" + +# These are all of the rules that currently have violations in the Zed +# codebase. +# +# We'll want to drive this list down by either: +# 1. fixing violations of the rule and begin enforcing it +# 2. deciding we want to allow the rule permanently, at which point +# we should codify that separately above. +# +# This list shouldn't be added to; it should only get shorter. +# ============================================================================= + +# There are a bunch of rules currently failing in the `style` group, so +# allow all of those, for now. +style = "allow" + +# Individual rules that have violations in the codebase: +almost_complete_range = "allow" +arc_with_non_send_sync = "allow" +await_holding_lock = "allow" +borrow_deref_ref = "allow" +borrowed_box = "allow" +cast_abs_to_unsigned = "allow" +cmp_owned = "allow" +derive_ord_xor_partial_ord = "allow" +eq_op = "allow" +implied_bounds_in_impls = "allow" +let_underscore_future = "allow" +map_entry = "allow" +never_loop = "allow" +non_canonical_clone_impl = "allow" +non_canonical_partial_ord_impl = "allow" +reversed_empty_ranges = "allow" +single_range_in_vec_init = "allow" +suspicious_to_owned = "allow" +type_complexity = "allow" +unnecessary_to_owned = "allow" + [workspace.metadata.cargo-machete] ignored = ["bindgen", "cbindgen", "prost_build", "serde"] diff --git a/crates/activity_indicator/Cargo.toml b/crates/activity_indicator/Cargo.toml index 1513377e7d..ff0ae5c6a1 100644 --- a/crates/activity_indicator/Cargo.toml +++ b/crates/activity_indicator/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/activity_indicator.rs" doctest = false diff --git a/crates/ai/Cargo.toml b/crates/ai/Cargo.toml index 726c7329dc..69c3b88e62 100644 --- a/crates/ai/Cargo.toml +++ b/crates/ai/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/ai.rs" doctest = false diff --git a/crates/assets/Cargo.toml b/crates/assets/Cargo.toml index 19eef955dc..8fcb1f9cfe 100644 --- a/crates/assets/Cargo.toml +++ b/crates/assets/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true gpui.workspace = true diff --git a/crates/assistant/Cargo.toml b/crates/assistant/Cargo.toml index 3f24babef6..d84075a632 100644 --- a/crates/assistant/Cargo.toml +++ b/crates/assistant/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/assistant.rs" doctest = false diff --git a/crates/audio/Cargo.toml b/crates/audio/Cargo.toml index d66df11f9f..bfe22de1f0 100644 --- a/crates/audio/Cargo.toml +++ b/crates/audio/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/audio.rs" doctest = false diff --git a/crates/auto_update/Cargo.toml b/crates/auto_update/Cargo.toml index 8135d5b795..6d4de08d04 100644 --- a/crates/auto_update/Cargo.toml +++ b/crates/auto_update/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/auto_update.rs" doctest = false diff --git a/crates/breadcrumbs/Cargo.toml b/crates/breadcrumbs/Cargo.toml index 24f3a70fd3..45d0f09f66 100644 --- a/crates/breadcrumbs/Cargo.toml +++ b/crates/breadcrumbs/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/breadcrumbs.rs" doctest = false diff --git a/crates/call/Cargo.toml b/crates/call/Cargo.toml index a0acf544b5..569026d006 100644 --- a/crates/call/Cargo.toml +++ b/crates/call/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/call.rs" doctest = false diff --git a/crates/channel/Cargo.toml b/crates/channel/Cargo.toml index ccd690059f..49132a4b7b 100644 --- a/crates/channel/Cargo.toml +++ b/crates/channel/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/channel.rs" doctest = false diff --git a/crates/cli/Cargo.toml b/crates/cli/Cargo.toml index 60285628e8..6316c64bdc 100644 --- a/crates/cli/Cargo.toml +++ b/crates/cli/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/cli.rs" doctest = false diff --git a/crates/client/Cargo.toml b/crates/client/Cargo.toml index 4dc8c38ef4..2b45efec85 100644 --- a/crates/client/Cargo.toml +++ b/crates/client/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/client.rs" doctest = false diff --git a/crates/clock/Cargo.toml b/crates/clock/Cargo.toml index adef338cc7..d1fb21747b 100644 --- a/crates/clock/Cargo.toml +++ b/crates/clock/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/clock.rs" doctest = false diff --git a/crates/collab/Cargo.toml b/crates/collab/Cargo.toml index 7cd499513a..35e1a47baf 100644 --- a/crates/collab/Cargo.toml +++ b/crates/collab/Cargo.toml @@ -7,6 +7,9 @@ version = "0.44.0" publish = false license = "AGPL-3.0-or-later" +[lints] +workspace = true + [[bin]] name = "collab" diff --git a/crates/collab_ui/Cargo.toml b/crates/collab_ui/Cargo.toml index e88d191af5..ab8b85321e 100644 --- a/crates/collab_ui/Cargo.toml +++ b/crates/collab_ui/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/collab_ui.rs" doctest = false diff --git a/crates/collections/Cargo.toml b/crates/collections/Cargo.toml index 85cee90e12..b16b4c1300 100644 --- a/crates/collections/Cargo.toml +++ b/crates/collections/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/collections.rs" doctest = false diff --git a/crates/color/Cargo.toml b/crates/color/Cargo.toml index d3e4a125f4..a68a5fb518 100644 --- a/crates/color/Cargo.toml +++ b/crates/color/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [features] default = [] diff --git a/crates/command_palette/Cargo.toml b/crates/command_palette/Cargo.toml index 565939e4a3..eecd80b6e1 100644 --- a/crates/command_palette/Cargo.toml +++ b/crates/command_palette/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/command_palette.rs" doctest = false diff --git a/crates/command_palette_hooks/Cargo.toml b/crates/command_palette_hooks/Cargo.toml index 8dd8b7bf69..cc4f396bf8 100644 --- a/crates/command_palette_hooks/Cargo.toml +++ b/crates/command_palette_hooks/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/command_palette_hooks.rs" doctest = false diff --git a/crates/copilot/Cargo.toml b/crates/copilot/Cargo.toml index eca15d3c56..609bd0e3a8 100644 --- a/crates/copilot/Cargo.toml +++ b/crates/copilot/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/copilot.rs" doctest = false diff --git a/crates/copilot_ui/Cargo.toml b/crates/copilot_ui/Cargo.toml index cc83e09aa6..cc184b2dfc 100644 --- a/crates/copilot_ui/Cargo.toml +++ b/crates/copilot_ui/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/copilot_ui.rs" doctest = false diff --git a/crates/db/Cargo.toml b/crates/db/Cargo.toml index 0b01e691b1..f31609277d 100644 --- a/crates/db/Cargo.toml +++ b/crates/db/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/db.rs" doctest = false diff --git a/crates/diagnostics/Cargo.toml b/crates/diagnostics/Cargo.toml index e4e408b665..fcaacfd62a 100644 --- a/crates/diagnostics/Cargo.toml +++ b/crates/diagnostics/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/diagnostics.rs" doctest = false diff --git a/crates/editor/Cargo.toml b/crates/editor/Cargo.toml index 8266e12ba7..78aeae8ca9 100644 --- a/crates/editor/Cargo.toml +++ b/crates/editor/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/editor.rs" doctest = false diff --git a/crates/extension/Cargo.toml b/crates/extension/Cargo.toml index 7c0e2d7afa..d5ceeeff4b 100644 --- a/crates/extension/Cargo.toml +++ b/crates/extension/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/extension_store.rs" diff --git a/crates/extension_api/Cargo.toml b/crates/extension_api/Cargo.toml index 1adbd0c0ee..84d2064eb5 100644 --- a/crates/extension_api/Cargo.toml +++ b/crates/extension_api/Cargo.toml @@ -4,6 +4,9 @@ version = "0.1.0" edition = "2021" license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/extension_api.rs" diff --git a/crates/extensions_ui/Cargo.toml b/crates/extensions_ui/Cargo.toml index df55a5091a..7c2320717f 100644 --- a/crates/extensions_ui/Cargo.toml +++ b/crates/extensions_ui/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/extensions_ui.rs" diff --git a/crates/feature_flags/Cargo.toml b/crates/feature_flags/Cargo.toml index cf0f9475af..101e90c646 100644 --- a/crates/feature_flags/Cargo.toml +++ b/crates/feature_flags/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/feature_flags.rs" diff --git a/crates/feedback/Cargo.toml b/crates/feedback/Cargo.toml index b3c89e2c54..05465ba95b 100644 --- a/crates/feedback/Cargo.toml +++ b/crates/feedback/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/feedback.rs" diff --git a/crates/file_finder/Cargo.toml b/crates/file_finder/Cargo.toml index 377bc2dc2a..283b7c5495 100644 --- a/crates/file_finder/Cargo.toml +++ b/crates/file_finder/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/file_finder.rs" doctest = false diff --git a/crates/fs/Cargo.toml b/crates/fs/Cargo.toml index 4b48dbc2bf..4a26a13e5f 100644 --- a/crates/fs/Cargo.toml +++ b/crates/fs/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/fs.rs" diff --git a/crates/fsevent/Cargo.toml b/crates/fsevent/Cargo.toml index 23490e8fa5..6a5a01843d 100644 --- a/crates/fsevent/Cargo.toml +++ b/crates/fsevent/Cargo.toml @@ -1,10 +1,12 @@ [package] name = "fsevent" -version = "2.0.2" -license = "MIT" +version = "0.1.0" edition = "2021" publish = false +license = "GPL-3.0-or-later" +[lints] +workspace = true [lib] path = "src/fsevent.rs" diff --git a/crates/fuzzy/Cargo.toml b/crates/fuzzy/Cargo.toml index 3b323afdaa..e3a016c98b 100644 --- a/crates/fuzzy/Cargo.toml +++ b/crates/fuzzy/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/fuzzy.rs" doctest = false diff --git a/crates/git/Cargo.toml b/crates/git/Cargo.toml index 720a0cdd32..4a47b74d59 100644 --- a/crates/git/Cargo.toml +++ b/crates/git/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/git.rs" diff --git a/crates/go_to_line/Cargo.toml b/crates/go_to_line/Cargo.toml index a009e27547..921434a407 100644 --- a/crates/go_to_line/Cargo.toml +++ b/crates/go_to_line/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/go_to_line.rs" doctest = false diff --git a/crates/gpui/Cargo.toml b/crates/gpui/Cargo.toml index de83868b35..c4a2432ece 100644 --- a/crates/gpui/Cargo.toml +++ b/crates/gpui/Cargo.toml @@ -7,6 +7,9 @@ description = "Zed's GPU-accelerated UI framework" publish = false license = "Apache-2.0" +[lints] +workspace = true + [features] test-support = [ "backtrace", diff --git a/crates/gpui_macros/Cargo.toml b/crates/gpui_macros/Cargo.toml index f5a7589139..b48da0429e 100644 --- a/crates/gpui_macros/Cargo.toml +++ b/crates/gpui_macros/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/gpui_macros.rs" proc-macro = true diff --git a/crates/install_cli/Cargo.toml b/crates/install_cli/Cargo.toml index 8afccceaaf..4edeb01dcd 100644 --- a/crates/install_cli/Cargo.toml +++ b/crates/install_cli/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/install_cli.rs" diff --git a/crates/journal/Cargo.toml b/crates/journal/Cargo.toml index 325e6b5297..e5dd558fa8 100644 --- a/crates/journal/Cargo.toml +++ b/crates/journal/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/journal.rs" doctest = false diff --git a/crates/language/Cargo.toml b/crates/language/Cargo.toml index 77abad1ecf..e6f2a45ea5 100644 --- a/crates/language/Cargo.toml +++ b/crates/language/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/language.rs" doctest = false diff --git a/crates/language_selector/Cargo.toml b/crates/language_selector/Cargo.toml index 5365be61a9..b864ffc31f 100644 --- a/crates/language_selector/Cargo.toml +++ b/crates/language_selector/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/language_selector.rs" doctest = false diff --git a/crates/language_tools/Cargo.toml b/crates/language_tools/Cargo.toml index 2afad658c8..6d0a1199b3 100644 --- a/crates/language_tools/Cargo.toml +++ b/crates/language_tools/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/language_tools.rs" doctest = false diff --git a/crates/languages/Cargo.toml b/crates/languages/Cargo.toml index 8dd4078abc..122607791e 100644 --- a/crates/languages/Cargo.toml +++ b/crates/languages/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true async-compression.workspace = true diff --git a/crates/live_kit_client/Cargo.toml b/crates/live_kit_client/Cargo.toml index a18199fe5a..708fd61d41 100644 --- a/crates/live_kit_client/Cargo.toml +++ b/crates/live_kit_client/Cargo.toml @@ -6,6 +6,9 @@ description = "Bindings to LiveKit Swift client SDK" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/live_kit_client.rs" doctest = false diff --git a/crates/live_kit_server/Cargo.toml b/crates/live_kit_server/Cargo.toml index 3c742111c4..bdac22a85c 100644 --- a/crates/live_kit_server/Cargo.toml +++ b/crates/live_kit_server/Cargo.toml @@ -6,6 +6,9 @@ description = "SDK for the LiveKit server API" publish = false license = "AGPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/live_kit_server.rs" doctest = false diff --git a/crates/lsp/Cargo.toml b/crates/lsp/Cargo.toml index 902105341b..23b2f204ef 100644 --- a/crates/lsp/Cargo.toml +++ b/crates/lsp/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/lsp.rs" doctest = false diff --git a/crates/markdown_preview/Cargo.toml b/crates/markdown_preview/Cargo.toml index 5ac5ae3cb5..f3192a79ca 100644 --- a/crates/markdown_preview/Cargo.toml +++ b/crates/markdown_preview/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/markdown_preview.rs" diff --git a/crates/media/Cargo.toml b/crates/media/Cargo.toml index 784139f129..ac22eccde6 100644 --- a/crates/media/Cargo.toml +++ b/crates/media/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/media.rs" doctest = false diff --git a/crates/menu/Cargo.toml b/crates/menu/Cargo.toml index cf17727242..ce12455710 100644 --- a/crates/menu/Cargo.toml +++ b/crates/menu/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/menu.rs" doctest = false diff --git a/crates/multi_buffer/Cargo.toml b/crates/multi_buffer/Cargo.toml index 322ff38a5a..f866217da8 100644 --- a/crates/multi_buffer/Cargo.toml +++ b/crates/multi_buffer/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/multi_buffer.rs" doctest = false diff --git a/crates/node_runtime/Cargo.toml b/crates/node_runtime/Cargo.toml index 1c608b703f..7e713a3e2d 100644 --- a/crates/node_runtime/Cargo.toml +++ b/crates/node_runtime/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/node_runtime.rs" doctest = false diff --git a/crates/notifications/Cargo.toml b/crates/notifications/Cargo.toml index 40d61087fa..3e1c856e40 100644 --- a/crates/notifications/Cargo.toml +++ b/crates/notifications/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/notification_store.rs" doctest = false diff --git a/crates/outline/Cargo.toml b/crates/outline/Cargo.toml index 28dc5d6a1b..540e979ab3 100644 --- a/crates/outline/Cargo.toml +++ b/crates/outline/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/outline.rs" doctest = false diff --git a/crates/picker/Cargo.toml b/crates/picker/Cargo.toml index 510ce14a59..79a8ed70d8 100644 --- a/crates/picker/Cargo.toml +++ b/crates/picker/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/picker.rs" doctest = false diff --git a/crates/prettier/Cargo.toml b/crates/prettier/Cargo.toml index 242a65ba7b..586ff0770f 100644 --- a/crates/prettier/Cargo.toml +++ b/crates/prettier/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/prettier.rs" doctest = false diff --git a/crates/project/Cargo.toml b/crates/project/Cargo.toml index c76424144f..875ebb2de4 100644 --- a/crates/project/Cargo.toml +++ b/crates/project/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/project.rs" doctest = false diff --git a/crates/project_core/Cargo.toml b/crates/project_core/Cargo.toml index c72fe909da..b82e9a26eb 100644 --- a/crates/project_core/Cargo.toml +++ b/crates/project_core/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html [features] test-support = [ diff --git a/crates/project_panel/Cargo.toml b/crates/project_panel/Cargo.toml index 093d47e124..2772fc18a2 100644 --- a/crates/project_panel/Cargo.toml +++ b/crates/project_panel/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/project_panel.rs" doctest = false diff --git a/crates/project_symbols/Cargo.toml b/crates/project_symbols/Cargo.toml index 93b122eaf0..cadbdd83aa 100644 --- a/crates/project_symbols/Cargo.toml +++ b/crates/project_symbols/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/project_symbols.rs" doctest = false diff --git a/crates/quick_action_bar/Cargo.toml b/crates/quick_action_bar/Cargo.toml index e1f8c66d10..3d5d56a318 100644 --- a/crates/quick_action_bar/Cargo.toml +++ b/crates/quick_action_bar/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/quick_action_bar.rs" doctest = false diff --git a/crates/recent_projects/Cargo.toml b/crates/recent_projects/Cargo.toml index f96dfbdd7d..3e8f63d133 100644 --- a/crates/recent_projects/Cargo.toml +++ b/crates/recent_projects/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/recent_projects.rs" doctest = false diff --git a/crates/refineable/Cargo.toml b/crates/refineable/Cargo.toml index 97f03f1f2f..bda47e7a8a 100644 --- a/crates/refineable/Cargo.toml +++ b/crates/refineable/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/refineable.rs" doctest = false diff --git a/crates/refineable/derive_refineable/Cargo.toml b/crates/refineable/derive_refineable/Cargo.toml index f0d6d6d2dc..00502ec19a 100644 --- a/crates/refineable/derive_refineable/Cargo.toml +++ b/crates/refineable/derive_refineable/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/derive_refineable.rs" proc-macro = true diff --git a/crates/release_channel/Cargo.toml b/crates/release_channel/Cargo.toml index b40ce36346..acea552d63 100644 --- a/crates/release_channel/Cargo.toml +++ b/crates/release_channel/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] gpui.workspace = true once_cell = "1.19.0" diff --git a/crates/rich_text/Cargo.toml b/crates/rich_text/Cargo.toml index 5a12d0e56f..146fdcbd8a 100644 --- a/crates/rich_text/Cargo.toml +++ b/crates/rich_text/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/rich_text.rs" doctest = false diff --git a/crates/rope/Cargo.toml b/crates/rope/Cargo.toml index 9190341f53..b1ce369416 100644 --- a/crates/rope/Cargo.toml +++ b/crates/rope/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/rope.rs" diff --git a/crates/rpc/Cargo.toml b/crates/rpc/Cargo.toml index 7f6750bce5..a4af21df11 100644 --- a/crates/rpc/Cargo.toml +++ b/crates/rpc/Cargo.toml @@ -6,6 +6,9 @@ version = "0.1.0" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/rpc.rs" doctest = false diff --git a/crates/search/Cargo.toml b/crates/search/Cargo.toml index 8daa5e743e..e54b5e0338 100644 --- a/crates/search/Cargo.toml +++ b/crates/search/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/search.rs" doctest = false diff --git a/crates/semantic_index/Cargo.toml b/crates/semantic_index/Cargo.toml index 5c922a503a..957a5e3cdf 100644 --- a/crates/semantic_index/Cargo.toml +++ b/crates/semantic_index/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/semantic_index.rs" doctest = false diff --git a/crates/settings/Cargo.toml b/crates/settings/Cargo.toml index d9ad9d3f9a..3177716196 100644 --- a/crates/settings/Cargo.toml +++ b/crates/settings/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/settings.rs" doctest = false diff --git a/crates/snippet/Cargo.toml b/crates/snippet/Cargo.toml index c2c62cc01e..f12c7dded3 100644 --- a/crates/snippet/Cargo.toml +++ b/crates/snippet/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/snippet.rs" doctest = false diff --git a/crates/sqlez/Cargo.toml b/crates/sqlez/Cargo.toml index 71c67af095..98b05a06e4 100644 --- a/crates/sqlez/Cargo.toml +++ b/crates/sqlez/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true collections.workspace = true diff --git a/crates/sqlez_macros/Cargo.toml b/crates/sqlez_macros/Cargo.toml index aab2596ddd..969fe26c88 100644 --- a/crates/sqlez_macros/Cargo.toml +++ b/crates/sqlez_macros/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/sqlez_macros.rs" proc-macro = true diff --git a/crates/story/Cargo.toml b/crates/story/Cargo.toml index fc1754c253..419a447c13 100644 --- a/crates/story/Cargo.toml +++ b/crates/story/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] gpui.workspace = true itertools = { package = "itertools", version = "0.10" } diff --git a/crates/storybook/Cargo.toml b/crates/storybook/Cargo.toml index caf66c4c4f..38cc3ddc98 100644 --- a/crates/storybook/Cargo.toml +++ b/crates/storybook/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [[bin]] name = "storybook" path = "src/storybook.rs" diff --git a/crates/sum_tree/Cargo.toml b/crates/sum_tree/Cargo.toml index ac24e0d298..b370e6df18 100644 --- a/crates/sum_tree/Cargo.toml +++ b/crates/sum_tree/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/sum_tree.rs" doctest = false diff --git a/crates/task/Cargo.toml b/crates/task/Cargo.toml index 47f3170c74..8f4da57a63 100644 --- a/crates/task/Cargo.toml +++ b/crates/task/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true collections.workspace = true diff --git a/crates/tasks_ui/Cargo.toml b/crates/tasks_ui/Cargo.toml index cbf5280ef6..446179890c 100644 --- a/crates/tasks_ui/Cargo.toml +++ b/crates/tasks_ui/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true editor.workspace = true diff --git a/crates/telemetry_events/Cargo.toml b/crates/telemetry_events/Cargo.toml index 6893e7c183..b202a60b25 100644 --- a/crates/telemetry_events/Cargo.toml +++ b/crates/telemetry_events/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/telemetry_events.rs" diff --git a/crates/terminal/Cargo.toml b/crates/terminal/Cargo.toml index 884b754aac..4686266557 100644 --- a/crates/terminal/Cargo.toml +++ b/crates/terminal/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/terminal.rs" doctest = false diff --git a/crates/terminal_view/Cargo.toml b/crates/terminal_view/Cargo.toml index 8daf4b3f02..d9e3606d4d 100644 --- a/crates/terminal_view/Cargo.toml +++ b/crates/terminal_view/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/terminal_view.rs" doctest = false diff --git a/crates/text/Cargo.toml b/crates/text/Cargo.toml index 798b506b5e..4e57a78407 100644 --- a/crates/text/Cargo.toml +++ b/crates/text/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/text.rs" doctest = false diff --git a/crates/theme/Cargo.toml b/crates/theme/Cargo.toml index fff134af84..0ead51ba41 100644 --- a/crates/theme/Cargo.toml +++ b/crates/theme/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [features] default = [] stories = ["dep:story"] diff --git a/crates/theme_importer/Cargo.toml b/crates/theme_importer/Cargo.toml index ddff83f385..07ed1695be 100644 --- a/crates/theme_importer/Cargo.toml +++ b/crates/theme_importer/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true clap = { workspace = true, features = ["derive"] } diff --git a/crates/theme_selector/Cargo.toml b/crates/theme_selector/Cargo.toml index 7e7e6fe9b6..3f9c9e6205 100644 --- a/crates/theme_selector/Cargo.toml +++ b/crates/theme_selector/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/theme_selector.rs" doctest = false diff --git a/crates/time_format/Cargo.toml b/crates/time_format/Cargo.toml index ea1fb336d5..1b5d36eb6c 100644 --- a/crates/time_format/Cargo.toml +++ b/crates/time_format/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/time_format.rs" doctest = false diff --git a/crates/ui/Cargo.toml b/crates/ui/Cargo.toml index 1776f151d3..3acae49d95 100644 --- a/crates/ui/Cargo.toml +++ b/crates/ui/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] name = "ui" path = "src/ui.rs" diff --git a/crates/util/Cargo.toml b/crates/util/Cargo.toml index 9725320507..191d0beb56 100644 --- a/crates/util/Cargo.toml +++ b/crates/util/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [lib] path = "src/util.rs" doctest = true diff --git a/crates/vcs_menu/Cargo.toml b/crates/vcs_menu/Cargo.toml index 3258c229dd..786e2ee6fc 100644 --- a/crates/vcs_menu/Cargo.toml +++ b/crates/vcs_menu/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true fs.workspace = true diff --git a/crates/vim/Cargo.toml b/crates/vim/Cargo.toml index 071421e74e..4a78547d1e 100644 --- a/crates/vim/Cargo.toml +++ b/crates/vim/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/vim.rs" doctest = false diff --git a/crates/welcome/Cargo.toml b/crates/welcome/Cargo.toml index 2200db8bbd..6fd65c795e 100644 --- a/crates/welcome/Cargo.toml +++ b/crates/welcome/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/welcome.rs" diff --git a/crates/workspace/Cargo.toml b/crates/workspace/Cargo.toml index 44c6a98859..db8d004b9e 100644 --- a/crates/workspace/Cargo.toml +++ b/crates/workspace/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] path = "src/workspace.rs" doctest = false diff --git a/crates/zed/Cargo.toml b/crates/zed/Cargo.toml index 2ad94a8bae..fe50da4884 100644 --- a/crates/zed/Cargo.toml +++ b/crates/zed/Cargo.toml @@ -6,6 +6,9 @@ version = "0.126.0" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [lib] name = "zed" path = "src/zed.rs" diff --git a/crates/zed_actions/Cargo.toml b/crates/zed_actions/Cargo.toml index 19c9415514..ee279cde65 100644 --- a/crates/zed_actions/Cargo.toml +++ b/crates/zed_actions/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] gpui.workspace = true serde.workspace = true diff --git a/extensions/gleam/Cargo.toml b/extensions/gleam/Cargo.toml index b4167dd1ca..881978c90b 100644 --- a/extensions/gleam/Cargo.toml +++ b/extensions/gleam/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "Apache-2.0" +[lints] +workspace = true + [dependencies] zed_extension_api = { path = "../../crates/extension_api" } diff --git a/tooling/xtask/Cargo.toml b/tooling/xtask/Cargo.toml index fac3b54e5e..11f0036c74 100644 --- a/tooling/xtask/Cargo.toml +++ b/tooling/xtask/Cargo.toml @@ -5,6 +5,9 @@ edition = "2021" publish = false license = "GPL-3.0-or-later" +[lints] +workspace = true + [dependencies] anyhow.workspace = true clap = { workspace = true, features = ["derive"] } diff --git a/tooling/xtask/src/main.rs b/tooling/xtask/src/main.rs index 44947a4367..e4feb2bdb1 100644 --- a/tooling/xtask/src/main.rs +++ b/tooling/xtask/src/main.rs @@ -63,57 +63,6 @@ fn run_clippy(args: ClippyArgs) -> Result<()> { #[cfg(not(target_os = "windows"))] clippy_command.args(["--deny", "warnings"]); - /// These are all of the rules that currently have violations in the Zed - /// codebase. - /// - /// We'll want to drive this list down by either: - /// 1. fixing violations of the rule and begin enforcing it - /// 2. deciding we want to allow the rule permanently, at which point - /// we should codify that separately in this task. - /// - /// This list shouldn't be added to; it should only get shorter. - const MIGRATORY_RULES_TO_ALLOW: &[&str] = &[ - // There are a bunch of rules currently failing in the `style` group, so - // allow all of those, for now. - "clippy::style", - // Individual rules that have violations in the codebase: - "clippy::almost_complete_range", - "clippy::arc_with_non_send_sync", - "clippy::await_holding_lock", - "clippy::borrow_deref_ref", - "clippy::borrowed_box", - "clippy::cast_abs_to_unsigned", - "clippy::cmp_owned", - "clippy::derive_ord_xor_partial_ord", - "clippy::eq_op", - "clippy::implied_bounds_in_impls", - "clippy::let_underscore_future", - "clippy::map_entry", - "clippy::never_loop", - "clippy::non_canonical_clone_impl", - "clippy::non_canonical_partial_ord_impl", - "clippy::reversed_empty_ranges", - "clippy::single_range_in_vec_init", - "clippy::suspicious_to_owned", - "clippy::type_complexity", - "clippy::unnecessary_to_owned", - ]; - - // When fixing violations automatically for a single package we don't care - // about the rules we're already violating, since it may be possible to - // have them fixed automatically. - let ignore_suppressed_rules = args.fix && args.package.is_some(); - if !ignore_suppressed_rules { - for rule in MIGRATORY_RULES_TO_ALLOW { - clippy_command.args(["--allow", rule]); - } - } - - // Deny `dbg!` and `todo!`s. - clippy_command - .args(["--deny", "clippy::dbg_macro"]) - .args(["--deny", "clippy::todo"]); - eprintln!( "running: {cargo} {}", clippy_command