Add CI check that cmd-
is not in linux keymaps + check other mods (#32334)
Motivation for the `cmd-` check is that there were a couple keybindings using `cmd-` in the linux keymap and so these were bound to super / windows Release Notes: - N/A
This commit is contained in:
parent
866fe427b3
commit
23adff6ff2
3 changed files with 30 additions and 1 deletions
26
script/check-keymaps
Executable file
26
script/check-keymaps
Executable file
|
@ -0,0 +1,26 @@
|
|||
#!/usr/bin/env bash
|
||||
|
||||
set -euo pipefail
|
||||
|
||||
pattern='cmd-'
|
||||
result=$(git grep --no-color --line-number --fixed-strings -e "$pattern" -- \
|
||||
'assets/keymaps/' \
|
||||
':(exclude)assets/keymaps/storybook.json' \
|
||||
':(exclude)assets/keymaps/default-macos.json' \
|
||||
':(exclude)assets/keymaps/macos/*.json' || true)
|
||||
|
||||
if [[ -n "${result}" ]]; then
|
||||
echo "${result}"
|
||||
echo "Error: Found 'cmd-' in non-macOS keymap files."
|
||||
exit 1
|
||||
fi
|
||||
|
||||
pattern='super-|win-|fn-'
|
||||
result=$(git grep --no-color --line-number --fixed-strings -e "$pattern" -- \
|
||||
'assets/keymaps/' || true)
|
||||
|
||||
if [[ -n "${result}" ]]; then
|
||||
echo "${result}"
|
||||
echo "Error: Found 'super-', 'win-', or 'fn-' in keymap files. Currently these aren't used."
|
||||
exit 1
|
||||
fi
|
|
@ -8,7 +8,7 @@ result=$(git grep --no-color --ignore-case --line-number --extended-regexp -e $p
|
|||
':(exclude).github/workflows/ci.yml' \
|
||||
':(exclude)*criteria.md' \
|
||||
':(exclude)*prompt.md' || true)
|
||||
echo "${result}"
|
||||
if [[ -n "${result}" ]]; then
|
||||
echo "${result}"
|
||||
exit 1
|
||||
fi
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue