Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix view handle leaks in ListState callbacks

Browse source
This commit is contained in:
Max Brunsfeld 2023-12-20 16:33:10 -08:00
parent 42bdc11112
commit 24970c1da9
3 changed files with 19 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/collab_ui2/src/chat_panel.rs
View file

@ -92,11 +92,15 @@ impl ChatPanel {
let workspace_handle = workspace.weak_handle();
cx.build_view(|cx| {
let view: View<ChatPanel> = cx.view().clone();
cx.build_view(|cx: &mut ViewContext<Self>| {
let view = cx.view().downgrade();
let message_list =
ListState::new(0, gpui::ListAlignment::Bottom, px(1000.), move |ix, cx| {
view.update(cx, |view, cx| view.render_message(ix, cx))
if let Some(view) = view.upgrade() {
view.update(cx, |view, cx| view.render_message(ix, cx))
} else {
div().into_any()
}
});
message_list.set_scroll_handler(cx.listener(|this, event: &ListScrollEvent, cx| {