Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always sync before clearing or removing excerpts from MultiBuffer

Browse source 
We don't have any test that proves this is needed but seems good nonetheless.
This commit is contained in:
Antonio Scandurra 2022-02-25 15:36:43 +01:00
parent ff0fa0e0bd
commit 2611b5449f
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/editor/src/multi_buffer.rs
View file

@ -772,6 +772,7 @@ impl MultiBuffer {
} }
pub fn clear(&mut self, cx: &mut ModelContext<Self>) { pub fn clear(&mut self, cx: &mut ModelContext<Self>) {
self.sync(cx);
self.buffers.borrow_mut().clear(); self.buffers.borrow_mut().clear();
let mut snapshot = self.snapshot.borrow_mut(); let mut snapshot = self.snapshot.borrow_mut();
let prev_len = snapshot.len(); let prev_len = snapshot.len();
@ -853,6 +854,7 @@ impl MultiBuffer {
excerpt_ids: impl IntoIterator<Item = &'a ExcerptId>, excerpt_ids: impl IntoIterator<Item = &'a ExcerptId>,
cx: &mut ModelContext<Self>, cx: &mut ModelContext<Self>,
) { ) {
self.sync(cx);
let mut buffers = self.buffers.borrow_mut(); let mut buffers = self.buffers.borrow_mut();
let mut snapshot = self.snapshot.borrow_mut(); let mut snapshot = self.snapshot.borrow_mut();
let mut new_excerpts = SumTree::new(); let mut new_excerpts = SumTree::new();