Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "theme: Turn ThemeRegistry into a trait (#20076)" (#20094)

Browse source 
This PR reverts #20076 to turn the `ThemeRegistry` back into a regular
struct again.

It doesn't actually help us by having it behind a trait.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-11-01 15:34:20 -04:00 • committed by GitHub
parent 4084ba36f9
commit 273173ec8a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 89 additions and 151 deletions
Download patch file Download diff file Expand all files Collapse all files

4
crates/theme_selector/src/theme_selector.rs
View file

@ -95,7 +95,7 @@ impl ThemeSelectorDelegate {
) -> Self {
let original_theme = cx.theme().clone();
let registry = <dyn ThemeRegistry>::global(cx);
let registry = ThemeRegistry::global(cx);
let mut themes = registry
.list()
.into_iter()
@ -140,7 +140,7 @@ impl ThemeSelectorDelegate {
fn show_selected_theme(&mut self, cx: &mut ViewContext<Picker<ThemeSelectorDelegate>>) {
if let Some(mat) = self.matches.get(self.selected_index) {
let registry = <dyn ThemeRegistry>::global(cx);
let registry = ThemeRegistry::global(cx);
match registry.get(&mat.string) {
Ok(theme) => {
Self::set_theme(theme, cx);