Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Set transaction group interval to ZERO by default in tests

Browse source 
We were seeing non-deterministic behavior in randomized tests when
generating backtraces took enough time to cause transactions to group
in some cases, but not group in others.

Tests will need to explicitly opt into grouping if they want it by
setting the interval explicitly. We have tests in the text module that
currently test the history grouping explicitly, but I'm not sure
it's needed elsewhere.
This commit is contained in:
Nathan Sobo 2022-12-27 16:47:28 -07:00
parent 599acf0daa
commit 273988b8d5
5 changed files with 11 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/client/src/client.rs
View file

@ -851,7 +851,6 @@ impl Client {
})
.detach();
let t0 = Instant::now();
let this = self.clone();
let cx = cx.clone();
cx.foreground()
@ -868,12 +867,7 @@ impl Client {
}
}
Err(err) => {
// TODO - remove. Make the test's non-determinism more apparent by
// only sometimes formatting this stack trace.
if Instant::now().duration_since(t0).as_nanos() % 2 == 0 {
log::error!("connection error: {:?}", err);
}
log::error!("connection error: {:?}", err);
this.set_status(Status::ConnectionLost, &cx);
}
}