Remove into SelectionEffects
from .change_selections
In #32656 I generalized the argument to change selections to allow controling both the scroll and the nav history (and the completion trigger). To avoid conflicting with ongoing debugger cherry-picks I left the argument as an `impl Into<>`, but I think it's clearer to make callers specify what they want here. I converted a lot of `None` arguments to `SelectionEffects::no_scroll()` to be exactly compatible; but I think many people used none as an "i don't care" value in which case Default::default() might be more appropraite
This commit is contained in:
parent
f338c46bf7
commit
28380d714d
65 changed files with 837 additions and 625 deletions
|
@ -8,6 +8,7 @@ use crate::{
|
|||
};
|
||||
use anyhow::Context as _;
|
||||
use collections::{HashMap, HashSet};
|
||||
use editor::SelectionEffects;
|
||||
use editor::{
|
||||
Anchor, AnchorRangeExt as _, Editor, MultiBuffer, ToPoint,
|
||||
display_map::{
|
||||
|
@ -477,7 +478,7 @@ impl Session {
|
|||
if move_down {
|
||||
editor.update(cx, move |editor, cx| {
|
||||
editor.change_selections(
|
||||
Some(Autoscroll::top_relative(8)),
|
||||
SelectionEffects::scroll(Autoscroll::top_relative(8)),
|
||||
window,
|
||||
cx,
|
||||
|selections| {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue