Rework loading images from files (#7088)
This PR is a follow-up to #7084, where I noted that I wasn't satisfied with using `SharedUri` to represent both URIs and paths on the local filesystem: > I'm still not entirely happy with this naming, as the file paths that we can store in here are not _really_ URIs, as they are lacking a protocol. > > I want to explore changing `SharedUri` / `SharedUrl` back to alway storing a URL and treat local filepaths differently, as it seems we're conflating two different concerns under the same umbrella, at the moment. `SharedUri` has now been reverted to just containing a `SharedString` with a URI. `ImageSource` now has a new `File` variant that is used to load an image from a `PathBuf`. Release Notes: - N/A
This commit is contained in:
parent
6d4fe8098b
commit
2980f0508c
12 changed files with 163 additions and 166 deletions
|
@ -3,6 +3,7 @@ use collections::HashMap;
|
|||
use futures::{future::Shared, AsyncReadExt, FutureExt, TryFutureExt};
|
||||
use image::ImageError;
|
||||
use parking_lot::Mutex;
|
||||
use std::path::PathBuf;
|
||||
use std::sync::Arc;
|
||||
use thiserror::Error;
|
||||
use util::http::{self, HttpClient};
|
||||
|
@ -41,7 +42,25 @@ impl From<ImageError> for Error {
|
|||
|
||||
pub(crate) struct ImageCache {
|
||||
client: Arc<dyn HttpClient>,
|
||||
images: Arc<Mutex<HashMap<SharedUri, FetchImageTask>>>,
|
||||
images: Arc<Mutex<HashMap<UriOrPath, FetchImageTask>>>,
|
||||
}
|
||||
|
||||
#[derive(Debug, PartialEq, Eq, Hash, Clone)]
|
||||
pub enum UriOrPath {
|
||||
Uri(SharedUri),
|
||||
Path(Arc<PathBuf>),
|
||||
}
|
||||
|
||||
impl From<SharedUri> for UriOrPath {
|
||||
fn from(value: SharedUri) -> Self {
|
||||
Self::Uri(value)
|
||||
}
|
||||
}
|
||||
|
||||
impl From<Arc<PathBuf>> for UriOrPath {
|
||||
fn from(value: Arc<PathBuf>) -> Self {
|
||||
Self::Path(value)
|
||||
}
|
||||
}
|
||||
|
||||
type FetchImageTask = Shared<Task<Result<Arc<ImageData>, Error>>>;
|
||||
|
@ -54,11 +73,11 @@ impl ImageCache {
|
|||
}
|
||||
}
|
||||
|
||||
pub fn get(&self, uri: impl Into<SharedUri>, cx: &AppContext) -> FetchImageTask {
|
||||
let uri = uri.into();
|
||||
pub fn get(&self, uri_or_path: impl Into<UriOrPath>, cx: &AppContext) -> FetchImageTask {
|
||||
let uri_or_path = uri_or_path.into();
|
||||
let mut images = self.images.lock();
|
||||
|
||||
match images.get(&uri) {
|
||||
match images.get(&uri_or_path) {
|
||||
Some(future) => future.clone(),
|
||||
None => {
|
||||
let client = self.client.clone();
|
||||
|
@ -66,14 +85,14 @@ impl ImageCache {
|
|||
.background_executor()
|
||||
.spawn(
|
||||
{
|
||||
let uri = uri.clone();
|
||||
let uri_or_path = uri_or_path.clone();
|
||||
async move {
|
||||
match uri {
|
||||
SharedUri::File(uri) => {
|
||||
match uri_or_path {
|
||||
UriOrPath::Path(uri) => {
|
||||
let image = image::open(uri.as_ref())?.into_bgra8();
|
||||
Ok(Arc::new(ImageData::new(image)))
|
||||
}
|
||||
SharedUri::Network(uri) => {
|
||||
UriOrPath::Uri(uri) => {
|
||||
let mut response =
|
||||
client.get(uri.as_ref(), ().into(), true).await?;
|
||||
let mut body = Vec::new();
|
||||
|
@ -96,16 +115,16 @@ impl ImageCache {
|
|||
}
|
||||
}
|
||||
.map_err({
|
||||
let uri = uri.clone();
|
||||
let uri_or_path = uri_or_path.clone();
|
||||
move |error| {
|
||||
log::log!(log::Level::Error, "{:?} {:?}", &uri, &error);
|
||||
log::log!(log::Level::Error, "{:?} {:?}", &uri_or_path, &error);
|
||||
error
|
||||
}
|
||||
}),
|
||||
)
|
||||
.shared();
|
||||
|
||||
images.insert(uri, future.clone());
|
||||
images.insert(uri_or_path, future.clone());
|
||||
future
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue