Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Replace i32 with u32 for database columns

Browse source 
We never expect to return signed integers and so we shouldn't use
a signed type. I think this was a limitation of sqlx.
This commit is contained in:
Antonio Scandurra 2022-12-01 17:47:51 +01:00
parent cfdf0a57b8
commit 29a4baf346
10 changed files with 41 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

5
crates/collab/src/rpc.rs
View file

@ -1008,7 +1008,7 @@ async fn join_project(
let collaborators = project
.collaborators
.iter()
.filter(|collaborator| collaborator.connection_id != session.connection_id.0 as i32)
.filter(|collaborator| collaborator.connection_id != session.connection_id.0)
.map(|collaborator| proto::Collaborator {
peer_id: collaborator.connection_id as u32,
replica_id: collaborator.replica_id.0 as u32,
@ -1313,8 +1313,7 @@ async fn save_buffer(
.await
.project_collaborators(project_id, session.connection_id)
.await?;
collaborators
.retain(|collaborator| collaborator.connection_id != session.connection_id.0 as i32);
collaborators.retain(|collaborator| collaborator.connection_id != session.connection_id.0);
let project_connection_ids = collaborators
.into_iter()
.map(|collaborator| ConnectionId(collaborator.connection_id as u32));