nix: Disable checks and remove crane workaround (#26356)

The checkPhase was failing for me in darwin so I turned it off. I think
eventually we'll want to use a separate derivation for tests (which
crane has a helper for).

Crane also solved our issue with spaces in paths so I bumped the flake
to pick up that fix and removed our workaround: ipetkov/crane#808.

Release Notes:

- N/A
This commit is contained in:
Julia Ryan 2025-03-10 02:00:57 -07:00 committed by GitHub
parent 4a7c84f490
commit 2a862b3c54
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 15 deletions

View file

@ -213,12 +213,9 @@ craneLib.buildPackage (
echo nightly > crates/zed/RELEASE_CHANNEL
'';
# TODO: try craneLib.cargoNextest separate output and doCheck=false
# do we even care about running our test suite in the nix sandbox?
# see crane bug: https://github.com/ipetkov/crane/issues/808
doNotRemoveReferencesToRustToolchain = true;
doNotRemoveReferencesToVendorDir = true;
# TODO: try craneLib.cargoNextest separate output
# for now we're not worried about running our test suite in the nix sandbox
doCheck = false;
installPhase =
if stdenv.hostPlatform.isDarwin then