Redesign and clean up all icons across Zed (#35856)

- [x] Clean up unused and old icons
- [x] Swap SVG for all in-use icons with the redesigned version
- [x] Document guidelines

Release Notes:

- N/A

crates/ui/src/components/banner.rs

@@ -24,7 +24,7 @@ pub enum Severity {
 ///     .action_slot(
 ///         Button::new("learn-more", "Learn More")
 ///             .icon(IconName::ArrowUpRight)
-///             .icon_size(IconSize::XSmall)
+///             .icon_size(IconSize::Small)
 ///             .icon_position(IconPosition::End),
 ///     )
 /// ```
@@ -150,7 +150,7 @@ impl Component for Banner {
                     .action_slot(
                         Button::new("learn-more", "Learn More")
                             .icon(IconName::ArrowUpRight)
-                            .icon_size(IconSize::XSmall)
+                            .icon_size(IconSize::Small)
                             .icon_position(IconPosition::End),
                     )
                     .into_any_element(),

crates/ui/src/components/callout.rs

@@ -207,7 +207,7 @@ impl Component for Callout {
                 "Error with Multiple Actions",
                 Callout::new()
                     .icon(
-                        Icon::new(IconName::X)
+                        Icon::new(IconName::Close)
                             .color(Color::Error)
                             .size(IconSize::Small),
                     )

crates/ui/src/components/context_menu.rs

@@ -561,7 +561,7 @@ impl ContextMenu {
             action: Some(action.boxed_clone()),
             handler: Rc::new(move |_, window, cx| window.dispatch_action(action.boxed_clone(), cx)),
             icon: Some(IconName::ArrowUpRight),
-            icon_size: IconSize::XSmall,
+            icon_size: IconSize::Small,
             icon_position: IconPosition::End,
             icon_color: None,
             disabled: false,

crates/ui/src/components/indicator.rs

@@ -164,7 +164,7 @@ impl Component for Indicator {
                             ),
                             single_example(
                                 "Error",
-                                Indicator::icon(Icon::new(IconName::X))
+                                Indicator::icon(Icon::new(IconName::Close))
                                     .color(Color::Error)
                                     .into_any_element(),
                             ),

crates/ui/src/components/keybinding.rs

@@ -188,7 +188,7 @@ fn icon_for_key(keystroke: &Keystroke, platform_style: PlatformStyle) -> Option<
         "up" => Some(IconName::ArrowUp),
         "down" => Some(IconName::ArrowDown),
         "backspace" => Some(IconName::Backspace),
-        "delete" => Some(IconName::Delete),
+        "delete" => Some(IconName::Backspace),
         "return" => Some(IconName::Return),
         "enter" => Some(IconName::Return),
         "tab" => Some(IconName::Tab),

crates/ui/src/components/stories/icon_button.rs

@@ -90,7 +90,7 @@ impl Render for IconButtonStory {
 
         let selected_with_tooltip_button = StoryItem::new(
             "Selected with `tooltip`",
-            IconButton::new("selected_with_tooltip_button", IconName::InlayHint)
+            IconButton::new("selected_with_tooltip_button", IconName::CaseSensitive)
                 .toggle_state(true)
                 .tooltip(Tooltip::text("Toggle inlay hints")),
         )