Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

terminal: Fix trailing single quote included when opening link from terminal (#33376)

Browse source 
Closes #33210 

Release Notes:

- Fixed an issue where a trailing single quote was included when opening
a link from the terminal.
This commit is contained in:
Sarmad Gulzar 2025-06-25 19:21:33 +05:00 • committed by GitHub
parent 0905255fd1
commit 308debe47f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

10
crates/terminal/src/terminal_hyperlinks.rs
View file

@ -8,7 +8,7 @@ use alacritty_terminal::{
use regex::Regex;
use std::{ops::Index, sync::LazyLock};
const URL_REGEX: &str = r#"(ipfs:|ipns:|magnet:|mailto:|gemini://|gopher://|https://|http://|news:|file://|git://|ssh:|ftp://)[^\u{0000}-\u{001F}\u{007F}-\u{009F}<>"\s{-}\^⟨⟩`]+"#;
const URL_REGEX: &str = r#"(ipfs:|ipns:|magnet:|mailto:|gemini://|gopher://|https://|http://|news:|file://|git://|ssh:|ftp://)[^\u{0000}-\u{001F}\u{007F}-\u{009F}<>"\s{-}\^⟨⟩`']+"#;
// Optional suffix matches MSBuild diagnostic suffixes for path parsing in PathLikeWithPosition
// https://learn.microsoft.com/en-us/visualstudio/msbuild/msbuild-diagnostic-format-for-tasks
const WORD_REGEX: &str =
@ -224,8 +224,12 @@ mod tests {
fn test_url_regex() {
re_test(
URL_REGEX,
"test http://example.com test mailto:bob@example.com train",
vec!["http://example.com", "mailto:bob@example.com"],
"test http://example.com test 'https://website1.com' test mailto:bob@example.com train",
vec![
"http://example.com",
"https://website1.com",
"mailto:bob@example.com",
],
);
}