Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

vim: Add support for moving to first, middle and last visible lines (H, L, M) (#6919)

Browse source 
This change implements the vim
[motion](https://github.com/vim/vim/blob/master/runtime/doc/motion.txt)
commands to move the cursor to the top, middle and bottom of the visible
view. This feature is requested in
https://github.com/zed-industries/zed/issues/4941.

This change takes inspiration from
[crates/vim/src/normal/scroll.rs](https://github.com/zed-industries/zed/blob/main/crates/vim/src/normal/scroll.rs).

A note on the behavior of these commands: Because
`NeovimBackedTestContext` requires compatibility with nvim, the current
implementation causes slightly non-standard behavior: it causes the
editor to scroll a few lines. The standard behavior causes no scrolling.
It is easy enough to account for the margin by adding
`VERTICAL_SCROLL_MARGIN`. However, doing so will cause test failures due
to the disparity between nvim and zed states. Perhaps
`NeovimBackedTestContext` should have a switch to be more tolerant for
such cases.

Release Notes:

- Added support for moving to top, middle and bottom of the screen in
vim mode (`H`, `M`, and `L`)
([#4941](https://github.com/zed-industries/zed/issues/4941)).
This commit is contained in:
Vishal Bhavsar 2024-01-29 22:58:24 -05:00 • committed by GitHub
parent 1ab49fdbe6
commit 31e9526544
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
9 changed files with 337 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

17
crates/vim/test_data/test_window_middle.json Normal file
View file

@ -0,0 +1,17 @@
{"Put":{"state":"abˇc\ndef\nparagraph\nthe second\nthird and\nfinal"}}
{"Key":"shift-m"}
{"Get":{"state":"abc\ndef\npaˇragraph\nthe second\nthird and\nfinal","mode":"Normal"}}
{"Put":{"state":"1 2 3\n4 5 6\n7 8 ˇ9\n"}}
{"Key":"shift-m"}
{"Get":{"state":"1 2 3\n4 5 ˇ6\n7 8 9\n","mode":"Normal"}}
{"Put":{"state":"1 2 3\n4 5 6\nˇ7 8 9\n"}}
{"Key":"shift-m"}
{"Get":{"state":"1 2 3\nˇ4 5 6\n7 8 9\n","mode":"Normal"}}
{"Put":{"state":"ˇ1 2 3\n4 5 6\n7 8 9\n"}}
{"Key":"shift-m"}
{"Get":{"state":"1 2 3\nˇ4 5 6\n7 8 9\n","mode":"Normal"}}
{"Key":"shift-m"}
{"Get":{"state":"1 2 3\nˇ4 5 6\n7 8 9\n","mode":"Normal"}}
{"Put":{"state":"1 2 3\n4 5 ˇ6\n7 8 9\n"}}
{"Key":"shift-m"}
{"Get":{"state":"1 2 3\n4 5 ˇ6\n7 8 9\n","mode":"Normal"}}