From 33c41fb5e13d37c6d46b5bc08b1424e055b64f93 Mon Sep 17 00:00:00 2001 From: "Joseph T. Lyons" Date: Sat, 9 Dec 2023 00:35:19 -0500 Subject: [PATCH] Show negative numbers after limit is hit --- crates/feedback2/src/feedback_modal.rs | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/crates/feedback2/src/feedback_modal.rs b/crates/feedback2/src/feedback_modal.rs index a4ada18f78..28afb67969 100644 --- a/crates/feedback2/src/feedback_modal.rs +++ b/crates/feedback2/src/feedback_modal.rs @@ -32,7 +32,7 @@ const DEV_MODE: bool = false; const DATABASE_KEY_NAME: &str = "email_address"; const EMAIL_REGEX: &str = r"\b[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Z|a-z]{2,}\b"; -const FEEDBACK_CHAR_LIMIT: RangeInclusive = 10..=5000; +const FEEDBACK_CHAR_LIMIT: RangeInclusive = 10..=5000; const FEEDBACK_SUBMISSION_ERROR_TEXT: &str = "Feedback failed to submit, see error log for details."; @@ -53,7 +53,7 @@ pub struct FeedbackModal { email_address_editor: View, awaiting_submission: bool, user_submitted: bool, - character_count: usize, + character_count: i32, } impl FocusableView for FeedbackModal { @@ -154,7 +154,7 @@ impl FeedbackModal { .as_singleton() .expect("Feedback editor is never a multi-buffer") .read(cx) - .len(); + .len() as i32; cx.notify(); } _ => {} @@ -344,11 +344,6 @@ impl Render for FeedbackModal { "Feedback must be at least {} characters.", FEEDBACK_CHAR_LIMIT.start() ) - } else if self.character_count > *FEEDBACK_CHAR_LIMIT.end() { - format!( - "Feedback must be less than {} characters.", - FEEDBACK_CHAR_LIMIT.end() - ) } else { format!( "Characters: {}",