Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Restore --all-targets for clippy (#9346)

Browse source 
This PR restores the `--all-targets` flag when running `cargo clippy`.

Without it, there are areas that Clippy does not check, as evidenced by
the violations that were caught once the flag was re-added.

Release Notes:

- N/A
This commit is contained in:
Marshall Bowers 2024-03-14 12:39:45 -04:00 • committed by GitHub
parent 5f02ef701d
commit 3610b076a0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
crates/go_to_line/src/go_to_line.rs
View file

@ -337,7 +337,7 @@ mod tests {
workspace: &View<Workspace>, workspace: &View<Workspace>,
cx: &mut VisualTestContext, cx: &mut VisualTestContext,
) -> View<GoToLine> { ) -> View<GoToLine> {
cx.dispatch_action(Toggle::default()); cx.dispatch_action(Toggle);
workspace.update(cx, |workspace, cx| { workspace.update(cx, |workspace, cx| {
workspace.active_modal::<GoToLine>(cx).unwrap().clone() workspace.active_modal::<GoToLine>(cx).unwrap().clone()
}) })

2
crates/outline/src/outline.rs
View file

@ -447,7 +447,7 @@ mod tests {
workspace: &View<Workspace>, workspace: &View<Workspace>,
cx: &mut VisualTestContext, cx: &mut VisualTestContext,
) -> View<Picker<OutlineViewDelegate>> { ) -> View<Picker<OutlineViewDelegate>> {
cx.dispatch_action(Toggle::default()); cx.dispatch_action(Toggle);
workspace.update(cx, |workspace, cx| { workspace.update(cx, |workspace, cx| {
workspace workspace
.active_modal::<OutlineView>(cx) .active_modal::<OutlineView>(cx)

5
tooling/xtask/src/main.rs
View file

@ -47,7 +47,10 @@ fn run_clippy(args: ClippyArgs) -> Result<()> {
clippy_command.arg("--workspace"); clippy_command.arg("--workspace");
} }
clippy_command.arg("--release").arg("--all-features"); clippy_command
.arg("--release")
.arg("--all-targets")
.arg("--all-features");
if args.fix { if args.fix {
clippy_command.arg("--fix"); clippy_command.arg("--fix");