Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Always notify a Picker when its delegate notifies

Browse source
This commit is contained in:
Max Brunsfeld 2022-04-20 16:03:11 -07:00
parent 84df1d6564
commit 3619d4c1c4
2 changed files with 11 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
crates/picker/src/picker.rs
View file

@ -139,7 +139,12 @@ impl<D: PickerDelegate> Picker<D> {
max_size: vec2f(540., 420.),
confirmed: false,
};
cx.defer(|this, cx| this.update_matches(String::new(), cx));
cx.defer(|this, cx| {
if let Some(delegate) = this.delegate.upgrade(cx) {
cx.observe(&delegate, |_, _, cx| cx.notify()).detach();
this.update_matches(String::new(), cx)
}
});
this
}
@ -174,7 +179,6 @@ impl<D: PickerDelegate> Picker<D> {
pub fn update_matches(&mut self, query: String, cx: &mut ViewContext<Self>) {
if let Some(delegate) = self.delegate.upgrade(cx) {
let update = delegate.update(cx, |d, cx| d.update_matches(query, cx));
cx.notify();
cx.spawn(|this, mut cx| async move {
update.await;
this.update(&mut cx, |this, cx| {