vim: Improve lifecycle (#16477)

Browse source

Closes #13579

A major painpoint in the Vim crate has been life-cycle management. We
used to have one global Vim instance that tried to track per-editor
state; this led to a number of subtle issues (e.g. #13579, the mode
indicator being global, and quick toggling between windows letting vim
mode's notion of the active editor get out of sync).

This PR changes the internal structure of the code so that there is now
one `Vim` instance per `Editor` (stored as an `Addon`); and the global
stuff is separated out. This fixes the above problems, and tidies up a
bunch of the mess in the codebase.

Release Notes:

* vim: Fixed accidental visual mode in project search and go to
references
([#13579](https://github.com/zed-industries/zed/issues/13579)).

...

This commit is contained in:

Conrad Irwin 2024-08-20 20:48:50 -06:00 • committed by GitHub

parent c4c07583c3

commit 36d51fe4a5

No known key found for this signature in database

GPG key ID: B5690EEEBB952194

32 changed files with 3362 additions and 3585 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1313

crates/vim/src/vim.rs

View file

File diff suppressed because it is too large Load diff