Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address review feedback.

Browse source 
Rename selected_rows to background_highlight_row_ranges.
Do not return any ranges if there are more than 50k results
This commit is contained in:
Piotr Osiewicz 2023-08-08 02:45:15 +02:00
parent b0fc6da55b
commit 371c669e00
2 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
crates/editor/src/editor.rs
View file

@ -7549,7 +7549,7 @@ impl Editor {
results
}
pub fn selected_rows<T: 'static>(
pub fn background_highlight_row_ranges<T: 'static>(
&self,
search_range: Range<Anchor>,
display_snapshot: &DisplaySnapshot,
@ -7616,7 +7616,9 @@ impl Editor {
}
// We might still have a hunk that was not rendered (if there was a search hit on the last line)
push_region(start_row, end_row);
if results.len() > count {
return vec![];
}
results
}

2
crates/editor/src/element.rs
View file

@ -1133,7 +1133,7 @@ impl EditorElement {
})
};
let background_ranges = editor
.selected_rows::<crate::items::BufferSearchHighlights>(
.background_highlight_row_ranges::<crate::items::BufferSearchHighlights>(
start_anchor..end_anchor,
&layout.position_map.snapshot,
50000,