Pull diagnostics fixes (#32242)

Follow-up of https://github.com/zed-industries/zed/pull/19230

* starts to send `result_id` in pull requests to allow servers to reply
with non-full results
* fixes a bug where disk-based diagnostics were offset after pulling the
diagnostics
* fixes a bug due to which pull diagnostics could not be disabled
* uses better names and comments for the workspace pull diagnostics part

Release Notes:

- N/A

crates/proto/proto/lsp.proto

@@ -804,6 +804,6 @@ message PulledDiagnostics {
     repeated LspDiagnostic diagnostics = 5;
 }
 
-message RefreshDocumentsDiagnostics {
+message PullWorkspaceDiagnostics {
     uint64 project_id = 1;
 }

crates/proto/proto/zed.proto

@@ -391,7 +391,7 @@ message Envelope {
 
         GetDocumentDiagnostics get_document_diagnostics = 350;
         GetDocumentDiagnosticsResponse get_document_diagnostics_response = 351;
-        RefreshDocumentsDiagnostics refresh_documents_diagnostics = 352; // current max
+        PullWorkspaceDiagnostics pull_workspace_diagnostics = 352; // current max
 
     }
 

crates/proto/src/proto.rs

@@ -309,7 +309,7 @@ messages!(
     (LogToDebugConsole, Background),
     (GetDocumentDiagnostics, Background),
     (GetDocumentDiagnosticsResponse, Background),
-    (RefreshDocumentsDiagnostics, Background)
+    (PullWorkspaceDiagnostics, Background)
 );
 
 request_messages!(
@@ -473,7 +473,7 @@ request_messages!(
     (GetDebugAdapterBinary, DebugAdapterBinary),
     (RunDebugLocators, DebugRequest),
     (GetDocumentDiagnostics, GetDocumentDiagnosticsResponse),
-    (RefreshDocumentsDiagnostics, Ack)
+    (PullWorkspaceDiagnostics, Ack)
 );
 
 entity_messages!(
@@ -601,7 +601,7 @@ entity_messages!(
     GetDebugAdapterBinary,
     LogToDebugConsole,
     GetDocumentDiagnostics,
-    RefreshDocumentsDiagnostics
+    PullWorkspaceDiagnostics
 );
 
 entity_messages!(