Fully support all mention kinds (#36134)
Feature parity with the agent1 @mention kinds: - File - Symbols - Selections - Threads - Rules - Fetch Release Notes: - N/A --------- Co-authored-by: Cole Miller <cole@zed.dev>
This commit is contained in:
parent
389d382f42
commit
389d24d7e5
17 changed files with 1787 additions and 324 deletions
3
Cargo.lock
generated
3
Cargo.lock
generated
|
@ -7,6 +7,7 @@ name = "acp_thread"
|
||||||
version = "0.1.0"
|
version = "0.1.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"action_log",
|
"action_log",
|
||||||
|
"agent",
|
||||||
"agent-client-protocol",
|
"agent-client-protocol",
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"buffer_diff",
|
"buffer_diff",
|
||||||
|
@ -21,6 +22,7 @@ dependencies = [
|
||||||
"markdown",
|
"markdown",
|
||||||
"parking_lot",
|
"parking_lot",
|
||||||
"project",
|
"project",
|
||||||
|
"prompt_store",
|
||||||
"rand 0.8.5",
|
"rand 0.8.5",
|
||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
|
@ -392,6 +394,7 @@ dependencies = [
|
||||||
"ui",
|
"ui",
|
||||||
"ui_input",
|
"ui_input",
|
||||||
"unindent",
|
"unindent",
|
||||||
|
"url",
|
||||||
"urlencoding",
|
"urlencoding",
|
||||||
"util",
|
"util",
|
||||||
"uuid",
|
"uuid",
|
||||||
|
|
|
@ -18,6 +18,7 @@ test-support = ["gpui/test-support", "project/test-support"]
|
||||||
[dependencies]
|
[dependencies]
|
||||||
action_log.workspace = true
|
action_log.workspace = true
|
||||||
agent-client-protocol.workspace = true
|
agent-client-protocol.workspace = true
|
||||||
|
agent.workspace = true
|
||||||
anyhow.workspace = true
|
anyhow.workspace = true
|
||||||
buffer_diff.workspace = true
|
buffer_diff.workspace = true
|
||||||
collections.workspace = true
|
collections.workspace = true
|
||||||
|
@ -28,6 +29,7 @@ itertools.workspace = true
|
||||||
language.workspace = true
|
language.workspace = true
|
||||||
markdown.workspace = true
|
markdown.workspace = true
|
||||||
project.workspace = true
|
project.workspace = true
|
||||||
|
prompt_store.workspace = true
|
||||||
serde.workspace = true
|
serde.workspace = true
|
||||||
serde_json.workspace = true
|
serde_json.workspace = true
|
||||||
settings.workspace = true
|
settings.workspace = true
|
||||||
|
|
|
@ -399,7 +399,7 @@ impl ContentBlock {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
let new_content = self.extract_content_from_block(block);
|
let new_content = self.block_string_contents(block);
|
||||||
|
|
||||||
match self {
|
match self {
|
||||||
ContentBlock::Empty => {
|
ContentBlock::Empty => {
|
||||||
|
@ -409,7 +409,7 @@ impl ContentBlock {
|
||||||
markdown.update(cx, |markdown, cx| markdown.append(&new_content, cx));
|
markdown.update(cx, |markdown, cx| markdown.append(&new_content, cx));
|
||||||
}
|
}
|
||||||
ContentBlock::ResourceLink { resource_link } => {
|
ContentBlock::ResourceLink { resource_link } => {
|
||||||
let existing_content = Self::resource_link_to_content(&resource_link.uri);
|
let existing_content = Self::resource_link_md(&resource_link.uri);
|
||||||
let combined = format!("{}\n{}", existing_content, new_content);
|
let combined = format!("{}\n{}", existing_content, new_content);
|
||||||
|
|
||||||
*self = Self::create_markdown_block(combined, language_registry, cx);
|
*self = Self::create_markdown_block(combined, language_registry, cx);
|
||||||
|
@ -417,14 +417,6 @@ impl ContentBlock {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn resource_link_to_content(uri: &str) -> String {
|
|
||||||
if let Some(uri) = MentionUri::parse(&uri).log_err() {
|
|
||||||
uri.to_link()
|
|
||||||
} else {
|
|
||||||
uri.to_string().clone()
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn create_markdown_block(
|
fn create_markdown_block(
|
||||||
content: String,
|
content: String,
|
||||||
language_registry: &Arc<LanguageRegistry>,
|
language_registry: &Arc<LanguageRegistry>,
|
||||||
|
@ -436,11 +428,11 @@ impl ContentBlock {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn extract_content_from_block(&self, block: acp::ContentBlock) -> String {
|
fn block_string_contents(&self, block: acp::ContentBlock) -> String {
|
||||||
match block {
|
match block {
|
||||||
acp::ContentBlock::Text(text_content) => text_content.text.clone(),
|
acp::ContentBlock::Text(text_content) => text_content.text.clone(),
|
||||||
acp::ContentBlock::ResourceLink(resource_link) => {
|
acp::ContentBlock::ResourceLink(resource_link) => {
|
||||||
Self::resource_link_to_content(&resource_link.uri)
|
Self::resource_link_md(&resource_link.uri)
|
||||||
}
|
}
|
||||||
acp::ContentBlock::Resource(acp::EmbeddedResource {
|
acp::ContentBlock::Resource(acp::EmbeddedResource {
|
||||||
resource:
|
resource:
|
||||||
|
@ -449,13 +441,21 @@ impl ContentBlock {
|
||||||
..
|
..
|
||||||
}),
|
}),
|
||||||
..
|
..
|
||||||
}) => Self::resource_link_to_content(&uri),
|
}) => Self::resource_link_md(&uri),
|
||||||
acp::ContentBlock::Image(_)
|
acp::ContentBlock::Image(_)
|
||||||
| acp::ContentBlock::Audio(_)
|
| acp::ContentBlock::Audio(_)
|
||||||
| acp::ContentBlock::Resource(_) => String::new(),
|
| acp::ContentBlock::Resource(_) => String::new(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn resource_link_md(uri: &str) -> String {
|
||||||
|
if let Some(uri) = MentionUri::parse(&uri).log_err() {
|
||||||
|
uri.as_link().to_string()
|
||||||
|
} else {
|
||||||
|
uri.to_string()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
fn to_markdown<'a>(&'a self, cx: &'a App) -> &'a str {
|
fn to_markdown<'a>(&'a self, cx: &'a App) -> &'a str {
|
||||||
match self {
|
match self {
|
||||||
ContentBlock::Empty => "",
|
ContentBlock::Empty => "",
|
||||||
|
|
|
@ -1,13 +1,40 @@
|
||||||
use agent_client_protocol as acp;
|
use agent::ThreadId;
|
||||||
use anyhow::{Result, bail};
|
use anyhow::{Context as _, Result, bail};
|
||||||
use std::path::PathBuf;
|
use prompt_store::{PromptId, UserPromptId};
|
||||||
|
use std::{
|
||||||
|
fmt,
|
||||||
|
ops::Range,
|
||||||
|
path::{Path, PathBuf},
|
||||||
|
};
|
||||||
|
use url::Url;
|
||||||
|
|
||||||
#[derive(Clone, Debug, PartialEq, Eq)]
|
#[derive(Clone, Debug, PartialEq, Eq)]
|
||||||
pub enum MentionUri {
|
pub enum MentionUri {
|
||||||
File(PathBuf),
|
File(PathBuf),
|
||||||
Symbol(PathBuf, String),
|
Symbol {
|
||||||
Thread(acp::SessionId),
|
path: PathBuf,
|
||||||
Rule(String),
|
name: String,
|
||||||
|
line_range: Range<u32>,
|
||||||
|
},
|
||||||
|
Thread {
|
||||||
|
id: ThreadId,
|
||||||
|
name: String,
|
||||||
|
},
|
||||||
|
TextThread {
|
||||||
|
path: PathBuf,
|
||||||
|
name: String,
|
||||||
|
},
|
||||||
|
Rule {
|
||||||
|
id: PromptId,
|
||||||
|
name: String,
|
||||||
|
},
|
||||||
|
Selection {
|
||||||
|
path: PathBuf,
|
||||||
|
line_range: Range<u32>,
|
||||||
|
},
|
||||||
|
Fetch {
|
||||||
|
url: Url,
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
impl MentionUri {
|
impl MentionUri {
|
||||||
|
@ -17,7 +44,34 @@ impl MentionUri {
|
||||||
match url.scheme() {
|
match url.scheme() {
|
||||||
"file" => {
|
"file" => {
|
||||||
if let Some(fragment) = url.fragment() {
|
if let Some(fragment) = url.fragment() {
|
||||||
Ok(Self::Symbol(path.into(), fragment.into()))
|
let range = fragment
|
||||||
|
.strip_prefix("L")
|
||||||
|
.context("Line range must start with \"L\"")?;
|
||||||
|
let (start, end) = range
|
||||||
|
.split_once(":")
|
||||||
|
.context("Line range must use colon as separator")?;
|
||||||
|
let line_range = start
|
||||||
|
.parse::<u32>()
|
||||||
|
.context("Parsing line range start")?
|
||||||
|
.checked_sub(1)
|
||||||
|
.context("Line numbers should be 1-based")?
|
||||||
|
..end
|
||||||
|
.parse::<u32>()
|
||||||
|
.context("Parsing line range end")?
|
||||||
|
.checked_sub(1)
|
||||||
|
.context("Line numbers should be 1-based")?;
|
||||||
|
if let Some(name) = single_query_param(&url, "symbol")? {
|
||||||
|
Ok(Self::Symbol {
|
||||||
|
name,
|
||||||
|
path: path.into(),
|
||||||
|
line_range,
|
||||||
|
})
|
||||||
|
} else {
|
||||||
|
Ok(Self::Selection {
|
||||||
|
path: path.into(),
|
||||||
|
line_range,
|
||||||
|
})
|
||||||
|
}
|
||||||
} else {
|
} else {
|
||||||
let file_path =
|
let file_path =
|
||||||
PathBuf::from(format!("{}{}", url.host_str().unwrap_or(""), path));
|
PathBuf::from(format!("{}{}", url.host_str().unwrap_or(""), path));
|
||||||
|
@ -26,100 +80,292 @@ impl MentionUri {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
"zed" => {
|
"zed" => {
|
||||||
if let Some(thread) = path.strip_prefix("/agent/thread/") {
|
if let Some(thread_id) = path.strip_prefix("/agent/thread/") {
|
||||||
Ok(Self::Thread(acp::SessionId(thread.into())))
|
let name = single_query_param(&url, "name")?.context("Missing thread name")?;
|
||||||
} else if let Some(rule) = path.strip_prefix("/agent/rule/") {
|
Ok(Self::Thread {
|
||||||
Ok(Self::Rule(rule.into()))
|
id: thread_id.into(),
|
||||||
|
name,
|
||||||
|
})
|
||||||
|
} else if let Some(path) = path.strip_prefix("/agent/text-thread/") {
|
||||||
|
let name = single_query_param(&url, "name")?.context("Missing thread name")?;
|
||||||
|
Ok(Self::TextThread {
|
||||||
|
path: path.into(),
|
||||||
|
name,
|
||||||
|
})
|
||||||
|
} else if let Some(rule_id) = path.strip_prefix("/agent/rule/") {
|
||||||
|
let name = single_query_param(&url, "name")?.context("Missing rule name")?;
|
||||||
|
let rule_id = UserPromptId(rule_id.parse()?);
|
||||||
|
Ok(Self::Rule {
|
||||||
|
id: rule_id.into(),
|
||||||
|
name,
|
||||||
|
})
|
||||||
} else {
|
} else {
|
||||||
bail!("invalid zed url: {:?}", input);
|
bail!("invalid zed url: {:?}", input);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
"http" | "https" => Ok(MentionUri::Fetch { url }),
|
||||||
other => bail!("unrecognized scheme {:?}", other),
|
other => bail!("unrecognized scheme {:?}", other),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn name(&self) -> String {
|
fn name(&self) -> String {
|
||||||
match self {
|
match self {
|
||||||
MentionUri::File(path) => path.file_name().unwrap().to_string_lossy().into_owned(),
|
MentionUri::File(path) => path
|
||||||
MentionUri::Symbol(_path, name) => name.clone(),
|
.file_name()
|
||||||
MentionUri::Thread(thread) => thread.to_string(),
|
.unwrap_or_default()
|
||||||
MentionUri::Rule(rule) => rule.clone(),
|
.to_string_lossy()
|
||||||
|
.into_owned(),
|
||||||
|
MentionUri::Symbol { name, .. } => name.clone(),
|
||||||
|
MentionUri::Thread { name, .. } => name.clone(),
|
||||||
|
MentionUri::TextThread { name, .. } => name.clone(),
|
||||||
|
MentionUri::Rule { name, .. } => name.clone(),
|
||||||
|
MentionUri::Selection {
|
||||||
|
path, line_range, ..
|
||||||
|
} => selection_name(path, line_range),
|
||||||
|
MentionUri::Fetch { url } => url.to_string(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn to_link(&self) -> String {
|
pub fn as_link<'a>(&'a self) -> MentionLink<'a> {
|
||||||
let name = self.name();
|
MentionLink(self)
|
||||||
let uri = self.to_uri();
|
|
||||||
format!("[{name}]({uri})")
|
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn to_uri(&self) -> String {
|
pub fn to_uri(&self) -> Url {
|
||||||
match self {
|
match self {
|
||||||
MentionUri::File(path) => {
|
MentionUri::File(path) => {
|
||||||
format!("file://{}", path.display())
|
let mut url = Url::parse("file:///").unwrap();
|
||||||
|
url.set_path(&path.to_string_lossy());
|
||||||
|
url
|
||||||
}
|
}
|
||||||
MentionUri::Symbol(path, name) => {
|
MentionUri::Symbol {
|
||||||
format!("file://{}#{}", path.display(), name)
|
path,
|
||||||
|
name,
|
||||||
|
line_range,
|
||||||
|
} => {
|
||||||
|
let mut url = Url::parse("file:///").unwrap();
|
||||||
|
url.set_path(&path.to_string_lossy());
|
||||||
|
url.query_pairs_mut().append_pair("symbol", name);
|
||||||
|
url.set_fragment(Some(&format!(
|
||||||
|
"L{}:{}",
|
||||||
|
line_range.start + 1,
|
||||||
|
line_range.end + 1
|
||||||
|
)));
|
||||||
|
url
|
||||||
}
|
}
|
||||||
MentionUri::Thread(thread) => {
|
MentionUri::Selection { path, line_range } => {
|
||||||
format!("zed:///agent/thread/{}", thread.0)
|
let mut url = Url::parse("file:///").unwrap();
|
||||||
|
url.set_path(&path.to_string_lossy());
|
||||||
|
url.set_fragment(Some(&format!(
|
||||||
|
"L{}:{}",
|
||||||
|
line_range.start + 1,
|
||||||
|
line_range.end + 1
|
||||||
|
)));
|
||||||
|
url
|
||||||
}
|
}
|
||||||
MentionUri::Rule(rule) => {
|
MentionUri::Thread { name, id } => {
|
||||||
format!("zed:///agent/rule/{}", rule)
|
let mut url = Url::parse("zed:///").unwrap();
|
||||||
|
url.set_path(&format!("/agent/thread/{id}"));
|
||||||
|
url.query_pairs_mut().append_pair("name", name);
|
||||||
|
url
|
||||||
}
|
}
|
||||||
|
MentionUri::TextThread { path, name } => {
|
||||||
|
let mut url = Url::parse("zed:///").unwrap();
|
||||||
|
url.set_path(&format!("/agent/text-thread/{}", path.to_string_lossy()));
|
||||||
|
url.query_pairs_mut().append_pair("name", name);
|
||||||
|
url
|
||||||
|
}
|
||||||
|
MentionUri::Rule { name, id } => {
|
||||||
|
let mut url = Url::parse("zed:///").unwrap();
|
||||||
|
url.set_path(&format!("/agent/rule/{id}"));
|
||||||
|
url.query_pairs_mut().append_pair("name", name);
|
||||||
|
url
|
||||||
|
}
|
||||||
|
MentionUri::Fetch { url } => url.clone(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
pub struct MentionLink<'a>(&'a MentionUri);
|
||||||
|
|
||||||
|
impl fmt::Display for MentionLink<'_> {
|
||||||
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
||||||
|
write!(f, "[@{}]({})", self.0.name(), self.0.to_uri())
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn single_query_param(url: &Url, name: &'static str) -> Result<Option<String>> {
|
||||||
|
let pairs = url.query_pairs().collect::<Vec<_>>();
|
||||||
|
match pairs.as_slice() {
|
||||||
|
[] => Ok(None),
|
||||||
|
[(k, v)] => {
|
||||||
|
if k != name {
|
||||||
|
bail!("invalid query parameter")
|
||||||
|
}
|
||||||
|
|
||||||
|
Ok(Some(v.to_string()))
|
||||||
|
}
|
||||||
|
_ => bail!("too many query pairs"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn selection_name(path: &Path, line_range: &Range<u32>) -> String {
|
||||||
|
format!(
|
||||||
|
"{} ({}:{})",
|
||||||
|
path.file_name().unwrap_or_default().display(),
|
||||||
|
line_range.start + 1,
|
||||||
|
line_range.end + 1
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn test_mention_uri_parse_and_display() {
|
fn test_parse_file_uri() {
|
||||||
// Test file URI
|
|
||||||
let file_uri = "file:///path/to/file.rs";
|
let file_uri = "file:///path/to/file.rs";
|
||||||
let parsed = MentionUri::parse(file_uri).unwrap();
|
let parsed = MentionUri::parse(file_uri).unwrap();
|
||||||
match &parsed {
|
match &parsed {
|
||||||
MentionUri::File(path) => assert_eq!(path.to_str().unwrap(), "/path/to/file.rs"),
|
MentionUri::File(path) => assert_eq!(path.to_str().unwrap(), "/path/to/file.rs"),
|
||||||
_ => panic!("Expected File variant"),
|
_ => panic!("Expected File variant"),
|
||||||
}
|
}
|
||||||
assert_eq!(parsed.to_uri(), file_uri);
|
assert_eq!(parsed.to_uri().to_string(), file_uri);
|
||||||
|
}
|
||||||
|
|
||||||
// Test symbol URI
|
#[test]
|
||||||
let symbol_uri = "file:///path/to/file.rs#MySymbol";
|
fn test_parse_symbol_uri() {
|
||||||
|
let symbol_uri = "file:///path/to/file.rs?symbol=MySymbol#L10:20";
|
||||||
let parsed = MentionUri::parse(symbol_uri).unwrap();
|
let parsed = MentionUri::parse(symbol_uri).unwrap();
|
||||||
match &parsed {
|
match &parsed {
|
||||||
MentionUri::Symbol(path, symbol) => {
|
MentionUri::Symbol {
|
||||||
|
path,
|
||||||
|
name,
|
||||||
|
line_range,
|
||||||
|
} => {
|
||||||
assert_eq!(path.to_str().unwrap(), "/path/to/file.rs");
|
assert_eq!(path.to_str().unwrap(), "/path/to/file.rs");
|
||||||
assert_eq!(symbol, "MySymbol");
|
assert_eq!(name, "MySymbol");
|
||||||
|
assert_eq!(line_range.start, 9);
|
||||||
|
assert_eq!(line_range.end, 19);
|
||||||
}
|
}
|
||||||
_ => panic!("Expected Symbol variant"),
|
_ => panic!("Expected Symbol variant"),
|
||||||
}
|
}
|
||||||
assert_eq!(parsed.to_uri(), symbol_uri);
|
assert_eq!(parsed.to_uri().to_string(), symbol_uri);
|
||||||
|
}
|
||||||
|
|
||||||
// Test thread URI
|
#[test]
|
||||||
let thread_uri = "zed:///agent/thread/session123";
|
fn test_parse_selection_uri() {
|
||||||
|
let selection_uri = "file:///path/to/file.rs#L5:15";
|
||||||
|
let parsed = MentionUri::parse(selection_uri).unwrap();
|
||||||
|
match &parsed {
|
||||||
|
MentionUri::Selection { path, line_range } => {
|
||||||
|
assert_eq!(path.to_str().unwrap(), "/path/to/file.rs");
|
||||||
|
assert_eq!(line_range.start, 4);
|
||||||
|
assert_eq!(line_range.end, 14);
|
||||||
|
}
|
||||||
|
_ => panic!("Expected Selection variant"),
|
||||||
|
}
|
||||||
|
assert_eq!(parsed.to_uri().to_string(), selection_uri);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_parse_thread_uri() {
|
||||||
|
let thread_uri = "zed:///agent/thread/session123?name=Thread+name";
|
||||||
let parsed = MentionUri::parse(thread_uri).unwrap();
|
let parsed = MentionUri::parse(thread_uri).unwrap();
|
||||||
match &parsed {
|
match &parsed {
|
||||||
MentionUri::Thread(session_id) => assert_eq!(session_id.0.as_ref(), "session123"),
|
MentionUri::Thread {
|
||||||
|
id: thread_id,
|
||||||
|
name,
|
||||||
|
} => {
|
||||||
|
assert_eq!(thread_id.to_string(), "session123");
|
||||||
|
assert_eq!(name, "Thread name");
|
||||||
|
}
|
||||||
_ => panic!("Expected Thread variant"),
|
_ => panic!("Expected Thread variant"),
|
||||||
}
|
}
|
||||||
assert_eq!(parsed.to_uri(), thread_uri);
|
assert_eq!(parsed.to_uri().to_string(), thread_uri);
|
||||||
|
}
|
||||||
|
|
||||||
// Test rule URI
|
#[test]
|
||||||
let rule_uri = "zed:///agent/rule/my_rule";
|
fn test_parse_rule_uri() {
|
||||||
|
let rule_uri = "zed:///agent/rule/d8694ff2-90d5-4b6f-be33-33c1763acd52?name=Some+rule";
|
||||||
let parsed = MentionUri::parse(rule_uri).unwrap();
|
let parsed = MentionUri::parse(rule_uri).unwrap();
|
||||||
match &parsed {
|
match &parsed {
|
||||||
MentionUri::Rule(rule) => assert_eq!(rule, "my_rule"),
|
MentionUri::Rule { id, name } => {
|
||||||
|
assert_eq!(id.to_string(), "d8694ff2-90d5-4b6f-be33-33c1763acd52");
|
||||||
|
assert_eq!(name, "Some rule");
|
||||||
|
}
|
||||||
_ => panic!("Expected Rule variant"),
|
_ => panic!("Expected Rule variant"),
|
||||||
}
|
}
|
||||||
assert_eq!(parsed.to_uri(), rule_uri);
|
assert_eq!(parsed.to_uri().to_string(), rule_uri);
|
||||||
|
}
|
||||||
|
|
||||||
// Test invalid scheme
|
#[test]
|
||||||
assert!(MentionUri::parse("http://example.com").is_err());
|
fn test_parse_fetch_http_uri() {
|
||||||
|
let http_uri = "http://example.com/path?query=value#fragment";
|
||||||
|
let parsed = MentionUri::parse(http_uri).unwrap();
|
||||||
|
match &parsed {
|
||||||
|
MentionUri::Fetch { url } => {
|
||||||
|
assert_eq!(url.to_string(), http_uri);
|
||||||
|
}
|
||||||
|
_ => panic!("Expected Fetch variant"),
|
||||||
|
}
|
||||||
|
assert_eq!(parsed.to_uri().to_string(), http_uri);
|
||||||
|
}
|
||||||
|
|
||||||
// Test invalid zed path
|
#[test]
|
||||||
|
fn test_parse_fetch_https_uri() {
|
||||||
|
let https_uri = "https://example.com/api/endpoint";
|
||||||
|
let parsed = MentionUri::parse(https_uri).unwrap();
|
||||||
|
match &parsed {
|
||||||
|
MentionUri::Fetch { url } => {
|
||||||
|
assert_eq!(url.to_string(), https_uri);
|
||||||
|
}
|
||||||
|
_ => panic!("Expected Fetch variant"),
|
||||||
|
}
|
||||||
|
assert_eq!(parsed.to_uri().to_string(), https_uri);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_invalid_scheme() {
|
||||||
|
assert!(MentionUri::parse("ftp://example.com").is_err());
|
||||||
|
assert!(MentionUri::parse("ssh://example.com").is_err());
|
||||||
|
assert!(MentionUri::parse("unknown://example.com").is_err());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_invalid_zed_path() {
|
||||||
assert!(MentionUri::parse("zed:///invalid/path").is_err());
|
assert!(MentionUri::parse("zed:///invalid/path").is_err());
|
||||||
|
assert!(MentionUri::parse("zed:///agent/unknown/test").is_err());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_invalid_line_range_format() {
|
||||||
|
// Missing L prefix
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#10:20").is_err());
|
||||||
|
|
||||||
|
// Missing colon separator
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#L1020").is_err());
|
||||||
|
|
||||||
|
// Invalid numbers
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#L10:abc").is_err());
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#Labc:20").is_err());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_invalid_query_parameters() {
|
||||||
|
// Invalid query parameter name
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#L10:20?invalid=test").is_err());
|
||||||
|
|
||||||
|
// Too many query parameters
|
||||||
|
assert!(
|
||||||
|
MentionUri::parse("file:///path/to/file.rs#L10:20?symbol=test&another=param").is_err()
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn test_zero_based_line_numbers() {
|
||||||
|
// Test that 0-based line numbers are rejected (should be 1-based)
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#L0:10").is_err());
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#L1:0").is_err());
|
||||||
|
assert!(MentionUri::parse("file:///path/to/file.rs#L0:0").is_err());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
@ -205,6 +205,22 @@ impl ThreadStore {
|
||||||
(this, ready_rx)
|
(this, ready_rx)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(any(test, feature = "test-support"))]
|
||||||
|
pub fn fake(project: Entity<Project>, cx: &mut App) -> Self {
|
||||||
|
Self {
|
||||||
|
project,
|
||||||
|
tools: cx.new(|_| ToolWorkingSet::default()),
|
||||||
|
prompt_builder: Arc::new(PromptBuilder::new(None).unwrap()),
|
||||||
|
prompt_store: None,
|
||||||
|
context_server_tool_ids: HashMap::default(),
|
||||||
|
threads: Vec::new(),
|
||||||
|
project_context: SharedProjectContext::default(),
|
||||||
|
reload_system_prompt_tx: mpsc::channel(0).0,
|
||||||
|
_reload_system_prompt_task: Task::ready(()),
|
||||||
|
_subscriptions: vec![],
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
fn handle_project_event(
|
fn handle_project_event(
|
||||||
&mut self,
|
&mut self,
|
||||||
_project: Entity<Project>,
|
_project: Entity<Project>,
|
||||||
|
|
|
@ -25,8 +25,8 @@ use schemars::{JsonSchema, Schema};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
use settings::{Settings, update_settings_file};
|
use settings::{Settings, update_settings_file};
|
||||||
use smol::stream::StreamExt;
|
use smol::stream::StreamExt;
|
||||||
use std::fmt::Write;
|
|
||||||
use std::{cell::RefCell, collections::BTreeMap, path::Path, rc::Rc, sync::Arc};
|
use std::{cell::RefCell, collections::BTreeMap, path::Path, rc::Rc, sync::Arc};
|
||||||
|
use std::{fmt::Write, ops::Range};
|
||||||
use util::{ResultExt, markdown::MarkdownCodeBlock};
|
use util::{ResultExt, markdown::MarkdownCodeBlock};
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
@ -79,9 +79,9 @@ impl UserMessage {
|
||||||
}
|
}
|
||||||
UserMessageContent::Mention { uri, content } => {
|
UserMessageContent::Mention { uri, content } => {
|
||||||
if !content.is_empty() {
|
if !content.is_empty() {
|
||||||
markdown.push_str(&format!("{}\n\n{}\n", uri.to_link(), content));
|
let _ = write!(&mut markdown, "{}\n\n{}\n", uri.as_link(), content);
|
||||||
} else {
|
} else {
|
||||||
markdown.push_str(&format!("{}\n", uri.to_link()));
|
let _ = write!(&mut markdown, "{}\n", uri.as_link());
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -104,12 +104,14 @@ impl UserMessage {
|
||||||
const OPEN_FILES_TAG: &str = "<files>";
|
const OPEN_FILES_TAG: &str = "<files>";
|
||||||
const OPEN_SYMBOLS_TAG: &str = "<symbols>";
|
const OPEN_SYMBOLS_TAG: &str = "<symbols>";
|
||||||
const OPEN_THREADS_TAG: &str = "<threads>";
|
const OPEN_THREADS_TAG: &str = "<threads>";
|
||||||
|
const OPEN_FETCH_TAG: &str = "<fetched_urls>";
|
||||||
const OPEN_RULES_TAG: &str =
|
const OPEN_RULES_TAG: &str =
|
||||||
"<rules>\nThe user has specified the following rules that should be applied:\n";
|
"<rules>\nThe user has specified the following rules that should be applied:\n";
|
||||||
|
|
||||||
let mut file_context = OPEN_FILES_TAG.to_string();
|
let mut file_context = OPEN_FILES_TAG.to_string();
|
||||||
let mut symbol_context = OPEN_SYMBOLS_TAG.to_string();
|
let mut symbol_context = OPEN_SYMBOLS_TAG.to_string();
|
||||||
let mut thread_context = OPEN_THREADS_TAG.to_string();
|
let mut thread_context = OPEN_THREADS_TAG.to_string();
|
||||||
|
let mut fetch_context = OPEN_FETCH_TAG.to_string();
|
||||||
let mut rules_context = OPEN_RULES_TAG.to_string();
|
let mut rules_context = OPEN_RULES_TAG.to_string();
|
||||||
|
|
||||||
for chunk in &self.content {
|
for chunk in &self.content {
|
||||||
|
@ -122,21 +124,40 @@ impl UserMessage {
|
||||||
}
|
}
|
||||||
UserMessageContent::Mention { uri, content } => {
|
UserMessageContent::Mention { uri, content } => {
|
||||||
match uri {
|
match uri {
|
||||||
MentionUri::File(path) | MentionUri::Symbol(path, _) => {
|
MentionUri::File(path) => {
|
||||||
write!(
|
write!(
|
||||||
&mut symbol_context,
|
&mut symbol_context,
|
||||||
"\n{}",
|
"\n{}",
|
||||||
MarkdownCodeBlock {
|
MarkdownCodeBlock {
|
||||||
tag: &codeblock_tag(&path),
|
tag: &codeblock_tag(&path, None),
|
||||||
text: &content.to_string(),
|
text: &content.to_string(),
|
||||||
}
|
}
|
||||||
)
|
)
|
||||||
.ok();
|
.ok();
|
||||||
}
|
}
|
||||||
MentionUri::Thread(_session_id) => {
|
MentionUri::Symbol {
|
||||||
|
path, line_range, ..
|
||||||
|
}
|
||||||
|
| MentionUri::Selection {
|
||||||
|
path, line_range, ..
|
||||||
|
} => {
|
||||||
|
write!(
|
||||||
|
&mut rules_context,
|
||||||
|
"\n{}",
|
||||||
|
MarkdownCodeBlock {
|
||||||
|
tag: &codeblock_tag(&path, Some(line_range)),
|
||||||
|
text: &content
|
||||||
|
}
|
||||||
|
)
|
||||||
|
.ok();
|
||||||
|
}
|
||||||
|
MentionUri::Thread { .. } => {
|
||||||
write!(&mut thread_context, "\n{}\n", content).ok();
|
write!(&mut thread_context, "\n{}\n", content).ok();
|
||||||
}
|
}
|
||||||
MentionUri::Rule(_user_prompt_id) => {
|
MentionUri::TextThread { .. } => {
|
||||||
|
write!(&mut thread_context, "\n{}\n", content).ok();
|
||||||
|
}
|
||||||
|
MentionUri::Rule { .. } => {
|
||||||
write!(
|
write!(
|
||||||
&mut rules_context,
|
&mut rules_context,
|
||||||
"\n{}",
|
"\n{}",
|
||||||
|
@ -147,9 +168,12 @@ impl UserMessage {
|
||||||
)
|
)
|
||||||
.ok();
|
.ok();
|
||||||
}
|
}
|
||||||
|
MentionUri::Fetch { url } => {
|
||||||
|
write!(&mut fetch_context, "\nFetch: {}\n\n{}", url, content).ok();
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
language_model::MessageContent::Text(uri.to_link())
|
language_model::MessageContent::Text(uri.as_link().to_string())
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
|
|
||||||
|
@ -179,6 +203,13 @@ impl UserMessage {
|
||||||
.push(language_model::MessageContent::Text(thread_context));
|
.push(language_model::MessageContent::Text(thread_context));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if fetch_context.len() > OPEN_FETCH_TAG.len() {
|
||||||
|
fetch_context.push_str("</fetched_urls>\n");
|
||||||
|
message
|
||||||
|
.content
|
||||||
|
.push(language_model::MessageContent::Text(fetch_context));
|
||||||
|
}
|
||||||
|
|
||||||
if rules_context.len() > OPEN_RULES_TAG.len() {
|
if rules_context.len() > OPEN_RULES_TAG.len() {
|
||||||
rules_context.push_str("</user_rules>\n");
|
rules_context.push_str("</user_rules>\n");
|
||||||
message
|
message
|
||||||
|
@ -200,6 +231,26 @@ impl UserMessage {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn codeblock_tag(full_path: &Path, line_range: Option<&Range<u32>>) -> String {
|
||||||
|
let mut result = String::new();
|
||||||
|
|
||||||
|
if let Some(extension) = full_path.extension().and_then(|ext| ext.to_str()) {
|
||||||
|
let _ = write!(result, "{} ", extension);
|
||||||
|
}
|
||||||
|
|
||||||
|
let _ = write!(result, "{}", full_path.display());
|
||||||
|
|
||||||
|
if let Some(range) = line_range {
|
||||||
|
if range.start == range.end {
|
||||||
|
let _ = write!(result, ":{}", range.start + 1);
|
||||||
|
} else {
|
||||||
|
let _ = write!(result, ":{}-{}", range.start + 1, range.end + 1);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
result
|
||||||
|
}
|
||||||
|
|
||||||
impl AgentMessage {
|
impl AgentMessage {
|
||||||
pub fn to_markdown(&self) -> String {
|
pub fn to_markdown(&self) -> String {
|
||||||
let mut markdown = String::from("## Assistant\n\n");
|
let mut markdown = String::from("## Assistant\n\n");
|
||||||
|
@ -1367,18 +1418,6 @@ impl std::ops::DerefMut for ToolCallEventStreamReceiver {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn codeblock_tag(full_path: &Path) -> String {
|
|
||||||
let mut result = String::new();
|
|
||||||
|
|
||||||
if let Some(extension) = full_path.extension().and_then(|ext| ext.to_str()) {
|
|
||||||
let _ = write!(result, "{} ", extension);
|
|
||||||
}
|
|
||||||
|
|
||||||
let _ = write!(result, "{}", full_path.display());
|
|
||||||
|
|
||||||
result
|
|
||||||
}
|
|
||||||
|
|
||||||
impl From<&str> for UserMessageContent {
|
impl From<&str> for UserMessageContent {
|
||||||
fn from(text: &str) -> Self {
|
fn from(text: &str) -> Self {
|
||||||
Self::Text(text.into())
|
Self::Text(text.into())
|
||||||
|
|
|
@ -93,6 +93,7 @@ time.workspace = true
|
||||||
time_format.workspace = true
|
time_format.workspace = true
|
||||||
ui.workspace = true
|
ui.workspace = true
|
||||||
ui_input.workspace = true
|
ui_input.workspace = true
|
||||||
|
url.workspace = true
|
||||||
urlencoding.workspace = true
|
urlencoding.workspace = true
|
||||||
util.workspace = true
|
util.workspace = true
|
||||||
uuid.workspace = true
|
uuid.workspace = true
|
||||||
|
@ -102,6 +103,8 @@ workspace.workspace = true
|
||||||
zed_actions.workspace = true
|
zed_actions.workspace = true
|
||||||
|
|
||||||
[dev-dependencies]
|
[dev-dependencies]
|
||||||
|
agent = { workspace = true, features = ["test-support"] }
|
||||||
|
assistant_context = { workspace = true, features = ["test-support"] }
|
||||||
assistant_tools.workspace = true
|
assistant_tools.workspace = true
|
||||||
buffer_diff = { workspace = true, features = ["test-support"] }
|
buffer_diff = { workspace = true, features = ["test-support"] }
|
||||||
editor = { workspace = true, features = ["test-support"] }
|
editor = { workspace = true, features = ["test-support"] }
|
||||||
|
|
File diff suppressed because it is too large
Load diff
|
@ -45,12 +45,8 @@ impl<T> MessageHistory<T> {
|
||||||
None
|
None
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
|
||||||
pub fn items(&self) -> &[T] {
|
|
||||||
&self.items
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
|
@ -4,15 +4,17 @@ use acp_thread::{
|
||||||
};
|
};
|
||||||
use acp_thread::{AgentConnection, Plan};
|
use acp_thread::{AgentConnection, Plan};
|
||||||
use action_log::ActionLog;
|
use action_log::ActionLog;
|
||||||
|
use agent::{TextThreadStore, ThreadStore};
|
||||||
use agent_client_protocol as acp;
|
use agent_client_protocol as acp;
|
||||||
use agent_servers::AgentServer;
|
use agent_servers::AgentServer;
|
||||||
use agent_settings::{AgentSettings, NotifyWhenAgentWaiting};
|
use agent_settings::{AgentSettings, NotifyWhenAgentWaiting};
|
||||||
use audio::{Audio, Sound};
|
use audio::{Audio, Sound};
|
||||||
use buffer_diff::BufferDiff;
|
use buffer_diff::BufferDiff;
|
||||||
use collections::{HashMap, HashSet};
|
use collections::{HashMap, HashSet};
|
||||||
|
use editor::scroll::Autoscroll;
|
||||||
use editor::{
|
use editor::{
|
||||||
AnchorRangeExt, ContextMenuOptions, ContextMenuPlacement, Editor, EditorElement, EditorMode,
|
AnchorRangeExt, ContextMenuOptions, ContextMenuPlacement, Editor, EditorElement, EditorMode,
|
||||||
EditorStyle, MinimapVisibility, MultiBuffer, PathKey,
|
EditorStyle, MinimapVisibility, MultiBuffer, PathKey, SelectionEffects,
|
||||||
};
|
};
|
||||||
use file_icons::FileIcons;
|
use file_icons::FileIcons;
|
||||||
use gpui::{
|
use gpui::{
|
||||||
|
@ -27,8 +29,10 @@ use language::{Buffer, Language};
|
||||||
use markdown::{HeadingLevelStyles, Markdown, MarkdownElement, MarkdownStyle};
|
use markdown::{HeadingLevelStyles, Markdown, MarkdownElement, MarkdownStyle};
|
||||||
use parking_lot::Mutex;
|
use parking_lot::Mutex;
|
||||||
use project::{CompletionIntent, Project};
|
use project::{CompletionIntent, Project};
|
||||||
|
use prompt_store::PromptId;
|
||||||
use rope::Point;
|
use rope::Point;
|
||||||
use settings::{Settings as _, SettingsStore};
|
use settings::{Settings as _, SettingsStore};
|
||||||
|
use std::fmt::Write as _;
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
use std::{
|
use std::{
|
||||||
cell::RefCell, collections::BTreeMap, path::Path, process::ExitStatus, rc::Rc, sync::Arc,
|
cell::RefCell, collections::BTreeMap, path::Path, process::ExitStatus, rc::Rc, sync::Arc,
|
||||||
|
@ -44,6 +48,7 @@ use ui::{
|
||||||
use util::{ResultExt, size::format_file_size, time::duration_alt_display};
|
use util::{ResultExt, size::format_file_size, time::duration_alt_display};
|
||||||
use workspace::{CollaboratorId, Workspace};
|
use workspace::{CollaboratorId, Workspace};
|
||||||
use zed_actions::agent::{Chat, NextHistoryMessage, PreviousHistoryMessage, ToggleModelSelector};
|
use zed_actions::agent::{Chat, NextHistoryMessage, PreviousHistoryMessage, ToggleModelSelector};
|
||||||
|
use zed_actions::assistant::OpenRulesLibrary;
|
||||||
|
|
||||||
use crate::acp::AcpModelSelectorPopover;
|
use crate::acp::AcpModelSelectorPopover;
|
||||||
use crate::acp::completion_provider::{ContextPickerCompletionProvider, MentionSet};
|
use crate::acp::completion_provider::{ContextPickerCompletionProvider, MentionSet};
|
||||||
|
@ -61,6 +66,8 @@ pub struct AcpThreadView {
|
||||||
agent: Rc<dyn AgentServer>,
|
agent: Rc<dyn AgentServer>,
|
||||||
workspace: WeakEntity<Workspace>,
|
workspace: WeakEntity<Workspace>,
|
||||||
project: Entity<Project>,
|
project: Entity<Project>,
|
||||||
|
thread_store: Entity<ThreadStore>,
|
||||||
|
text_thread_store: Entity<TextThreadStore>,
|
||||||
thread_state: ThreadState,
|
thread_state: ThreadState,
|
||||||
diff_editors: HashMap<EntityId, Entity<Editor>>,
|
diff_editors: HashMap<EntityId, Entity<Editor>>,
|
||||||
terminal_views: HashMap<EntityId, Entity<TerminalView>>,
|
terminal_views: HashMap<EntityId, Entity<TerminalView>>,
|
||||||
|
@ -108,6 +115,8 @@ impl AcpThreadView {
|
||||||
agent: Rc<dyn AgentServer>,
|
agent: Rc<dyn AgentServer>,
|
||||||
workspace: WeakEntity<Workspace>,
|
workspace: WeakEntity<Workspace>,
|
||||||
project: Entity<Project>,
|
project: Entity<Project>,
|
||||||
|
thread_store: Entity<ThreadStore>,
|
||||||
|
text_thread_store: Entity<TextThreadStore>,
|
||||||
message_history: Rc<RefCell<MessageHistory<Vec<acp::ContentBlock>>>>,
|
message_history: Rc<RefCell<MessageHistory<Vec<acp::ContentBlock>>>>,
|
||||||
min_lines: usize,
|
min_lines: usize,
|
||||||
max_lines: Option<usize>,
|
max_lines: Option<usize>,
|
||||||
|
@ -145,6 +154,8 @@ impl AcpThreadView {
|
||||||
editor.set_completion_provider(Some(Rc::new(ContextPickerCompletionProvider::new(
|
editor.set_completion_provider(Some(Rc::new(ContextPickerCompletionProvider::new(
|
||||||
mention_set.clone(),
|
mention_set.clone(),
|
||||||
workspace.clone(),
|
workspace.clone(),
|
||||||
|
thread_store.downgrade(),
|
||||||
|
text_thread_store.downgrade(),
|
||||||
cx.weak_entity(),
|
cx.weak_entity(),
|
||||||
))));
|
))));
|
||||||
editor.set_context_menu_options(ContextMenuOptions {
|
editor.set_context_menu_options(ContextMenuOptions {
|
||||||
|
@ -188,6 +199,8 @@ impl AcpThreadView {
|
||||||
agent: agent.clone(),
|
agent: agent.clone(),
|
||||||
workspace: workspace.clone(),
|
workspace: workspace.clone(),
|
||||||
project: project.clone(),
|
project: project.clone(),
|
||||||
|
thread_store,
|
||||||
|
text_thread_store,
|
||||||
thread_state: Self::initial_state(agent, workspace, project, window, cx),
|
thread_state: Self::initial_state(agent, workspace, project, window, cx),
|
||||||
message_editor,
|
message_editor,
|
||||||
model_selector: None,
|
model_selector: None,
|
||||||
|
@ -401,7 +414,13 @@ impl AcpThreadView {
|
||||||
let mut chunks: Vec<acp::ContentBlock> = Vec::new();
|
let mut chunks: Vec<acp::ContentBlock> = Vec::new();
|
||||||
let project = self.project.clone();
|
let project = self.project.clone();
|
||||||
|
|
||||||
let contents = self.mention_set.lock().contents(project, cx);
|
let thread_store = self.thread_store.clone();
|
||||||
|
let text_thread_store = self.text_thread_store.clone();
|
||||||
|
|
||||||
|
let contents =
|
||||||
|
self.mention_set
|
||||||
|
.lock()
|
||||||
|
.contents(project, thread_store, text_thread_store, window, cx);
|
||||||
|
|
||||||
cx.spawn_in(window, async move |this, cx| {
|
cx.spawn_in(window, async move |this, cx| {
|
||||||
let contents = match contents.await {
|
let contents = match contents.await {
|
||||||
|
@ -439,7 +458,7 @@ impl AcpThreadView {
|
||||||
acp::TextResourceContents {
|
acp::TextResourceContents {
|
||||||
mime_type: None,
|
mime_type: None,
|
||||||
text: mention.content.clone(),
|
text: mention.content.clone(),
|
||||||
uri: mention.uri.to_uri(),
|
uri: mention.uri.to_uri().to_string(),
|
||||||
},
|
},
|
||||||
),
|
),
|
||||||
}));
|
}));
|
||||||
|
@ -614,8 +633,7 @@ impl AcpThreadView {
|
||||||
let path = PathBuf::from(&resource.uri);
|
let path = PathBuf::from(&resource.uri);
|
||||||
let project_path = project.read(cx).project_path_for_absolute_path(&path, cx);
|
let project_path = project.read(cx).project_path_for_absolute_path(&path, cx);
|
||||||
let start = text.len();
|
let start = text.len();
|
||||||
let content = MentionUri::File(path).to_uri();
|
let _ = write!(&mut text, "{}", MentionUri::File(path).to_uri());
|
||||||
text.push_str(&content);
|
|
||||||
let end = text.len();
|
let end = text.len();
|
||||||
if let Some(project_path) = project_path {
|
if let Some(project_path) = project_path {
|
||||||
let filename: SharedString = project_path
|
let filename: SharedString = project_path
|
||||||
|
@ -663,7 +681,9 @@ impl AcpThreadView {
|
||||||
);
|
);
|
||||||
|
|
||||||
if let Some(crease_id) = crease_id {
|
if let Some(crease_id) = crease_id {
|
||||||
mention_set.lock().insert(crease_id, project_path);
|
mention_set
|
||||||
|
.lock()
|
||||||
|
.insert(crease_id, MentionUri::File(project_path));
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
@ -2698,9 +2718,72 @@ impl AcpThreadView {
|
||||||
.detach_and_log_err(cx);
|
.detach_and_log_err(cx);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
_ => {
|
MentionUri::Symbol {
|
||||||
// TODO
|
path, line_range, ..
|
||||||
unimplemented!()
|
}
|
||||||
|
| MentionUri::Selection { path, line_range } => {
|
||||||
|
let project = workspace.project();
|
||||||
|
let Some((path, _)) = project.update(cx, |project, cx| {
|
||||||
|
let path = project.find_project_path(path, cx)?;
|
||||||
|
let entry = project.entry_for_path(&path, cx)?;
|
||||||
|
Some((path, entry))
|
||||||
|
}) else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
|
||||||
|
let item = workspace.open_path(path, None, true, window, cx);
|
||||||
|
window
|
||||||
|
.spawn(cx, async move |cx| {
|
||||||
|
let Some(editor) = item.await?.downcast::<Editor>() else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
let range =
|
||||||
|
Point::new(line_range.start, 0)..Point::new(line_range.start, 0);
|
||||||
|
editor
|
||||||
|
.update_in(cx, |editor, window, cx| {
|
||||||
|
editor.change_selections(
|
||||||
|
SelectionEffects::scroll(Autoscroll::center()),
|
||||||
|
window,
|
||||||
|
cx,
|
||||||
|
|s| s.select_ranges(vec![range]),
|
||||||
|
);
|
||||||
|
})
|
||||||
|
.ok();
|
||||||
|
anyhow::Ok(())
|
||||||
|
})
|
||||||
|
.detach_and_log_err(cx);
|
||||||
|
}
|
||||||
|
MentionUri::Thread { id, .. } => {
|
||||||
|
if let Some(panel) = workspace.panel::<AgentPanel>(cx) {
|
||||||
|
panel.update(cx, |panel, cx| {
|
||||||
|
panel
|
||||||
|
.open_thread_by_id(&id, window, cx)
|
||||||
|
.detach_and_log_err(cx)
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
MentionUri::TextThread { path, .. } => {
|
||||||
|
if let Some(panel) = workspace.panel::<AgentPanel>(cx) {
|
||||||
|
panel.update(cx, |panel, cx| {
|
||||||
|
panel
|
||||||
|
.open_saved_prompt_editor(path.as_path().into(), window, cx)
|
||||||
|
.detach_and_log_err(cx);
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
MentionUri::Rule { id, .. } => {
|
||||||
|
let PromptId::User { uuid } = id else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
window.dispatch_action(
|
||||||
|
Box::new(OpenRulesLibrary {
|
||||||
|
prompt_to_select: Some(uuid.0),
|
||||||
|
}),
|
||||||
|
cx,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
MentionUri::Fetch { url } => {
|
||||||
|
cx.open_url(url.as_str());
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
} else {
|
} else {
|
||||||
|
@ -3090,7 +3173,7 @@ impl AcpThreadView {
|
||||||
.unwrap_or(path.path.as_os_str())
|
.unwrap_or(path.path.as_os_str())
|
||||||
.display()
|
.display()
|
||||||
.to_string();
|
.to_string();
|
||||||
let completion = ContextPickerCompletionProvider::completion_for_path(
|
let Some(completion) = ContextPickerCompletionProvider::completion_for_path(
|
||||||
path,
|
path,
|
||||||
&path_prefix,
|
&path_prefix,
|
||||||
false,
|
false,
|
||||||
|
@ -3101,7 +3184,9 @@ impl AcpThreadView {
|
||||||
self.mention_set.clone(),
|
self.mention_set.clone(),
|
||||||
self.project.clone(),
|
self.project.clone(),
|
||||||
cx,
|
cx,
|
||||||
);
|
) else {
|
||||||
|
continue;
|
||||||
|
};
|
||||||
|
|
||||||
self.message_editor.update(cx, |message_editor, cx| {
|
self.message_editor.update(cx, |message_editor, cx| {
|
||||||
message_editor.edit(
|
message_editor.edit(
|
||||||
|
@ -3431,17 +3516,14 @@ fn terminal_command_markdown_style(window: &Window, cx: &App) -> MarkdownStyle {
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
|
use agent::{TextThreadStore, ThreadStore};
|
||||||
use agent_client_protocol::SessionId;
|
use agent_client_protocol::SessionId;
|
||||||
use editor::EditorSettings;
|
use editor::EditorSettings;
|
||||||
use fs::FakeFs;
|
use fs::FakeFs;
|
||||||
use futures::future::try_join_all;
|
use futures::future::try_join_all;
|
||||||
use gpui::{SemanticVersion, TestAppContext, VisualTestContext};
|
use gpui::{SemanticVersion, TestAppContext, VisualTestContext};
|
||||||
use lsp::{CompletionContext, CompletionTriggerKind};
|
|
||||||
use project::CompletionIntent;
|
|
||||||
use rand::Rng;
|
use rand::Rng;
|
||||||
use serde_json::json;
|
|
||||||
use settings::SettingsStore;
|
use settings::SettingsStore;
|
||||||
use util::path;
|
|
||||||
|
|
||||||
use super::*;
|
use super::*;
|
||||||
|
|
||||||
|
@ -3554,109 +3636,6 @@ mod tests {
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[gpui::test]
|
|
||||||
async fn test_crease_removal(cx: &mut TestAppContext) {
|
|
||||||
init_test(cx);
|
|
||||||
|
|
||||||
let fs = FakeFs::new(cx.executor());
|
|
||||||
fs.insert_tree("/project", json!({"file": ""})).await;
|
|
||||||
let project = Project::test(fs, [Path::new(path!("/project"))], cx).await;
|
|
||||||
let agent = StubAgentServer::default();
|
|
||||||
let (workspace, cx) =
|
|
||||||
cx.add_window_view(|window, cx| Workspace::test_new(project.clone(), window, cx));
|
|
||||||
let thread_view = cx.update(|window, cx| {
|
|
||||||
cx.new(|cx| {
|
|
||||||
AcpThreadView::new(
|
|
||||||
Rc::new(agent),
|
|
||||||
workspace.downgrade(),
|
|
||||||
project,
|
|
||||||
Rc::new(RefCell::new(MessageHistory::default())),
|
|
||||||
1,
|
|
||||||
None,
|
|
||||||
window,
|
|
||||||
cx,
|
|
||||||
)
|
|
||||||
})
|
|
||||||
});
|
|
||||||
|
|
||||||
cx.run_until_parked();
|
|
||||||
|
|
||||||
let message_editor = cx.read(|cx| thread_view.read(cx).message_editor.clone());
|
|
||||||
let excerpt_id = message_editor.update(cx, |editor, cx| {
|
|
||||||
editor
|
|
||||||
.buffer()
|
|
||||||
.read(cx)
|
|
||||||
.excerpt_ids()
|
|
||||||
.into_iter()
|
|
||||||
.next()
|
|
||||||
.unwrap()
|
|
||||||
});
|
|
||||||
let completions = message_editor.update_in(cx, |editor, window, cx| {
|
|
||||||
editor.set_text("Hello @", window, cx);
|
|
||||||
let buffer = editor.buffer().read(cx).as_singleton().unwrap();
|
|
||||||
let completion_provider = editor.completion_provider().unwrap();
|
|
||||||
completion_provider.completions(
|
|
||||||
excerpt_id,
|
|
||||||
&buffer,
|
|
||||||
Anchor::MAX,
|
|
||||||
CompletionContext {
|
|
||||||
trigger_kind: CompletionTriggerKind::TRIGGER_CHARACTER,
|
|
||||||
trigger_character: Some("@".into()),
|
|
||||||
},
|
|
||||||
window,
|
|
||||||
cx,
|
|
||||||
)
|
|
||||||
});
|
|
||||||
let [_, completion]: [_; 2] = completions
|
|
||||||
.await
|
|
||||||
.unwrap()
|
|
||||||
.into_iter()
|
|
||||||
.flat_map(|response| response.completions)
|
|
||||||
.collect::<Vec<_>>()
|
|
||||||
.try_into()
|
|
||||||
.unwrap();
|
|
||||||
|
|
||||||
message_editor.update_in(cx, |editor, window, cx| {
|
|
||||||
let snapshot = editor.buffer().read(cx).snapshot(cx);
|
|
||||||
let start = snapshot
|
|
||||||
.anchor_in_excerpt(excerpt_id, completion.replace_range.start)
|
|
||||||
.unwrap();
|
|
||||||
let end = snapshot
|
|
||||||
.anchor_in_excerpt(excerpt_id, completion.replace_range.end)
|
|
||||||
.unwrap();
|
|
||||||
editor.edit([(start..end, completion.new_text)], cx);
|
|
||||||
(completion.confirm.unwrap())(CompletionIntent::Complete, window, cx);
|
|
||||||
});
|
|
||||||
|
|
||||||
cx.run_until_parked();
|
|
||||||
|
|
||||||
// Backspace over the inserted crease (and the following space).
|
|
||||||
message_editor.update_in(cx, |editor, window, cx| {
|
|
||||||
editor.backspace(&Default::default(), window, cx);
|
|
||||||
editor.backspace(&Default::default(), window, cx);
|
|
||||||
});
|
|
||||||
|
|
||||||
thread_view.update_in(cx, |thread_view, window, cx| {
|
|
||||||
thread_view.chat(&Chat, window, cx);
|
|
||||||
});
|
|
||||||
|
|
||||||
cx.run_until_parked();
|
|
||||||
|
|
||||||
let content = thread_view.update_in(cx, |thread_view, _window, _cx| {
|
|
||||||
thread_view
|
|
||||||
.message_history
|
|
||||||
.borrow()
|
|
||||||
.items()
|
|
||||||
.iter()
|
|
||||||
.flatten()
|
|
||||||
.cloned()
|
|
||||||
.collect::<Vec<_>>()
|
|
||||||
});
|
|
||||||
|
|
||||||
// We don't send a resource link for the deleted crease.
|
|
||||||
pretty_assertions::assert_matches!(content.as_slice(), [acp::ContentBlock::Text { .. }]);
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn setup_thread_view(
|
async fn setup_thread_view(
|
||||||
agent: impl AgentServer + 'static,
|
agent: impl AgentServer + 'static,
|
||||||
cx: &mut TestAppContext,
|
cx: &mut TestAppContext,
|
||||||
|
@ -3666,12 +3645,19 @@ mod tests {
|
||||||
let (workspace, cx) =
|
let (workspace, cx) =
|
||||||
cx.add_window_view(|window, cx| Workspace::test_new(project.clone(), window, cx));
|
cx.add_window_view(|window, cx| Workspace::test_new(project.clone(), window, cx));
|
||||||
|
|
||||||
|
let thread_store =
|
||||||
|
cx.update(|_window, cx| cx.new(|cx| ThreadStore::fake(project.clone(), cx)));
|
||||||
|
let text_thread_store =
|
||||||
|
cx.update(|_window, cx| cx.new(|cx| TextThreadStore::fake(project.clone(), cx)));
|
||||||
|
|
||||||
let thread_view = cx.update(|window, cx| {
|
let thread_view = cx.update(|window, cx| {
|
||||||
cx.new(|cx| {
|
cx.new(|cx| {
|
||||||
AcpThreadView::new(
|
AcpThreadView::new(
|
||||||
Rc::new(agent),
|
Rc::new(agent),
|
||||||
workspace.downgrade(),
|
workspace.downgrade(),
|
||||||
project,
|
project,
|
||||||
|
thread_store.clone(),
|
||||||
|
text_thread_store.clone(),
|
||||||
Rc::new(RefCell::new(MessageHistory::default())),
|
Rc::new(RefCell::new(MessageHistory::default())),
|
||||||
1,
|
1,
|
||||||
None,
|
None,
|
||||||
|
|
|
@ -973,6 +973,9 @@ impl AgentPanel {
|
||||||
agent: crate::ExternalAgent,
|
agent: crate::ExternalAgent,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
let thread_store = self.thread_store.clone();
|
||||||
|
let text_thread_store = self.context_store.clone();
|
||||||
|
|
||||||
cx.spawn_in(window, async move |this, cx| {
|
cx.spawn_in(window, async move |this, cx| {
|
||||||
let server: Rc<dyn AgentServer> = match agent_choice {
|
let server: Rc<dyn AgentServer> = match agent_choice {
|
||||||
Some(agent) => {
|
Some(agent) => {
|
||||||
|
@ -1011,6 +1014,8 @@ impl AgentPanel {
|
||||||
server,
|
server,
|
||||||
workspace.clone(),
|
workspace.clone(),
|
||||||
project,
|
project,
|
||||||
|
thread_store.clone(),
|
||||||
|
text_thread_store.clone(),
|
||||||
message_history,
|
message_history,
|
||||||
MIN_EDITOR_LINES,
|
MIN_EDITOR_LINES,
|
||||||
Some(MAX_EDITOR_LINES),
|
Some(MAX_EDITOR_LINES),
|
||||||
|
|
|
@ -1,15 +1,16 @@
|
||||||
mod completion_provider;
|
mod completion_provider;
|
||||||
mod fetch_context_picker;
|
pub(crate) mod fetch_context_picker;
|
||||||
pub(crate) mod file_context_picker;
|
pub(crate) mod file_context_picker;
|
||||||
mod rules_context_picker;
|
pub(crate) mod rules_context_picker;
|
||||||
mod symbol_context_picker;
|
pub(crate) mod symbol_context_picker;
|
||||||
mod thread_context_picker;
|
pub(crate) mod thread_context_picker;
|
||||||
|
|
||||||
use std::ops::Range;
|
use std::ops::Range;
|
||||||
use std::path::{Path, PathBuf};
|
use std::path::{Path, PathBuf};
|
||||||
use std::sync::Arc;
|
use std::sync::Arc;
|
||||||
|
|
||||||
use anyhow::{Result, anyhow};
|
use anyhow::{Result, anyhow};
|
||||||
|
use collections::HashSet;
|
||||||
pub use completion_provider::ContextPickerCompletionProvider;
|
pub use completion_provider::ContextPickerCompletionProvider;
|
||||||
use editor::display_map::{Crease, CreaseId, CreaseMetadata, FoldId};
|
use editor::display_map::{Crease, CreaseId, CreaseMetadata, FoldId};
|
||||||
use editor::{Anchor, AnchorRangeExt as _, Editor, ExcerptId, FoldPlaceholder, ToOffset};
|
use editor::{Anchor, AnchorRangeExt as _, Editor, ExcerptId, FoldPlaceholder, ToOffset};
|
||||||
|
@ -45,7 +46,7 @@ use agent::{
|
||||||
};
|
};
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
enum ContextPickerEntry {
|
pub(crate) enum ContextPickerEntry {
|
||||||
Mode(ContextPickerMode),
|
Mode(ContextPickerMode),
|
||||||
Action(ContextPickerAction),
|
Action(ContextPickerAction),
|
||||||
}
|
}
|
||||||
|
@ -74,7 +75,7 @@ impl ContextPickerEntry {
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
enum ContextPickerMode {
|
pub(crate) enum ContextPickerMode {
|
||||||
File,
|
File,
|
||||||
Symbol,
|
Symbol,
|
||||||
Fetch,
|
Fetch,
|
||||||
|
@ -83,7 +84,7 @@ enum ContextPickerMode {
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
enum ContextPickerAction {
|
pub(crate) enum ContextPickerAction {
|
||||||
AddSelections,
|
AddSelections,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -531,7 +532,7 @@ impl ContextPicker {
|
||||||
return vec![];
|
return vec![];
|
||||||
};
|
};
|
||||||
|
|
||||||
recent_context_picker_entries(
|
recent_context_picker_entries_with_store(
|
||||||
context_store,
|
context_store,
|
||||||
self.thread_store.clone(),
|
self.thread_store.clone(),
|
||||||
self.text_thread_store.clone(),
|
self.text_thread_store.clone(),
|
||||||
|
@ -585,7 +586,8 @@ impl Render for ContextPicker {
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
enum RecentEntry {
|
|
||||||
|
pub(crate) enum RecentEntry {
|
||||||
File {
|
File {
|
||||||
project_path: ProjectPath,
|
project_path: ProjectPath,
|
||||||
path_prefix: Arc<str>,
|
path_prefix: Arc<str>,
|
||||||
|
@ -593,7 +595,7 @@ enum RecentEntry {
|
||||||
Thread(ThreadContextEntry),
|
Thread(ThreadContextEntry),
|
||||||
}
|
}
|
||||||
|
|
||||||
fn available_context_picker_entries(
|
pub(crate) fn available_context_picker_entries(
|
||||||
prompt_store: &Option<Entity<PromptStore>>,
|
prompt_store: &Option<Entity<PromptStore>>,
|
||||||
thread_store: &Option<WeakEntity<ThreadStore>>,
|
thread_store: &Option<WeakEntity<ThreadStore>>,
|
||||||
workspace: &Entity<Workspace>,
|
workspace: &Entity<Workspace>,
|
||||||
|
@ -630,24 +632,56 @@ fn available_context_picker_entries(
|
||||||
entries
|
entries
|
||||||
}
|
}
|
||||||
|
|
||||||
fn recent_context_picker_entries(
|
fn recent_context_picker_entries_with_store(
|
||||||
context_store: Entity<ContextStore>,
|
context_store: Entity<ContextStore>,
|
||||||
thread_store: Option<WeakEntity<ThreadStore>>,
|
thread_store: Option<WeakEntity<ThreadStore>>,
|
||||||
text_thread_store: Option<WeakEntity<TextThreadStore>>,
|
text_thread_store: Option<WeakEntity<TextThreadStore>>,
|
||||||
workspace: Entity<Workspace>,
|
workspace: Entity<Workspace>,
|
||||||
exclude_path: Option<ProjectPath>,
|
exclude_path: Option<ProjectPath>,
|
||||||
cx: &App,
|
cx: &App,
|
||||||
|
) -> Vec<RecentEntry> {
|
||||||
|
let project = workspace.read(cx).project();
|
||||||
|
|
||||||
|
let mut exclude_paths = context_store.read(cx).file_paths(cx);
|
||||||
|
exclude_paths.extend(exclude_path);
|
||||||
|
|
||||||
|
let exclude_paths = exclude_paths
|
||||||
|
.into_iter()
|
||||||
|
.filter_map(|project_path| project.read(cx).absolute_path(&project_path, cx))
|
||||||
|
.collect();
|
||||||
|
|
||||||
|
let exclude_threads = context_store.read(cx).thread_ids();
|
||||||
|
|
||||||
|
recent_context_picker_entries(
|
||||||
|
thread_store,
|
||||||
|
text_thread_store,
|
||||||
|
workspace,
|
||||||
|
&exclude_paths,
|
||||||
|
exclude_threads,
|
||||||
|
cx,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
pub(crate) fn recent_context_picker_entries(
|
||||||
|
thread_store: Option<WeakEntity<ThreadStore>>,
|
||||||
|
text_thread_store: Option<WeakEntity<TextThreadStore>>,
|
||||||
|
workspace: Entity<Workspace>,
|
||||||
|
exclude_paths: &HashSet<PathBuf>,
|
||||||
|
exclude_threads: &HashSet<ThreadId>,
|
||||||
|
cx: &App,
|
||||||
) -> Vec<RecentEntry> {
|
) -> Vec<RecentEntry> {
|
||||||
let mut recent = Vec::with_capacity(6);
|
let mut recent = Vec::with_capacity(6);
|
||||||
let mut current_files = context_store.read(cx).file_paths(cx);
|
|
||||||
current_files.extend(exclude_path);
|
|
||||||
let workspace = workspace.read(cx);
|
let workspace = workspace.read(cx);
|
||||||
let project = workspace.project().read(cx);
|
let project = workspace.project().read(cx);
|
||||||
|
|
||||||
recent.extend(
|
recent.extend(
|
||||||
workspace
|
workspace
|
||||||
.recent_navigation_history_iter(cx)
|
.recent_navigation_history_iter(cx)
|
||||||
.filter(|(path, _)| !current_files.contains(path))
|
.filter(|(_, abs_path)| {
|
||||||
|
abs_path
|
||||||
|
.as_ref()
|
||||||
|
.map_or(true, |path| !exclude_paths.contains(path.as_path()))
|
||||||
|
})
|
||||||
.take(4)
|
.take(4)
|
||||||
.filter_map(|(project_path, _)| {
|
.filter_map(|(project_path, _)| {
|
||||||
project
|
project
|
||||||
|
@ -659,8 +693,6 @@ fn recent_context_picker_entries(
|
||||||
}),
|
}),
|
||||||
);
|
);
|
||||||
|
|
||||||
let current_threads = context_store.read(cx).thread_ids();
|
|
||||||
|
|
||||||
let active_thread_id = workspace
|
let active_thread_id = workspace
|
||||||
.panel::<AgentPanel>(cx)
|
.panel::<AgentPanel>(cx)
|
||||||
.and_then(|panel| Some(panel.read(cx).active_thread(cx)?.read(cx).id()));
|
.and_then(|panel| Some(panel.read(cx).active_thread(cx)?.read(cx).id()));
|
||||||
|
@ -672,7 +704,7 @@ fn recent_context_picker_entries(
|
||||||
let mut threads = unordered_thread_entries(thread_store, text_thread_store, cx)
|
let mut threads = unordered_thread_entries(thread_store, text_thread_store, cx)
|
||||||
.filter(|(_, thread)| match thread {
|
.filter(|(_, thread)| match thread {
|
||||||
ThreadContextEntry::Thread { id, .. } => {
|
ThreadContextEntry::Thread { id, .. } => {
|
||||||
Some(id) != active_thread_id && !current_threads.contains(id)
|
Some(id) != active_thread_id && !exclude_threads.contains(id)
|
||||||
}
|
}
|
||||||
ThreadContextEntry::Context { .. } => true,
|
ThreadContextEntry::Context { .. } => true,
|
||||||
})
|
})
|
||||||
|
@ -710,7 +742,7 @@ fn add_selections_as_context(
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
fn selection_ranges(
|
pub(crate) fn selection_ranges(
|
||||||
workspace: &Entity<Workspace>,
|
workspace: &Entity<Workspace>,
|
||||||
cx: &mut App,
|
cx: &mut App,
|
||||||
) -> Vec<(Entity<Buffer>, Range<text::Anchor>)> {
|
) -> Vec<(Entity<Buffer>, Range<text::Anchor>)> {
|
||||||
|
|
|
@ -35,7 +35,7 @@ use super::symbol_context_picker::search_symbols;
|
||||||
use super::thread_context_picker::{ThreadContextEntry, ThreadMatch, search_threads};
|
use super::thread_context_picker::{ThreadContextEntry, ThreadMatch, search_threads};
|
||||||
use super::{
|
use super::{
|
||||||
ContextPickerAction, ContextPickerEntry, ContextPickerMode, MentionLink, RecentEntry,
|
ContextPickerAction, ContextPickerEntry, ContextPickerMode, MentionLink, RecentEntry,
|
||||||
available_context_picker_entries, recent_context_picker_entries, selection_ranges,
|
available_context_picker_entries, recent_context_picker_entries_with_store, selection_ranges,
|
||||||
};
|
};
|
||||||
use crate::message_editor::ContextCreasesAddon;
|
use crate::message_editor::ContextCreasesAddon;
|
||||||
|
|
||||||
|
@ -787,7 +787,7 @@ impl CompletionProvider for ContextPickerCompletionProvider {
|
||||||
.and_then(|b| b.read(cx).file())
|
.and_then(|b| b.read(cx).file())
|
||||||
.map(|file| ProjectPath::from_file(file.as_ref(), cx));
|
.map(|file| ProjectPath::from_file(file.as_ref(), cx));
|
||||||
|
|
||||||
let recent_entries = recent_context_picker_entries(
|
let recent_entries = recent_context_picker_entries_with_store(
|
||||||
context_store.clone(),
|
context_store.clone(),
|
||||||
thread_store.clone(),
|
thread_store.clone(),
|
||||||
text_thread_store.clone(),
|
text_thread_store.clone(),
|
||||||
|
|
|
@ -11,6 +11,9 @@ workspace = true
|
||||||
[lib]
|
[lib]
|
||||||
path = "src/assistant_context.rs"
|
path = "src/assistant_context.rs"
|
||||||
|
|
||||||
|
[features]
|
||||||
|
test-support = []
|
||||||
|
|
||||||
[dependencies]
|
[dependencies]
|
||||||
agent_settings.workspace = true
|
agent_settings.workspace = true
|
||||||
anyhow.workspace = true
|
anyhow.workspace = true
|
||||||
|
|
|
@ -138,6 +138,27 @@ impl ContextStore {
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(any(test, feature = "test-support"))]
|
||||||
|
pub fn fake(project: Entity<Project>, cx: &mut Context<Self>) -> Self {
|
||||||
|
Self {
|
||||||
|
contexts: Default::default(),
|
||||||
|
contexts_metadata: Default::default(),
|
||||||
|
context_server_slash_command_ids: Default::default(),
|
||||||
|
host_contexts: Default::default(),
|
||||||
|
fs: project.read(cx).fs().clone(),
|
||||||
|
languages: project.read(cx).languages().clone(),
|
||||||
|
slash_commands: Arc::default(),
|
||||||
|
telemetry: project.read(cx).client().telemetry().clone(),
|
||||||
|
_watch_updates: Task::ready(None),
|
||||||
|
client: project.read(cx).client(),
|
||||||
|
project,
|
||||||
|
project_is_shared: false,
|
||||||
|
client_subscription: None,
|
||||||
|
_project_subscriptions: Default::default(),
|
||||||
|
prompt_builder: Arc::new(PromptBuilder::new(None).unwrap()),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
async fn handle_advertise_contexts(
|
async fn handle_advertise_contexts(
|
||||||
this: Entity<Self>,
|
this: Entity<Self>,
|
||||||
envelope: TypedEnvelope<proto::AdvertiseContexts>,
|
envelope: TypedEnvelope<proto::AdvertiseContexts>,
|
||||||
|
|
|
@ -12176,6 +12176,8 @@ impl Editor {
|
||||||
let clipboard_text = Cow::Borrowed(text);
|
let clipboard_text = Cow::Borrowed(text);
|
||||||
|
|
||||||
self.transact(window, cx, |this, window, cx| {
|
self.transact(window, cx, |this, window, cx| {
|
||||||
|
let had_active_edit_prediction = this.has_active_edit_prediction();
|
||||||
|
|
||||||
if let Some(mut clipboard_selections) = clipboard_selections {
|
if let Some(mut clipboard_selections) = clipboard_selections {
|
||||||
let old_selections = this.selections.all::<usize>(cx);
|
let old_selections = this.selections.all::<usize>(cx);
|
||||||
let all_selections_were_entire_line =
|
let all_selections_were_entire_line =
|
||||||
|
@ -12248,6 +12250,11 @@ impl Editor {
|
||||||
} else {
|
} else {
|
||||||
this.insert(&clipboard_text, window, cx);
|
this.insert(&clipboard_text, window, cx);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
let trigger_in_words =
|
||||||
|
this.show_edit_predictions_in_menu() || !had_active_edit_prediction;
|
||||||
|
|
||||||
|
this.trigger_completion_on_input(&text, trigger_in_words, window, cx);
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -90,6 +90,15 @@ impl From<Uuid> for UserPromptId {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl std::fmt::Display for PromptId {
|
||||||
|
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
|
||||||
|
match self {
|
||||||
|
PromptId::User { uuid } => write!(f, "{}", uuid.0),
|
||||||
|
PromptId::EditWorkflow => write!(f, "Edit workflow"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
pub struct PromptStore {
|
pub struct PromptStore {
|
||||||
env: heed::Env,
|
env: heed::Env,
|
||||||
metadata_cache: RwLock<MetadataCache>,
|
metadata_cache: RwLock<MetadataCache>,
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue