diff --git a/crates/editor/src/editor.rs b/crates/editor/src/editor.rs index 90f152fc9b..a0e1ac8c3d 100644 --- a/crates/editor/src/editor.rs +++ b/crates/editor/src/editor.rs @@ -6233,7 +6233,7 @@ mod tests { platform::{WindowBounds, WindowOptions}, }; use indoc::indoc; - use language::{FakeLspAdapter, FakeLspAdapterInner, LanguageConfig}; + use language::{FakeLspAdapterInner, LanguageConfig}; use lsp::FakeLanguageServer; use project::FakeFs; use settings::LanguageSettings; diff --git a/crates/editor/src/test.rs b/crates/editor/src/test.rs index a2efc87249..0b1190e7c8 100644 --- a/crates/editor/src/test.rs +++ b/crates/editor/src/test.rs @@ -9,9 +9,7 @@ use indoc::indoc; use collections::BTreeMap; use gpui::{json, keymap::Keystroke, AppContext, ModelHandle, ViewContext, ViewHandle}; -use language::{ - point_to_lsp, FakeLspAdapter, FakeLspAdapterInner, Language, LanguageConfig, Selection, -}; +use language::{point_to_lsp, FakeLspAdapterInner, Language, LanguageConfig, Selection}; use project::Project; use settings::Settings; use util::{ diff --git a/crates/project/src/project.rs b/crates/project/src/project.rs index 7d75da4443..9f020e240b 100644 --- a/crates/project/src/project.rs +++ b/crates/project/src/project.rs @@ -1771,13 +1771,11 @@ impl Project { ))?, } cx.subscribe(buffer, |this, buffer, event, cx| { - // TODO(isaac): should this be done in the background? this.on_buffer_event(buffer, event, cx); }) .detach(); self.assign_language_to_buffer(buffer, cx); - // TODO(isaac): should this be done in the background self.register_buffer_with_language_server(buffer, cx); cx.observe_release(buffer, |this, buffer, cx| { if let Some(file) = File::from_dyn(buffer.file()) { @@ -2091,9 +2089,10 @@ impl Project { move |params, mut cx| { if let Some(this) = this.upgrade(&cx) { this.update(&mut cx, |this, cx| { - this.on_lsp_diagnostics_published( + // TODO(isaac): remove block on + smol::block_on(this.on_lsp_diagnostics_published( server_id, params, &adapter, cx, - ) + )) }); } } diff --git a/crates/zed/src/languages/json.rs b/crates/zed/src/languages/json.rs index 28294d26e1..ab6f03a06f 100644 --- a/crates/zed/src/languages/json.rs +++ b/crates/zed/src/languages/json.rs @@ -3,7 +3,7 @@ use anyhow::{anyhow, Context, Result}; use async_trait::async_trait; use client::http::HttpClient; use futures::StreamExt; -use language::{LanguageServerName, LspAdapter, LspAdapterTrait}; +use language::{LanguageServerName, LspAdapterTrait}; use serde_json::json; use smol::fs; use std::{any::Any, path::PathBuf, sync::Arc}; diff --git a/crates/zed/src/languages/language_plugin.rs b/crates/zed/src/languages/language_plugin.rs index 4dfe7478ab..6c07fc7042 100644 --- a/crates/zed/src/languages/language_plugin.rs +++ b/crates/zed/src/languages/language_plugin.rs @@ -2,9 +2,8 @@ use anyhow::{anyhow, Result}; use async_trait::async_trait; use client::http::HttpClient; use futures::lock::Mutex; -use futures::Future; use gpui::executor::Background; -use language::{LanguageServerName, LspAdapter, LspAdapterTrait}; +use language::{LanguageServerName, LspAdapterTrait}; use plugin_runtime::{Plugin, PluginBuilder, WasiFn}; use std::{any::Any, path::PathBuf, sync::Arc}; use util::ResultExt; @@ -55,10 +54,10 @@ impl PluginLspAdapter { } } -struct Versions { - language_version: String, - server_version: String, -} +// struct Versions { +// language_version: String, +// server_version: String, +// } // TODO: is this the root cause? // sketch: diff --git a/crates/zed/src/languages/python.rs b/crates/zed/src/languages/python.rs index c5508ac337..00b8ec8e08 100644 --- a/crates/zed/src/languages/python.rs +++ b/crates/zed/src/languages/python.rs @@ -3,7 +3,7 @@ use anyhow::{anyhow, Context, Result}; use async_trait::async_trait; use client::http::HttpClient; use futures::StreamExt; -use language::{LanguageServerName, LspAdapter, LspAdapterTrait}; +use language::{LanguageServerName, LspAdapterTrait}; use smol::fs; use std::{any::Any, path::PathBuf, sync::Arc}; use util::ResultExt; diff --git a/crates/zed/src/languages/typescript.rs b/crates/zed/src/languages/typescript.rs index 8f262d4e70..786e00f248 100644 --- a/crates/zed/src/languages/typescript.rs +++ b/crates/zed/src/languages/typescript.rs @@ -3,7 +3,7 @@ use anyhow::{anyhow, Context, Result}; use async_trait::async_trait; use client::http::HttpClient; use futures::StreamExt; -use language::{LanguageServerName, LspAdapter, LspAdapterTrait}; +use language::{LanguageServerName, LspAdapterTrait}; use serde_json::json; use smol::fs; use std::{any::Any, path::PathBuf, sync::Arc};