Yehowshua/ZIm
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix infinite loop in dock position when deserializing

Browse source
This commit is contained in:
Mikayla Maki 2022-12-09 11:49:17 -08:00
parent 0366d725ea
commit 3a4f8d267a
3 changed files with 79 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

9
crates/workspace/src/workspace.rs
View file

@ -2371,7 +2371,12 @@ impl Workspace {
workspace.toggle_sidebar(SidebarSide::Left, cx);
}
// Dock::set_dock_position(workspace, serialized_workspace.dock_position, cx);
// Note that without after_window, the focus_self() and
// the focus the dock generates start generating alternating
// focus due to the deferred execution each triggering each other
cx.after_window_update(move |workspace, cx| {
Dock::set_dock_position(workspace, serialized_workspace.dock_position, cx);
});
cx.notify();
});
@ -2695,7 +2700,7 @@ mod tests {
_workspace: &mut Workspace,
_cx: &mut ViewContext<Workspace>,
) -> Option<Box<dyn ItemHandle>> {
unimplemented!();
unimplemented!()
}
#[gpui::test]