Start diagnostic group_id at 1 to handle non LS diagnostics (#22694)
In particular, `DiagnosticPopover` both: * Supports moving the selection to a diagnostic when clicked, based on `group_id` * Provides Diagnostic values with `group_id: 0` providing informztion on hover about invisible characters. So, clicking such a popover would navigate to the very first error produced by a language server. Really not a big deal of course, but seems good to fix as it might result in surprising behavior in other future circumstances Release Notes: - N/A
This commit is contained in:
parent
7506c0385b
commit
3ae6aa0e4d
5 changed files with 74 additions and 74 deletions
|
@ -2960,7 +2960,7 @@ impl LspStore {
|
|||
http_client,
|
||||
fs,
|
||||
yarn,
|
||||
next_diagnostic_group_id: Default::default(),
|
||||
next_diagnostic_group_id: 1,
|
||||
diagnostics: Default::default(),
|
||||
_subscription: cx.on_app_quit(|this, cx| {
|
||||
this.as_local_mut().unwrap().shutdown_language_servers(cx)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue