debugger: Remove feature flag (#32877)

Release Notes:

- debugger: Now available for everyone!

Cargo.lock

@@ -4278,7 +4278,6 @@ dependencies = [
  "db",
  "debugger_tools",
  "editor",
- "feature_flags",
  "file_icons",
  "futures 0.3.31",
  "fuzzy",
@@ -4746,7 +4745,6 @@ dependencies = [
  "dap",
  "db",
  "emojis",
- "feature_flags",
  "file_icons",
  "fs",
  "futures 0.3.31",
@@ -19994,7 +19992,6 @@ dependencies = [
  "extension",
  "extension_host",
  "extensions_ui",
- "feature_flags",
  "feedback",
  "file_finder",
  "fs",

crates/debugger_ui/Cargo.toml

@@ -35,7 +35,6 @@ dap.workspace = true
 dap_adapters = { workspace = true, optional = true }
 db.workspace = true
 editor.workspace = true
-feature_flags.workspace = true
 file_icons.workspace = true
 futures.workspace = true
 fuzzy.workspace = true

crates/debugger_ui/src/debugger_ui.rs

@@ -3,7 +3,6 @@ use std::any::TypeId;
 use dap::debugger_settings::DebuggerSettings;
 use debugger_panel::{DebugPanel, ToggleFocus};
 use editor::Editor;
-use feature_flags::{DebuggerFeatureFlag, FeatureFlagViewExt};
 use gpui::{App, DispatchPhase, EntityInputHandler, actions};
 use new_process_modal::{NewProcessModal, NewProcessMode};
 use project::debugger::{self, breakpoint_store::SourceBreakpoint, session::ThreadStatus};
@@ -62,12 +61,7 @@ pub fn init(cx: &mut App) {
     DebuggerSettings::register(cx);
     workspace::FollowableViewRegistry::register::<DebugSession>(cx);
 
-    cx.observe_new(|_: &mut Workspace, window, cx| {
+    cx.observe_new(|workspace: &mut Workspace, _, _| {
-        let Some(window) = window else {
-            return;
-        };
-
-        cx.when_flag_enabled::<DebuggerFeatureFlag>(window, |workspace, _, _| {
         workspace
             .register_action(spawn_task_or_modal)
             .register_action(|workspace, _: &ToggleFocus, window, cx| {
@@ -165,24 +159,20 @@ pub fn init(cx: &mut App) {
                                 return;
                             };
 
-                                if let Some(existing) = workspace.item_of_type::<StackTraceView>(cx)
+                            if let Some(existing) = workspace.item_of_type::<StackTraceView>(cx) {
-                                {
                                 let is_active = workspace
                                     .active_item(cx)
                                     .is_some_and(|item| item.item_id() == existing.item_id());
-                                    workspace
+                                workspace.activate_item(&existing, true, !is_active, window, cx);
-                                        .activate_item(&existing, true, !is_active, window, cx);
                             } else {
-                                    let Some(active_session) =
+                                let Some(active_session) = debug_panel.read(cx).active_session()
-                                        debug_panel.read(cx).active_session()
                                 else {
                                     return;
                                 };
 
                                 let project = workspace.project();
 
-                                    let stack_trace_view =
+                                let stack_trace_view = active_session.update(cx, |session, cx| {
-                                        active_session.update(cx, |session, cx| {
                                     session.stack_trace_view(project, window, cx).clone()
                                 });
 
@@ -229,7 +219,6 @@ pub fn init(cx: &mut App) {
                 })
             });
     })
-    })
     .detach();
 
     cx.observe_new({

crates/editor/Cargo.toml

@@ -40,7 +40,6 @@ dap.workspace = true
 db.workspace = true
 buffer_diff.workspace = true
 emojis.workspace = true
-feature_flags.workspace = true
 file_icons.workspace = true
 futures.workspace = true
 fuzzy.workspace = true

crates/editor/src/editor.rs

@@ -73,7 +73,6 @@ use element::{AcceptEditPredictionBinding, LineWithInvisibles, PositionMap, layo
 pub use element::{
     CursorLayout, EditorElement, HighlightedRange, HighlightedRangeLine, PointForPosition,
 };
-use feature_flags::{DebuggerFeatureFlag, FeatureFlagAppExt};
 use futures::{
     FutureExt, StreamExt as _,
     future::{self, Shared, join},
@@ -5969,7 +5968,6 @@ impl Editor {
         buffer: &Entity<Buffer>,
         cx: &mut App,
     ) -> Task<Vec<task::DebugScenario>> {
-        if cx.has_flag::<DebuggerFeatureFlag>() {
         maybe!({
             let project = self.project.as_ref()?;
             let dap_store = project.read(cx).dap_store();
@@ -6005,9 +6003,6 @@ impl Editor {
             }))
         })
         .unwrap_or_else(|| Task::ready(vec![]))
-        } else {
-            Task::ready(vec![])
-        }
     }
 
     fn code_actions(
@@ -10155,9 +10150,6 @@ impl Editor {
         window: &mut Window,
         cx: &mut Context<Self>,
     ) {
-        if !cx.has_flag::<DebuggerFeatureFlag>() {
-            return;
-        }
         let source = self
             .buffer
             .read(cx)

crates/editor/src/element.rs

@@ -32,7 +32,6 @@ use crate::{
 };
 use buffer_diff::{DiffHunkStatus, DiffHunkStatusKind};
 use collections::{BTreeMap, HashMap};
-use feature_flags::{DebuggerFeatureFlag, FeatureFlagAppExt};
 use file_icons::FileIcons;
 use git::{
     Oid,
@@ -567,13 +566,11 @@ impl EditorElement {
         register_action(editor, window, Editor::insert_uuid_v4);
         register_action(editor, window, Editor::insert_uuid_v7);
         register_action(editor, window, Editor::open_selections_in_multibuffer);
-        if cx.has_flag::<DebuggerFeatureFlag>() {
         register_action(editor, window, Editor::toggle_breakpoint);
         register_action(editor, window, Editor::edit_log_breakpoint);
         register_action(editor, window, Editor::enable_breakpoint);
         register_action(editor, window, Editor::disable_breakpoint);
     }
-    }
 
     fn register_key_listeners(&self, window: &mut Window, _: &mut App, layout: &EditorLayout) {
         let position_map = layout.position_map.clone();
@@ -8173,13 +8170,11 @@ impl Element for EditorElement {
                     let mut breakpoint_rows = self.editor.update(cx, |editor, cx| {
                         editor.active_breakpoints(start_row..end_row, window, cx)
                     });
-                    if cx.has_flag::<DebuggerFeatureFlag>() {
                     for (display_row, (_, bp, state)) in &breakpoint_rows {
                         if bp.is_enabled() && state.is_none_or(|s| s.verified) {
                             active_rows.entry(*display_row).or_default().breakpoint = true;
                         }
                     }
-                    }
 
                     let line_numbers = self.layout_line_numbers(
                         Some(&gutter_hitbox),
@@ -8198,7 +8193,6 @@ impl Element for EditorElement {
                     // We add the gutter breakpoint indicator to breakpoint_rows after painting
                     // line numbers so we don't paint a line number debug accent color if a user
                     // has their mouse over that line when a breakpoint isn't there
-                    if cx.has_flag::<DebuggerFeatureFlag>() {
                     self.editor.update(cx, |editor, _| {
                         if let Some(phantom_breakpoint) = &mut editor
                             .gutter_breakpoint_indicator
@@ -8215,13 +8209,11 @@ impl Element for EditorElement {
                                         Bias::Right,
                                     );
                                     let breakpoint = Breakpoint::new_standard();
-                                        phantom_breakpoint.collides_with_existing_breakpoint =
+                                    phantom_breakpoint.collides_with_existing_breakpoint = false;
-                                            false;
                                     (position, breakpoint, None)
                                 });
                         }
-                        })
+                    });
-                    }
 
                     let mut expand_toggles =
                         window.with_element_namespace("expand_toggles", |window| {
@@ -8690,7 +8682,7 @@ impl Element for EditorElement {
                     let show_breakpoints = snapshot
                         .show_breakpoints
                         .unwrap_or(gutter_settings.breakpoints);
-                    let breakpoints = if cx.has_flag::<DebuggerFeatureFlag>() && show_breakpoints {
+                    let breakpoints = if show_breakpoints {
                         self.layout_breakpoints(
                             line_height,
                             start_row..end_row,
@@ -8705,7 +8697,7 @@ impl Element for EditorElement {
                             cx,
                         )
                     } else {
-                        vec![]
+                        Vec::new()
                     };
 
                     self.layout_signature_help(

crates/feature_flags/src/feature_flags.rs

@@ -77,11 +77,6 @@ impl FeatureFlag for NotebookFeatureFlag {
     const NAME: &'static str = "notebooks";
 }
 
-pub struct DebuggerFeatureFlag {}
-impl FeatureFlag for DebuggerFeatureFlag {
-    const NAME: &'static str = "debugger";
-}
-
 pub struct ThreadAutoCaptureFeatureFlag {}
 impl FeatureFlag for ThreadAutoCaptureFeatureFlag {
     const NAME: &'static str = "thread-auto-capture";

crates/zed/Cargo.toml

@@ -55,7 +55,6 @@ env_logger.workspace = true
 extension.workspace = true
 extension_host.workspace = true
 extensions_ui.workspace = true
-feature_flags.workspace = true
 feedback.workspace = true
 file_finder.workspace = true
 fs.workspace = true

crates/zed/src/zed.rs

@@ -20,16 +20,15 @@ use collections::VecDeque;
 use debugger_ui::debugger_panel::DebugPanel;
 use editor::ProposedChangesEditorToolbar;
 use editor::{Editor, MultiBuffer, scroll::Autoscroll};
-use feature_flags::{DebuggerFeatureFlag, FeatureFlagViewExt};
 use futures::future::Either;
 use futures::{StreamExt, channel::mpsc, select_biased};
 use git_ui::git_panel::GitPanel;
 use git_ui::project_diff::ProjectDiffToolbar;
 use gpui::{
-    Action, App, AppContext as _, AsyncWindowContext, Context, DismissEvent, Element, Entity,
+    Action, App, AppContext as _, Context, DismissEvent, Element, Entity, Focusable, KeyBinding,
-    Focusable, KeyBinding, ParentElement, PathPromptOptions, PromptLevel, ReadGlobal, SharedString,
+    ParentElement, PathPromptOptions, PromptLevel, ReadGlobal, SharedString, Styled, Task,
-    Styled, Task, TitlebarOptions, UpdateGlobal, Window, WindowKind, WindowOptions, actions,
+    TitlebarOptions, UpdateGlobal, Window, WindowKind, WindowOptions, actions, image_cache, point,
-    image_cache, point, px, retain_all,
+    px, retain_all,
 };
 use image_viewer::ImageInfo;
 use migrate::{MigrationBanner, MigrationEvent, MigrationNotification, MigrationType};
@@ -480,6 +479,7 @@ fn initialize_panels(
             workspace_handle.clone(),
             cx.clone(),
         );
+        let debug_panel = DebugPanel::load(workspace_handle.clone(), cx);
 
         let (
             project_panel,
@@ -489,6 +489,7 @@ fn initialize_panels(
             channels_panel,
             chat_panel,
             notification_panel,
+            debug_panel,
         ) = futures::try_join!(
             project_panel,
             outline_panel,
@@ -497,6 +498,7 @@ fn initialize_panels(
             channels_panel,
             chat_panel,
             notification_panel,
+            debug_panel,
         )?;
 
         workspace_handle.update_in(cx, |workspace, window, cx| {
@@ -507,21 +509,8 @@ fn initialize_panels(
             workspace.add_panel(channels_panel, window, cx);
             workspace.add_panel(chat_panel, window, cx);
             workspace.add_panel(notification_panel, window, cx);
-            cx.when_flag_enabled::<DebuggerFeatureFlag>(window, |_, window, cx| {
-                cx.spawn_in(
-                    window,
-                    async move |workspace: gpui::WeakEntity<Workspace>,
-                                cx: &mut AsyncWindowContext| {
-                        let debug_panel = DebugPanel::load(workspace.clone(), cx).await?;
-                        workspace.update_in(cx, |workspace, window, cx| {
             workspace.add_panel(debug_panel, window, cx);
         })?;
-                        anyhow::Ok(())
-                    },
-                )
-                .detach()
-            });
-        })?;
 
         let is_assistant2_enabled = !cfg!(test);
         let agent_panel = if is_assistant2_enabled {